From 73d0552a2afe55cf3098c6fda3397af2fe3c3e39 Mon Sep 17 00:00:00 2001 From: woblight Date: Wed, 25 Jul 2018 15:40:06 +0200 Subject: [PATCH] Addon::updateGitStatus: free before return --- addon.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/addon.cpp b/addon.cpp index 358ae4f..de3b510 100644 --- a/addon.cpp +++ b/addon.cpp @@ -276,6 +276,12 @@ void Addon::updateGitStatus() size_t ahead; size_t behind; git_graph_ahead_behind(&ahead, &behind, m_repo.get(), git_annotated_commit_id(lc), git_annotated_commit_id(uc)); + + git_reference_free(tr); + git_reference_free(lr); + git_annotated_commit_free(uc); + git_annotated_commit_free(lc); + if (!(ahead || behind)) return GitStatusFlag::UpToDate; else if (ahead && !behind) @@ -285,11 +291,6 @@ void Addon::updateGitStatus() else return GitStatusFlag::Diverged; - - git_reference_free(tr); - git_reference_free(lr); - git_annotated_commit_free(uc); - git_annotated_commit_free(lc); /// TODO: check for local changes/merge /*if (git_repository_head_detached(m_repo.get())) { setGitStatus(GitStatus::Conflicting);