From 52af32daaaca53c0bb78820a08efa63ad5cbaf5c Mon Sep 17 00:00:00 2001 From: Salikh Gurgenidze Date: Sat, 24 Jan 2026 12:36:48 +0400 Subject: [PATCH] fix: Added isUnusable detection with caching --- Core/ItemDetection.lua | 70 +++++++++++++++++++++++- Core/Tooltip.lua | 14 ++--- Core/Utils.lua | 33 ++++++++++++ Data/BankScanner.lua | 12 ++--- Data/EquipmentScanner.lua | 14 ++--- Data/MoneyTracker.lua | 14 ++--- Sorting/SortEngine.lua | 110 +++++++++++++++----------------------- UI/BagFrame.lua | 16 +----- UI/BankFrame.lua | 50 +++++++---------- UI/ItemButton.lua | 95 ++++---------------------------- UI/QuestItemBar.lua | 14 ++--- UI/TrackedItemBar.lua | 14 ++--- 12 files changed, 198 insertions(+), 258 deletions(-) diff --git a/Core/ItemDetection.lua b/Core/ItemDetection.lua index 4d90cee..dcda5c8 100644 --- a/Core/ItemDetection.lua +++ b/Core/ItemDetection.lua @@ -91,18 +91,25 @@ local function ScanTooltipLines(bagID, slotID, itemLink) local leftText = leftLine and leftLine:GetText() or "" local rightText = rightLine and rightLine:GetText() or "" - -- Get text colors (for detecting yellow/green text) + -- Get left text colors (for detecting yellow/green/red text) local lr, lg, lb, la = 1, 1, 1, 1 if leftLine and leftLine.GetTextColor then lr, lg, lb, la = leftLine:GetTextColor() end + -- Get right text colors (for detecting red requirements) + local rr, rg, rb, ra = 1, 1, 1, 1 + if rightLine and rightLine.GetTextColor then + rr, rg, rb, ra = rightLine:GetTextColor() + end + table.insert(lines, { left = leftText, right = rightText, leftLower = leftText and string.lower(leftText) or "", rightLower = rightText and string.lower(rightText) or "", r = lr, g = lg, b = lb, + rightR = rr, rightG = rg, rightB = rb, }) end @@ -255,12 +262,63 @@ local function DetectQuestUsable(lines) return false end +-- Durability pattern for filtering out broken item red text +local durabilityPattern = DURABILITY_TEMPLATE and string.gsub(DURABILITY_TEMPLATE, "%%d", "%%d+") or nil + +-- Check if text color is red (unusable requirement) +local function IsRedColor(r, g, b) + if not r or not g or not b then return false end + -- RED_FONT_COLOR is typically (1.0, 0.1, 0.1) + local dr = math.abs(r - 1.0) + local dg = math.abs(g - 0.125) + local db = math.abs(b - 0.125) + return (dr < 0.15 and dg < 0.15 and db < 0.15) +end + +-- Check if item is unusable (has red text indicating unmet requirements) +-- Excludes durability lines (broken items show red durability) +local function DetectUnusable(lines) + for _, line in ipairs(lines) do + if line.r and line.g and line.b then + -- Check for red text (requirements not met) + local isRed = IsRedColor(line.r, line.g, line.b) or + (line.r > 0.85 and line.g < 0.3 and line.b < 0.3) + + if isRed then + local text = line.left or "" + -- Ignore durability lines (broken items) + if durabilityPattern and string.find(text, durabilityPattern) then + -- skip durability + else + return true + end + end + end + + -- Also check right column (some requirements appear there) + if line.rightR and line.rightG and line.rightB then + local isRed = IsRedColor(line.rightR, line.rightG, line.rightB) or + (line.rightR > 0.85 and line.rightG < 0.3 and line.rightB < 0.3) + + if isRed then + local text = line.right or "" + if durabilityPattern and string.find(text, durabilityPattern) then + -- skip durability + else + return true + end + end + end + end + return false +end + --===================================================== -- Public API - Cached Detection --===================================================== -- Get all item properties at once (cached) --- Returns: { isQuestItem, isQuestStarter, isQuestUsable, isJunk, isPermanentEnchant } +-- Returns: { isQuestItem, isQuestStarter, isQuestUsable, isJunk, isPermanentEnchant, isUnusable } function ItemDetection:GetItemProperties(itemData, bagID, slotID) if not itemData then return { @@ -269,6 +327,7 @@ function ItemDetection:GetItemProperties(itemData, bagID, slotID) isQuestUsable = false, isJunk = false, isPermanentEnchant = false, + isUnusable = false, } end @@ -296,6 +355,7 @@ function ItemDetection:GetItemProperties(itemData, bagID, slotID) local isQuestItem, isQuestStarter = DetectQuestItem(lines, itemData) local isQuestUsable = DetectQuestUsable(lines) local isJunk = DetectJunk(lines, itemData) + local isUnusable = DetectUnusable(lines) -- Debug: log junk detection for gray items if addon.DEBUG then @@ -320,6 +380,7 @@ function ItemDetection:GetItemProperties(itemData, bagID, slotID) isQuestUsable = isQuestUsable, isJunk = isJunk, isPermanentEnchant = isPermanentEnchant, + isUnusable = isUnusable, } -- Cache result @@ -356,6 +417,11 @@ function ItemDetection:IsPermanentEnchant(itemData, bagID, slotID) return props.isPermanentEnchant end +function ItemDetection:IsUnusable(itemData, bagID, slotID) + local props = self:GetItemProperties(itemData, bagID, slotID) + return props.isUnusable +end + --===================================================== -- Initialization --===================================================== diff --git a/Core/Tooltip.lua b/Core/Tooltip.lua index 7c34881..bd790ab 100644 --- a/Core/Tooltip.lua +++ b/Core/Tooltip.lua @@ -615,16 +615,10 @@ function Tooltip:Initialize() if event == "BAG_UPDATE" then if cacheClearPending then return end cacheClearPending = true - -- Debounce: batch rapid BAG_UPDATE events - local debounceFrame = CreateFrame("Frame") - debounceFrame.elapsed = 0 - debounceFrame:SetScript("OnUpdate", function() - this.elapsed = this.elapsed + arg1 - if this.elapsed >= 0.2 then - this:SetScript("OnUpdate", nil) - cacheClearPending = false - Tooltip:ClearCache() - end + -- Debounce: batch rapid BAG_UPDATE events (uses pooled timer) + Guda_ScheduleTimer(0.2, function() + cacheClearPending = false + Tooltip:ClearCache() end) end end) diff --git a/Core/Utils.lua b/Core/Utils.lua index 6a9980b..88d9bff 100644 --- a/Core/Utils.lua +++ b/Core/Utils.lua @@ -5,6 +5,39 @@ local addon = Guda local Utils = {} addon.Modules.Utils = Utils +--============================================================================= +-- Timer Frame Pool (prevents memory leaks from temporary timers) +-- Global function so all modules can use it +--============================================================================= +local timerPool = {} +local TIMER_POOL_MAX = 10 -- Limit pool size to prevent unbounded growth + +function Guda_ScheduleTimer(delay, callback) + -- Try to get a frame from the pool + local frame = table.remove(timerPool) + if not frame then + frame = CreateFrame("Frame") + end + + frame.elapsed = 0 + frame.delay = delay + frame.callback = callback + frame:SetScript("OnUpdate", function() + this.elapsed = this.elapsed + arg1 + if this.elapsed >= this.delay then + this:SetScript("OnUpdate", nil) + this:Hide() + -- Return frame to pool if not full + if table.getn(timerPool) < TIMER_POOL_MAX then + table.insert(timerPool, this) + end + -- Execute callback + this.callback() + end + end) + frame:Show() +end + --============================================================================= -- Tooltip Scan Caching -- Caches results of expensive tooltip scanning operations diff --git a/Data/BankScanner.lua b/Data/BankScanner.lua index a919a5f..d88b9b3 100644 --- a/Data/BankScanner.lua +++ b/Data/BankScanner.lua @@ -188,15 +188,9 @@ function BankScanner:Initialize() BankScanner:ClearCache() -- Clear cache on open addon:Debug("Bank opened") - -- Delay scan to ensure bank is fully loaded - local frame = CreateFrame("Frame") - local elapsed = 0 - frame:SetScript("OnUpdate", function() - elapsed = elapsed + arg1 - if elapsed >= 0.5 then - frame:SetScript("OnUpdate", nil) - BankScanner:SaveToDatabase() - end + -- Delay scan to ensure bank is fully loaded (uses pooled timer) + Guda_ScheduleTimer(0.5, function() + BankScanner:SaveToDatabase() end) end, "BankScanner") diff --git a/Data/EquipmentScanner.lua b/Data/EquipmentScanner.lua index 1de3f7c..d145ec8 100644 --- a/Data/EquipmentScanner.lua +++ b/Data/EquipmentScanner.lua @@ -91,16 +91,10 @@ function EquipmentScanner:Initialize() playerLoggedIn = true addon:Print("Scanning equipped items...") - -- Delay scan to ensure character is fully loaded - local frame = CreateFrame("Frame") - local elapsed = 0 - frame:SetScript("OnUpdate", function() - elapsed = elapsed + arg1 - if elapsed >= 2.0 then - frame:SetScript("OnUpdate", nil) - EquipmentScanner:SaveToDatabase() - addon:Print("Equipped items scanned and saved!") - end + -- Delay scan to ensure character is fully loaded (uses pooled timer) + Guda_ScheduleTimer(2.0, function() + EquipmentScanner:SaveToDatabase() + addon:Print("Equipped items scanned and saved!") end) end, "EquipmentScanner") diff --git a/Data/MoneyTracker.lua b/Data/MoneyTracker.lua index 0ecc772..2165bd7 100644 --- a/Data/MoneyTracker.lua +++ b/Data/MoneyTracker.lua @@ -36,17 +36,11 @@ function MoneyTracker:Initialize() MoneyTracker:Update() end, "MoneyTracker") - -- Initial update and save on login + -- Initial update and save on login (uses pooled timer) addon.Modules.Events:OnPlayerLogin(function() - local frame = CreateFrame("Frame") - local elapsed = 0 - frame:SetScript("OnUpdate", function() - elapsed = elapsed + arg1 - if elapsed >= 1 then - frame:SetScript("OnUpdate", nil) - MoneyTracker:Update() - addon:Debug("Initial money saved") - end + Guda_ScheduleTimer(1, function() + MoneyTracker:Update() + addon:Debug("Initial money saved") end) end, "MoneyTracker") end diff --git a/Sorting/SortEngine.lua b/Sorting/SortEngine.lua index 63a418f..5c0baaf 100644 --- a/Sorting/SortEngine.lua +++ b/Sorting/SortEngine.lua @@ -1722,52 +1722,42 @@ function SortEngine:ExecuteSort(sortFunction, analyzeFunction, updateFrame, sort -- Sorting is complete! addon:DebugSort("%s sort complete! (%d passes, %d total moves)", sortType, passCount, totalMoves) - -- Final update (cache clearing happens after delay) - local frame = CreateFrame("Frame") - local startTime = GetTime() - frame:SetScript("OnUpdate", function() - if GetTime() - startTime >= 0.3 then - frame:SetScript("OnUpdate", nil) - SortEngine.sortingInProgress = false - SortEngine:UpdateSortButtonState(false) - currentSortType = "bags" -- Reset sort context - -- Clear caches after sorting to ensure fresh detection - if sortType == "bank" then - addon.Modules.BankScanner:ClearCache() - else - addon.Modules.BagScanner:ClearCache() - end - if addon.Modules.ItemDetection then - addon.Modules.ItemDetection:ClearCache() - end - updateFrame() + -- Final update (cache clearing happens after delay, uses pooled timer) + Guda_ScheduleTimer(0.3, function() + SortEngine.sortingInProgress = false + SortEngine:UpdateSortButtonState(false) + currentSortType = "bags" -- Reset sort context + -- Clear caches after sorting to ensure fresh detection + if sortType == "bank" then + addon.Modules.BankScanner:ClearCache() + else + addon.Modules.BagScanner:ClearCache() end + if addon.Modules.ItemDetection then + addon.Modules.ItemDetection:ClearCache() + end + updateFrame() end) elseif passCount >= safetyLimit then -- Hit safety limit but not fully sorted addon:DebugSort("%s sort stopped at safety limit! (%d/%d items still need sorting after %d passes)", sortType, currentAnalysis.itemsOutOfPlace, currentAnalysis.totalItems, passCount) - -- Final update (cache clearing happens after delay) - local frame = CreateFrame("Frame") - local startTime = GetTime() - frame:SetScript("OnUpdate", function() - if GetTime() - startTime >= 0.3 then - frame:SetScript("OnUpdate", nil) - SortEngine.sortingInProgress = false - SortEngine:UpdateSortButtonState(false) - currentSortType = "bags" -- Reset sort context - -- Clear caches after sorting to ensure fresh detection - if sortType == "bank" then - addon.Modules.BankScanner:ClearCache() - else - addon.Modules.BagScanner:ClearCache() - end - if addon.Modules.ItemDetection then - addon.Modules.ItemDetection:ClearCache() - end - updateFrame() + -- Final update (cache clearing happens after delay, uses pooled timer) + Guda_ScheduleTimer(0.3, function() + SortEngine.sortingInProgress = false + SortEngine:UpdateSortButtonState(false) + currentSortType = "bags" -- Reset sort context + -- Clear caches after sorting to ensure fresh detection + if sortType == "bank" then + addon.Modules.BankScanner:ClearCache() + else + addon.Modules.BagScanner:ClearCache() end + if addon.Modules.ItemDetection then + addon.Modules.ItemDetection:ClearCache() + end + updateFrame() end) else -- No progress guard: stop if we make no moves repeatedly @@ -1781,26 +1771,21 @@ function SortEngine:ExecuteSort(sortFunction, analyzeFunction, updateFrame, sort addon:DebugSort("%s sort stopped due to no progress after %d passes (items remaining: %d/%d)", sortType, passCount, currentAnalysis.itemsOutOfPlace, currentAnalysis.totalItems) - -- Final update (cache clearing happens after delay) - local frame = CreateFrame("Frame") - local startTime = GetTime() - frame:SetScript("OnUpdate", function() - if GetTime() - startTime >= 0.3 then - frame:SetScript("OnUpdate", nil) - SortEngine.sortingInProgress = false - SortEngine:UpdateSortButtonState(false) - currentSortType = "bags" -- Reset sort context - -- Clear caches after sorting to ensure fresh detection - if sortType == "bank" then - addon.Modules.BankScanner:ClearCache() - else - addon.Modules.BagScanner:ClearCache() - end - if addon.Modules.ItemDetection then - addon.Modules.ItemDetection:ClearCache() - end - updateFrame() + -- Final update (cache clearing happens after delay, uses pooled timer) + Guda_ScheduleTimer(0.3, function() + SortEngine.sortingInProgress = false + SortEngine:UpdateSortButtonState(false) + currentSortType = "bags" -- Reset sort context + -- Clear caches after sorting to ensure fresh detection + if sortType == "bank" then + addon.Modules.BankScanner:ClearCache() + else + addon.Modules.BagScanner:ClearCache() end + if addon.Modules.ItemDetection then + addon.Modules.ItemDetection:ClearCache() + end + updateFrame() end) return end @@ -1819,15 +1804,8 @@ function SortEngine:ExecuteSort(sortFunction, analyzeFunction, updateFrame, sort addon:DebugSort("Waiting %.1f seconds before next pass...", totalDelay) - -- Wait with progressive delay, then sort again - local frame = CreateFrame("Frame") - local startTime = GetTime() - frame:SetScript("OnUpdate", function() - if GetTime() - startTime >= totalDelay then - frame:SetScript("OnUpdate", nil) - DoSortPass() -- Recursive call for next pass - end - end) + -- Wait with progressive delay, then sort again (uses pooled timer) + Guda_ScheduleTimer(totalDelay, DoSortPass) end end diff --git a/UI/BagFrame.lua b/UI/BagFrame.lua index 7c97a5b..90778af 100644 --- a/UI/BagFrame.lua +++ b/UI/BagFrame.lua @@ -1849,20 +1849,8 @@ function Guda_BagFrame_MergeStacks() ProcessNextMove() end --- Simple timer helper -function Guda_ScheduleTimer(delay, callback) - local frame = CreateFrame("Frame") - frame.elapsed = 0 - frame.delay = delay - frame.callback = callback - frame:SetScript("OnUpdate", function() - this.elapsed = this.elapsed + arg1 - if this.elapsed >= this.delay then - this:SetScript("OnUpdate", nil) - this.callback() - end - end) -end +-- NOTE: Guda_ScheduleTimer is defined in Core/Utils.lua (loaded earlier) +-- to ensure it's available for all modules that need timers -- Hook bag container buttons to open Guda Bag View local function HookBagContainers() diff --git a/UI/BankFrame.lua b/UI/BankFrame.lua index cb206ad..2da25fa 100644 --- a/UI/BankFrame.lua +++ b/UI/BankFrame.lua @@ -1611,40 +1611,28 @@ function BankFrame:Initialize() -- Update when bank is opened addon.Modules.Events:OnBankOpen(function() - -- Delay showing custom bank to let TransmogUI finish processing - local frame = CreateFrame("Frame") - local elapsed = 0 - frame:SetScript("OnUpdate", function() - elapsed = elapsed + arg1 - if elapsed >= 0.2 then - frame:SetScript("OnUpdate", nil) + -- Delay showing custom bank to let TransmogUI finish processing (uses pooled timer) + Guda_ScheduleTimer(0.2, function() + -- Show current character's bank in interactive mode + currentViewChar = nil - -- Show current character's bank in interactive mode - currentViewChar = nil + -- Do not auto-hide BagFrame when opening BankFrame + -- Users may want both frames visible simultaneously; layout issues, if any, + -- should be addressed via positioning rather than auto-hiding. - -- Do not auto-hide BagFrame when opening BankFrame - -- Previously, we hid BagFrame to prevent button overlap: - -- local bagFrame = getglobal("Guda_BagFrame") - -- if bagFrame and bagFrame:IsShown() then - -- bagFrame:Hide() - -- end - -- Users may want both frames visible simultaneously; layout issues, if any, - -- should be addressed via positioning rather than auto-hiding. - - -- Show and update custom bank frame - local customBankFrame = getglobal("Guda_BankFrame") - if customBankFrame then - customBankFrame:Show() - end - - -- Force disable pfUI banks if enabled (pfUI uses pfBank for its bank frame) - if pfUI and pfUI.bag and pfUI.bag.left and pfUI.bag.left.Hide then - pfUI.bag.left:Hide() - end - - addon.Modules.BankFrame:EnsureBagButtonsInitialized() - addon.Modules.BankFrame:Update() + -- Show and update custom bank frame + local customBankFrame = getglobal("Guda_BankFrame") + if customBankFrame then + customBankFrame:Show() end + + -- Force disable pfUI banks if enabled (pfUI uses pfBank for its bank frame) + if pfUI and pfUI.bag and pfUI.bag.left and pfUI.bag.left.Hide then + pfUI.bag.left:Hide() + end + + addon.Modules.BankFrame:EnsureBagButtonsInitialized() + addon.Modules.BankFrame:Update() end) end, "BankFrameUI") diff --git a/UI/ItemButton.lua b/UI/ItemButton.lua index cfba5db..6b4874f 100644 --- a/UI/ItemButton.lua +++ b/UI/ItemButton.lua @@ -110,91 +110,10 @@ local function Guda_GetUnusableColor() return 0.9, 0.2, 0.2, 1.0 end --- Build durability match pattern based on the client template -local durabilityPattern -if DURABILITY_TEMPLATE then - -- e.g. "Durability %d / %d" -> "Durability (.+)" - durabilityPattern = string.gsub(DURABILITY_TEMPLATE, "%%[^%s]+", "(.+)") -end - --- Tiny helper to compare font color to Blizzard's RED_FONT_COLOR -local function IsRedColor(r, g, b) - if not r or not g or not b or not RED_FONT_COLOR then return false end - local dr = math.abs(r - RED_FONT_COLOR.r) - local dg = math.abs(g - RED_FONT_COLOR.g) - local db = math.abs(b - RED_FONT_COLOR.b) - return (dr < 0.08 and dg < 0.08 and db < 0.08) -end - --- Scan tooltip for red text that is NOT a durability line --- Uses shared tooltip from Utils module -local function IsItemUnusable(bagID, slotID, isBank) - bagID = tonumber(bagID) - slotID = tonumber(slotID) - if not bagID or not slotID then return false end - - -- Get shared tooltip from Utils - local scanTooltip, tooltipName = addon.Modules.Utils:GetScanTooltip() - - -- Some clients require SetOwner before every SetBagItem/SetInventoryItem to populate lines - if scanTooltip.SetOwner then - scanTooltip:SetOwner(UIParent or WorldFrame, "ANCHOR_NONE") - end - scanTooltip:ClearLines() - - if isBank and bagID == -1 then - -- Bank frame item buttons map slots 1.. to inventory slots 40.. (39 + slot) - if scanTooltip.SetInventoryItem then - scanTooltip:SetInventoryItem("player", 39 + slotID) - else - -- Fallback to bag scan if API missing - scanTooltip:SetBagItem(bagID, slotID) - end - else - scanTooltip:SetBagItem(bagID, slotID) - end - - if scanTooltip.Show then scanTooltip:Show() end - - local num = scanTooltip:NumLines() or 0 - for i = 1, num do - -- Scan LEFT column - local left = getglobal(tooltipName .. "TextLeft" .. i) - if left and left:IsShown() then - local text = left:GetText() - local r, g, b = left:GetTextColor() - -- Be tolerant with red detection in case client colors differ slightly - local isRed = IsRedColor(r, g, b) or (r and g and b and r > 0.85 and g < 0.3 and b < 0.3) - if text and isRed then - -- Ignore red durability (broken) lines - if durabilityPattern and string.find(text, durabilityPattern, 1) then - -- skip durability - else - if scanTooltip.Hide then scanTooltip:Hide() end - return true - end - end - end - - -- Scan RIGHT column as well (required level etc can appear here on some clients) - local right = getglobal(tooltipName .. "TextRight" .. i) - if right and right:IsShown() then - local text = right:GetText() - local r, g, b = right:GetTextColor() - local isRed = IsRedColor(r, g, b) or (r and g and b and r > 0.85 and g < 0.3 and b < 0.3) - if text and isRed then - if durabilityPattern and string.find(text, durabilityPattern, 1) then - -- skip durability - else - if scanTooltip.Hide then scanTooltip:Hide() end - return true - end - end - end - end - - return false -end +-- NOTE: IsItemUnusable detection is now handled by ItemDetection:IsUnusable() +-- which uses cached tooltip scanning to avoid duplicate scans per item. +-- The old IsItemUnusable, IsRedColor, and durabilityPattern have been removed +-- to prevent redundant tooltip scanning - all detection is now centralized. -- Apply/remove red tint on item texture for unusable items local function Guda_ItemButton_UpdateUsableTint(self) @@ -225,7 +144,11 @@ local function Guda_ItemButton_UpdateUsableTint(self) return end - local unusable = IsItemUnusable(self.bagID, self.slotID, self.isBank) + -- Use cached detection from ItemDetection module (avoids duplicate tooltip scans) + local unusable = false + if self.itemData and addon.Modules.ItemDetection then + unusable = addon.Modules.ItemDetection:IsUnusable(self.itemData, self.bagID, self.slotID) + end -- Ensure overlay exists (created in OnLoad, but be defensive) if not self.unusableOverlay then diff --git a/UI/QuestItemBar.lua b/UI/QuestItemBar.lua index 152982c..e8de95c 100644 --- a/UI/QuestItemBar.lua +++ b/UI/QuestItemBar.lua @@ -649,16 +649,10 @@ function QuestItemBar:Initialize() addon.Modules.Events:Register("BAG_UPDATE", function() if bagUpdatePending then return end bagUpdatePending = true - -- Debounce: wait 0.15 seconds before updating to batch rapid events - local debounceFrame = CreateFrame("Frame") - debounceFrame.elapsed = 0 - debounceFrame:SetScript("OnUpdate", function() - this.elapsed = this.elapsed + arg1 - if this.elapsed >= 0.15 then - this:SetScript("OnUpdate", nil) - bagUpdatePending = false - QuestItemBar:Update() - end + -- Debounce: wait 0.15 seconds before updating (uses pooled timer) + Guda_ScheduleTimer(0.15, function() + bagUpdatePending = false + QuestItemBar:Update() end) end, "QuestItemBar") diff --git a/UI/TrackedItemBar.lua b/UI/TrackedItemBar.lua index 0244f19..304bf9e 100644 --- a/UI/TrackedItemBar.lua +++ b/UI/TrackedItemBar.lua @@ -312,16 +312,10 @@ function TrackedItemBar:Initialize() addon.Modules.Events:Register("BAG_UPDATE", function() if bagUpdatePending then return end bagUpdatePending = true - -- Debounce: wait 0.15 seconds before updating to batch rapid events - local debounceFrame = CreateFrame("Frame") - debounceFrame.elapsed = 0 - debounceFrame:SetScript("OnUpdate", function() - this.elapsed = this.elapsed + arg1 - if this.elapsed >= 0.15 then - this:SetScript("OnUpdate", nil) - bagUpdatePending = false - TrackedItemBar:Update() - end + -- Debounce: wait 0.15 seconds before updating (uses pooled timer) + Guda_ScheduleTimer(0.15, function() + bagUpdatePending = false + TrackedItemBar:Update() end) end, "TrackedItemBar")