Do not mask local MPQ install failures
This commit is contained in:
+6
-2
@@ -1731,15 +1731,19 @@ class WowSetupTool:
|
|||||||
if self.visual_mods[key].get():
|
if self.visual_mods[key].get():
|
||||||
try:
|
try:
|
||||||
installer(target, progress=progress)
|
installer(target, progress=progress)
|
||||||
except Exception as exc:
|
except remote_packages.RemoteSourceUnavailable as exc:
|
||||||
if remote_packages.managed_mpq_is_usable(target, managed_id):
|
if remote_packages.managed_mpq_is_usable(target, managed_id):
|
||||||
warnings.append(
|
warnings.append(
|
||||||
f"{display_name}: update source unavailable; existing installed copy kept."
|
f"{display_name}: update source unavailable; existing installed copy kept."
|
||||||
)
|
)
|
||||||
else:
|
else:
|
||||||
raise RuntimeError(
|
raise RuntimeError(
|
||||||
f"{display_name} installation failed and no valid installed copy can be kept:\n{exc}"
|
f"{display_name} source is unavailable and no valid installed copy can be kept:\n{exc}"
|
||||||
) from exc
|
) from exc
|
||||||
|
except Exception as exc:
|
||||||
|
raise RuntimeError(
|
||||||
|
f"{display_name} installation failed locally:\n{exc}"
|
||||||
|
) from exc
|
||||||
else:
|
else:
|
||||||
remote_packages.remove_managed_mod(target, managed_id)
|
remote_packages.remove_managed_mod(target, managed_id)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user