WIP: Temporary V35 Retail build #5

Closed
Dusk-92 wants to merge 132 commits from test/safe-core-v8-retail35 into main
Showing only changes of commit e5acd33f0c - Show all commits
+16 -33
View File
@@ -163,45 +163,28 @@ jobs:
print("outline.dll machine code: registration and callback ABIs verified") print("outline.dll machine code: registration and callback ABIs verified")
PY PY
- name: Verify UnitGUID native ECX ABI - name: Verify direct player and target GUID path
shell: bash shell: bash
run: | run: |
set -euo pipefail set -euo pipefail
python3 - <<'PY' python3 - <<'PY'
from pathlib import Path from pathlib import Path
src = Path("src/wow.zig").read_text() wow = Path("src/wow.zig").read_text()
offsets = Path("src/offsets.zig").read_text()
for required in ( for required in (
'pub fn unitGUID', 'const guid = getPlayerGUID();',
'callconv(.{ .x86_thiscall = .{} }) u64', 'return readGUID(o.LOCKED_TARGET_GUID);',
'@call(.never_tail, f_native, .{unit_id})',
): ):
if required not in src: if required not in wow:
raise SystemExit(f"Missing UnitGUID ABI fix piece: {required}") raise SystemExit(f"Missing direct player/target GUID path: {required}")
print("source: UnitGUID uses native ECX ABI") for required in (
PY 'FN_GET_PLAYER_GUID: usize = 0x00468550',
'LOCKED_TARGET_GUID: usize = 0x00B4E2D8',
objdump -d -Mintel zig-out/variants/outline.dll > /tmp/outline.disasm 'FN_GET_OBJECT_BY_GUID: usize = 0x464870',
python3 - <<'PY' ):
import re if required not in offsets:
from pathlib import Path raise SystemExit(f"Missing verified WoW offset: {required}")
print("source: player GUID, target GUID and GUID->object path verified")
lines = Path("/tmp/outline.disasm").read_text(errors="replace").splitlines()
sites = []
for i, line in enumerate(lines):
if re.search(r"mov\s+eax,0x0*515970\b", line, re.I):
block = "\n".join(lines[max(0, i - 5):i + 5])
sites.append(block)
if re.search(r"push\s+0x[0-9a-f]+\s*\n\s*[0-9a-f]+:.*call\s+eax", block, re.I):
raise SystemExit("BAD ABI: UnitGUID argument is still pushed on stack")
if not re.search(r"mov\s+ecx,", block, re.I):
raise SystemExit("BAD ABI: UnitGUID call does not prepare ECX")
if not sites:
raise SystemExit("Could not find UnitGUID call sites in outline.dll")
print(f"UnitGUID machine code: {len(sites)} call site(s), ECX ABI verified")
for block in sites:
print(block)
PY PY
- name: Stage package - name: Stage package
@@ -222,7 +205,7 @@ jobs:
cat > package/README_TEST.txt <<'EOF' cat > package/README_TEST.txt <<'EOF'
WeirdUtils Safe Standalone Core Test V8 DEBUG WeirdUtils Safe Standalone Core Test V8 DEBUG
This build fixes the x86 ABIs used by the standalone Outline path: FrameScript_RegisterFunction gets name in ECX + callback in EDX, OutlineCommand receives Lua state in ECX, and UnitGUID receives its unit id in ECX without leaking stack space. WoW Lua API calls stay on explicit native register wrappers. This debug build uses ClntObjMgrGetActivePlayer for the local player and the locked target GUID at 0xB4E2D8, matching Nampower's proven object path. WoW Lua API calls stay on explicit native register wrappers.
outline.dll outline.dll
- Adds OutlineDebug() sticky in-game diagnostics for the render pipeline. - Adds OutlineDebug() sticky in-game diagnostics for the render pipeline.