The hunter bar called C_Spell.IsSpellInRange for Wing Clip and Arcane
Shot 50 times a second while it had an attackable target. It now turns
on C_SwingTimer's range checks for the main hand and the ranged weapon,
and reads both again on PLAYER_SWING_RANGE_UPDATE and at login.
The ranged check is Auto Shot's: the same range row as Arcane Shot
(8-35 yd), with the same Hawk Eye and ranged-weapon bonuses. The melee
check is the server's auto-attack reach, which Raptor Strike swings
with. It is Wing Clip's reach measured flat, without the height
difference, and without the 2.67 yd Wing Clip gets while both units
move. Without a ranged weapon the ranged check has no answer, so the bar
stays on the melee page.
Replace nampower's IsSpellInRange with C_Spell.IsSpellInRange. This drops
the last unguarded nampower call. The ClassicAPI function returns true,
false, or nil, so test == true and == false and leave the bar unchanged
on nil.
Drop the now-vestigial expansion plumbing.
- Delete modules/thirdparty-tbc.lua + its xml Include
- Strip 10 tbc-tagged CreateConfig calls in modules/gui.lua
- Drop the expansion arg from CreateConfig() signature + the disabled-
entry rendering path that depended on it
- Drop the showdisabled GUI toggle + its default
- Simplify pfUI:RegisterModule / pfUI:RegisterSkin to (name, func) only
- Strip the leading version arg ("vanilla:tbc", etc.) from all 114
Register call sites
- Delete the pfUI.expansion variable