The tabmouse option checked both chat panels with IsMouseOver every
frame. The hover frame behind autohide is now its own helper,
EnableHover, and each chat panel gets one. RefreshChat turns it on after
every pass, since that is where the chat frames and tabs move onto the
panels and need to pass their mouse motion on.
The datatext panels are not children of the chats; they sit over the
chats' bottoms in a higher stratum. A panel docked there passes its
motion on as part of its chat, so the tabs stay up over the datatexts.
A panel moved elsewhere does not.
pfUI.chat:UpdateTabs is now the one rule for a tab bar: hidden while a
damage meter is docked over the chat, and with tabmouse only while the
cursor is near. The meter toggle calls it instead of showing the bar
itself, which the old poll would have hidden again on the next frame.
A drag now unlocks the bars before its refresh, so they match the cursor
when it ends.
The hover frame now sits at the lowest level of its frame's subtree,
not the frame's own level. The datatext buttons sit at level 0, under
their panel, so a panel's autohide hover frame was above them.
* Add CombatLedger dock integration
Dock CombatLedger into the bottom right panel like ShaguDPS, GreedMeter
and DPSMate. The main window takes the damage slot and the first extra
window takes the threat slot. Adds a CombatLedger (Dock) checkbox under
Thirdparty > Integrations.
* CombatLedger dock: refit header buttons after docking
CombatLedger sizes its Mode/Segment buttons from the window width and only
refits them on a resize drag or appearance change. Fire its appearance hook
after each dock layout so the header fits the half-width window.
* CombatLedger dock review: stable second window, respect panel state
- Dock the lowest-numbered extra window into the threat slot and keep it
until it closes, instead of taking the first entry of a pairs() walk
that could change on every call.
- Keep docked windows hidden while the panel is collapsed, even when
CombatLedger shows them itself (auto-show on combat, group changes,
/cl show). Showing the panel respects each window's auto-hide and
grouped-only rules.
- Only touch the second window when the threat slot is ours, for
CombatLedger and GreedMeter.
- Lock docked windows: no drag or resize grip, so the panel geometry
is never saved as their floating layout.
- Refit the header once per frame, and only when a docked width changed,
instead of restyling and redrawing every window several times.
- Disable CombatLedger's own pfUI dock, which shares the config key and
turned this dock on by itself.
- Share the anchoring and threat-slot code (meters:Place,
meters:SetSecondary) with GreedMeter; use HookAddon and
hooksecurefunc instead of the compat hook and hand-written wrappers.
---------
Co-authored-by: Brues <5278969+brues-code@users.noreply.github.com>
The hook gated on an addon folder named exactly DPSMate and a first
window named DPSMate, so repacks under other folder names and renamed
windows never docked (#77). It now waits on login, checks DPSMate's
globals, resolves the first window from DPSMateSettings on every call,
and re-docks after DPSMate rebuilds its frames.
The polling lurker frame is gone. HookAddon gates on
C_AddOns.DoesAddOnExist, waits for PLAYER_LOGIN with
EventUtil.ContinueOnPlayerLogin, then runs on
EventUtil.ContinueOnAddOnLoaded. Addons loaded at startup still hook
only after every pfUI module and skin exists and after the addon's
own VARIABLES_LOADED setup. Load-on-demand addons still hook on their
ADDON_LOADED.
The "or variable" form is gone. Callers that passed a global now pass
the addon that defines it: TheoryCraft, SuperMacro, DPSMate and
Turtle_GroupUI. DPSMate names its windows from its settings, so its
hook now checks for DPSMate_DPSMate itself, as the variable lookup
used to. eqcompare's Guda check uses HookAddon too.
Each if/else that only showed one object in one branch and hid it in the other is now ClassicAPI's SetShown, which shows on any truthy value. 21 sites across 10 modules.
Register GreedMeter's primary window on the meter dock's damage slot,
mirroring the ShaguDPS integration. GreedMeter builds its windows lazily
and supports several, so frames are resolved at call time.
A second GreedMeter window docks into the panel's other half: pfUI's
dock decides fill-vs-split by whether the threat slot is filled, so hook
GreedMeter's window add/remove to reconcile that slot and re-run the
resize. Only the first two windows fit the panel; any beyond that float.
Replace raw strsplit(",", ...) color parsing across action bars, chat,
nameplates, third-party skins, player, and roll with the cached
GetStringColor / GetStringColorObject helpers, dropping the per-build
string-table allocations they created.
pfUI's built-in sorter (modules/bags.lua) always creates the sort
buttons on the right/left bag frames now, so the third-party
RegisterBagSort path's "if not pfUI.bag.right.sort" guard would skip
button-creation entirely — yet still set pfUI.thirdparty.bagsort to
the registering addon's name. Net effect: user installed SortBags or
MrPlow, our internal sort runs anyway. Silent override of user intent.
Strip the dead button-creation paths; rebind the existing buttons'
OnClick + OnEnter to the registered third-party functions instead.
Third-party addons now actually fire when the user clicks. -53 lines.
Drop the now-vestigial expansion plumbing.
- Delete modules/thirdparty-tbc.lua + its xml Include
- Strip 10 tbc-tagged CreateConfig calls in modules/gui.lua
- Drop the expansion arg from CreateConfig() signature + the disabled-
entry rendering path that depended on it
- Drop the showdisabled GUI toggle + its default
- Simplify pfUI:RegisterModule / pfUI:RegisterSkin to (name, func) only
- Strip the leading version arg ("vanilla:tbc", etc.) from all 114
Register call sites
- Delete the pfUI.expansion variable
Bugfixes:
- Fixed 40-yard range check not working for raid/party frames
- Fixed aggro indicator not displaying properly on raid/party frames
- Improved aggro cache to only cache positive results for instant detection
- Fixed HP/Mana not updating with "Use Raid Frames for group" enabled
- Added SuperWoW nil-check for SpellInfo
- Added missing events: PARTY_MEMBER_ENABLE, PARTY_MEMBER_DISABLE, PLAYER_UPDATE_RESTING
UI Improvements:
- Share/Hoverbind buttons now show warning when module is disabled
* replace shaman class color only on load the addon
* include @Road-block updates
* use pfUI link handler (it is more correct)
* replace all class colors