mirror of
https://github.com/brues-code/SuperCleveRoidMacros.git
synced 2026-09-16 03:38:00 +00:00
Use ClassicAPI GetSpellBonusDamage/Healing for spell-power conditionals
Migrate the healing/*_power/spell_power conditionals off Nampower's GetSpellPower to ClassicAPI GetSpellBonusDamage(school) / GetSpellBonusHealing. Both read the same client field, so the per-school damage values are identical while dropping the Nampower v2.31 gate. Fixes healing/healingpower: GetSpellPower returns no healing value, so they were returning the 2nd school (holy spell damage) as a stand-in for +healing. GetSpellBonusHealing returns the real (derived) +healing. Prune the now-unused Nampower GetSpellPower wrapper, feature-table entry, and feature flag.
This commit is contained in:
@@ -181,6 +181,22 @@ function API.GetSpellEffectMechanics(spellID)
|
||||
return nil
|
||||
end
|
||||
|
||||
-- Flat spell-damage bonus (spell power) for a magic school, as a number.
|
||||
-- school is 1-based: 1=Physical, 2=Holy, 3=Fire, 4=Nature, 5=Frost, 6=Shadow,
|
||||
-- 7=Arcane. Reads the same client field nampower's GetSpellPower does -- exact,
|
||||
-- with gear/enchants/buffs/talents/set bonuses baked in.
|
||||
function API.GetSpellBonusDamage(school)
|
||||
return GetSpellBonusDamage(school)
|
||||
end
|
||||
|
||||
-- Flat healing bonus (+healing), as a number. Vanilla has no healing-done field,
|
||||
-- so ClassicAPI derives it from gear/enchant/buff MOD_HEALING_DONE plus
|
||||
-- stat-conversion talents (e.g. Spiritual Guidance) -- exact, not a holy-damage
|
||||
-- proxy.
|
||||
function API.GetSpellBonusHealing()
|
||||
return GetSpellBonusHealing()
|
||||
end
|
||||
|
||||
--------------------------------------------------------------------------------
|
||||
-- State
|
||||
--------------------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user