performance updates

performance updates

modules/actionbar.lua

@@ -912,24 +912,40 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
   end
 
   local cat, stealth
-  local function IsCatStealth()
+  local inCatForm = nil  -- cached from buff scan
+  local prowlActive = nil  -- tracks if prowl is active
+  
+  -- Full scan for cat form and prowl (only on login/reload)
+  local function FullScan()
     if class ~= "DRUID" then return nil end
-    cat, stealth = nil, nil
-
+    
+    local foundCat, foundStealth = nil, nil
+    
     for i = 0, 31 do
       local texture = GetPlayerBuffTexture(i)
       if not texture then break end
 
-      -- catform icon detected
       if strfind(texture, "Ability_Druid_CatForm") then
-        if stealth then return true end
-        cat = true
+        foundCat = true
       end
 
-      -- stealth icon detected
       if strfind(texture, "Ability_Ambush") then
-        if cat then return true end
-        stealth = true
+        foundStealth = true
+      end
+    end
+    
+    inCatForm = foundCat
+    prowlActive = foundCat and foundStealth
+    return prowlActive
+  end
+  
+  -- Quick scan only for prowl (when we know we're in cat form)
+  local function HasProwlBuff()
+    for i = 0, 31 do
+      local texture = GetPlayerBuffTexture(i)
+      if not texture then break end
+      if strfind(texture, "Ability_Ambush") then
+        return true
       end
     end
     return nil
@@ -956,7 +972,59 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
     end
 
     -- setup page switch frame
+    local prowling = nil
     local pageswitch = CreateFrame("Frame", "pfActionBarPageSwitch", UIParent)
+    pageswitch:RegisterEvent("PLAYER_AURAS_CHANGED")
+    pageswitch:RegisterEvent("PLAYER_ENTERING_WORLD")
+    pageswitch:RegisterEvent("UNIT_CASTEVENT")
+    pageswitch:SetScript("OnEvent", function()
+      if class ~= "DRUID" then return end
+      
+      -- UNIT_CASTEVENT: detect Cat Form and Prowl cast instantly
+      -- Cat Form: 768 | Prowl: 5215 (R1), 6783 (R2), 9913 (R3)
+      if event == "UNIT_CASTEVENT" then
+        local guid, target, cEvent, spellId = arg1, arg2, arg3, arg4
+        local _, playerGuid = UnitExists("player")
+        if guid == playerGuid and cEvent == "CAST" then
+          if spellId == 5215 or spellId == 6783 or spellId == 9913 then
+            inCatForm = true
+            prowlActive = true
+            prowling = true
+          elseif spellId == 768 then
+            inCatForm = true
+          end
+        end
+        return
+      end
+      
+      -- PLAYER_AURAS_CHANGED: smart scanning
+      if event == "PLAYER_AURAS_CHANGED" then
+        if prowlActive then
+          -- We were prowling, check if still prowling
+          if HasProwlBuff() then
+            prowling = true
+          else
+            -- Prowl ended
+            prowlActive = nil
+            prowling = nil
+            -- Also check if still in cat form
+            inCatForm = nil
+            for i = 0, 31 do
+              local texture = GetPlayerBuffTexture(i)
+              if not texture then break end
+              if strfind(texture, "Ability_Druid_CatForm") then
+                inCatForm = true
+                break
+              end
+            end
+          end
+        elseif not inCatForm then
+          -- Not in cat form, do a full scan (might have just shifted)
+          prowling = FullScan()
+        end
+        -- If inCatForm but not prowlActive, no scan needed (wait for UNIT_CASTEVENT)
+      end
+    end)
     pageswitch:SetScript("OnUpdate", function()
       -- switch actionbar page depending on meta key that is pressed
       if C.bars.pagemastershift == "1" and IsShiftKeyDown() then
@@ -974,10 +1042,9 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
 
       -- switch actionbar page if druid stealth is detected
       if C.bars.druidstealth == "1" then
-        local stealth = IsCatStealth()
-        if stealth and _G.CURRENT_ACTIONBAR_PAGE == 1 then
+        if prowling and _G.CURRENT_ACTIONBAR_PAGE == 1 then
           SwitchBar(prowl)
-        elseif not stealth and _G.CURRENT_ACTIONBAR_PAGE == 8 then
+        elseif not prowling and _G.CURRENT_ACTIONBAR_PAGE == 8 then
           SwitchBar(default)
         end
       end