brues/pfUI
1
1
Fork 0
mirror of https://github.com/brues-code/pfUI.git synced 2026-10-19 19:10:49 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

actionbar: reduce memory load by caching locals

Browse Source
This commit is contained in:
shagu
2020-03-15 11:47:50 +01:00
parent f673726770
commit a0983863a3
1 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/actionbar.lua
+11 -12
View File
@@ -268,10 +268,10 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
end end
end end
local mouse
local function ButtonAnimate(self) local function ButtonAnimate(self)
local self = self or this local self = self or this
local mouse = arg1 and not keystate mouse = arg1 and not keystate
local keystate = keystate
-- trigger action animation -- trigger action animation
if ( pfUI_config.bars.keydown == "1" and keystate == "down" ) or (pfUI_config.bars.keydown == "0" and keystate == "up" ) or self.bar == 11 or mouse then if ( pfUI_config.bars.keydown == "1" and keystate == "down" ) or (pfUI_config.bars.keydown == "0" and keystate == "up" ) or self.bar == 11 or mouse then
@@ -358,11 +358,11 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
end end
local start, duration, enable, castable, autocast, token local start, duration, enable, castable, autocast, token
local id, bar, active, texture, _ local grid, sid, id, bar, active, texture, _
local function ButtonSlotUpdate(self) local function ButtonSlotUpdate(self)
if not self then return end if not self then return end
local self = self or this local self = self or this
local sid = self.id -- 1 to 120 sid = self.id -- 1 to 120
-- reset shared variables -- reset shared variables
castable, autocast, token = nil, nil, nil castable, autocast, token = nil, nil, nil
@@ -370,7 +370,7 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
-- set the own ID for compatibility to some vanilla addons -- set the own ID for compatibility to some vanilla addons
if pfUI.client <= 11200 then self:SetID(self.id) end if pfUI.client <= 11200 then self:SetID(self.id) end
local grid = self.bar == 12 and showgrid_pet or showgrid grid = self.bar == 12 and showgrid_pet or showgrid
if self.bar == 11 then if self.bar == 11 then
-- stance button -- stance button
@@ -483,11 +483,10 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
end end
end end
local sid, usable, oom, _
local function ButtonUsableUpdate(self) local function ButtonUsableUpdate(self)
local self = self or this local self = self or this
local sid = self.id -- 1 to 120 sid = self.id -- 1 to 120
local usable, oom, _
if self.bar == 11 then if self.bar == 11 then
_, _, _, usable = GetShapeshiftFormInfo(sid) _, _, _, usable = GetShapeshiftFormInfo(sid)
@@ -524,9 +523,9 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
end end
end end
local start, duration, enable
local function ButtonCooldownUpdate(button) local function ButtonCooldownUpdate(button)
if not button then return end if not button then return end
local start, duration, enable
if button.bar == 11 then if button.bar == 11 then
start, duration, enable = GetShapeshiftFormCooldown(button.id) start, duration, enable = GetShapeshiftFormCooldown(button.id)
@@ -539,9 +538,9 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
CooldownFrame_SetTimer(button.cd, start, duration, enable) CooldownFrame_SetTimer(button.cd, start, duration, enable)
end end
local _, active
local function ButtonIsActiveUpdate(button) local function ButtonIsActiveUpdate(button)
if not button then return end if not button then return end
local _, active
if button.bar == 11 then if button.bar == 11 then
_, _, active, _ = GetShapeshiftFormInfo(button.id) _, _, active, _ = GetShapeshiftFormInfo(button.id)
@@ -613,9 +612,9 @@ pfUI:RegisterModule("actionbar", "vanilla:tbc", function ()
end end
end end
local self, button
local function BarsUpdate(self) local function BarsUpdate(self)
local self = self or this self = self or this
local button
-- run cached usable usable actions -- run cached usable usable actions
if eventcache["ACTIONBAR_UPDATE_USABLE"] then if eventcache["ACTIONBAR_UPDATE_USABLE"] then