casts: route everything through C_Spell, drop libcast + libdebuff_casts

ClassicAPI's recent C_Spell additions cover remote-unit casts natively
(SMSG_SPELL_START co-hook caching per caster GUID), so the two parallel
cast trackers pfUI was running — libcast.lua and the libdebuff_casts
table inside libdebuff.lua — can both retire.

Migrations:
- modules/castbar.lua: focus/player cast-info gathering reads
  C_Spell.UnitCastingInfo / UnitChannelInfo directly. Fallback ladder
  (libdebuff_casts → pfGetCastInfo → pfGetChannelInfo) collapses into a
  single call. Pushback handlers stop writing back into a non-existent
  cache; the local this.endTime is the source of truth.
- modules/nameplates.lua: GetCastInfo(guid) now resolves to a unit token
  via UnitTokenFromGUID and queries C_Spell, returning the same compact
  struct shape downstream code expected. UpdateCastbar collapses from a
  three-branch hierarchy (dead IterDebuffs / libdebuff_casts / libcast)
  to one C_Spell read.
- modules/afkcam.lua: pfGetCastInfo+pfGetChannelInfo round-trip becomes
  a single C_Spell.UnitCastingInfo("player") or UnitChannelInfo fallback.
- libs/libpredict.lua: HealComm timing uses C_Spell on the sender's unit
  token after a small group-roster walk to resolve the sender's name.

Deletions:
- libs/libcast.lua entirely (-571 lines) plus its init/libs.xml entry.
- libdebuff_casts / libdebuff_item_icons tables and their write sites
  in libs/libdebuff.lua (the SPELL_START_*, SPELL_GO_*, SPELL_FAILED_*
  event handlers stop maintaining them but keep firing the
  libdebuff_*_hooks broadcast surface for actionbar / swingtimer /
  libtotem). SPELLCAST_CHANNEL_STOP now reads the active channel from
  C_Spell.ChannelInfo.
- modules/superwow.lua's supercast block — UNIT_CASTEVENT writes into
  libcast.db are redundant now that C_Spell co-hooks the same packet.
- The cast-bar item-icon override that swapped in a potion/trinket
  icon for item-triggered casts. Spell icon stays; the item-icon
  metadata path (libdebuff_item_icons) went with libdebuff_casts.

Steady Shot synthetic cast bar — Turtle WoW-specific:
- castbar.lua gains a pfUI.synthetic_casts[unit] fallback that fires
  only when C_Spell returns nil, so abilities the engine treats as
  instant but which have a meaningful wait window can still render a
  cast bar.
- modules/turtle-wow.lua replaces the old libcast.customcast block with
  a Nampower SPELL_QUEUE_EVENT subscriber. ON_SWING_QUEUED matching
  the localized "Steady Shot" name writes a 1.4s synthetic entry;
  ON_SWING_QUEUE_POPPED clears it; castbar's endMs guard self-expires
  the entry as a safety net. Note: haste scaling (libcast.ApplyShotHaste)
  is gone — bar may finish slightly early under +ranged haste buffs.

Net: 152 insertions, 972 deletions.
This commit is contained in:
Brues
2026-06-25 01:18:22 -05:00
parent d62a1222df
commit b79132b9f4
9 changed files with 152 additions and 972 deletions
+29 -88
View File
@@ -103,60 +103,37 @@ pfUI:RegisterModule("castbar", function ()
local query = this.unitstr ~= "" and this.unitstr or this.unitname
if not query then return end
-- Check if we have a GUID-based focus (Turtle WoW native GUID)
local focusGuid = nil
if this.unitstr and string.find(this.unitstr, "^0x") then
focusGuid = this.unitstr
elseif this.unitstr and this.unitstr == "player" and UnitGUID then
focusGuid = UnitGUID("player")
elseif this.unitstr and this.unitstr ~= "player" then
local guid = UnitGUID(this.unitstr)
if guid then focusGuid = guid end
-- C_Spell takes a unit token; ClassicAPI's resolver also accepts GUID
-- strings, so this.unitstr can be "player" / "target" / "focus" or a
-- raw "0x..." GUID transparently.
local cast, nameSubtext, texture, startTime, endTime
local name, _, tex, startMs, endMs, _, _, _, spellID = C_Spell.UnitCastingInfo(query)
local isChan
if not name then
name, _, tex, startMs, endMs, _, _, spellID = C_Spell.UnitChannelInfo(query)
isChan = true
end
this.focusGuid = focusGuid
-- Try libdebuff_casts first for GUID-based units (works with Turtle GUID + Nampower events)
local cast, nameSubtext, text, texture, startTime, endTime
local castBlocked = false
if focusGuid and pfUI.libdebuff_casts and pfUI.libdebuff_casts[focusGuid] then
local castData = pfUI.libdebuff_casts[focusGuid]
if castData.event == "CAST" or castData.event == "FAIL" then
castBlocked = true
pfUI.libdebuff_casts[focusGuid] = nil
elseif (castData.event == "START" or castData.event == "CHANNEL") and castData.endTime and castData.endTime > GetTime() then
cast = castData.spellName
texture = castData.icon
startTime = castData.startTime * 1000
endTime = castData.endTime * 1000
-- Try to get rank from spell DB via spellID (nameSubtext is not stored in libdebuff_casts)
if castData.spellID and GetSpellRecField then
nameSubtext = GetSpellRecField(castData.spellID, "rank") or ""
else
nameSubtext = ""
end
if castData.event == "CHANNEL" then
channel = cast
end
-- Synthetic fallback for abilities the engine treats as instant-cast but
-- that have a meaningful wait window (e.g. Turtle WoW Steady Shot on the
-- ranged-swing queue). Per-unit table populated by module-side hooks.
if not name and pfUI.synthetic_casts and pfUI.synthetic_casts[query] then
local s = pfUI.synthetic_casts[query]
if s.endMs > GetTime() * 1000 then
name, tex, startMs, endMs, spellID = s.name, s.icon, s.startMs, s.endMs, s.spellID
isChan = nil
end
end
local useLibcastForPlayer = this.unitstr == "player"
-- For player: use player name to query libcast.db directly
if not cast and useLibcastForPlayer then
query = UnitName("player")
end
-- Fallback: pfGetCastInfo only when no focusGuid (Nampower not available for this unit).
-- If we have a focusGuid, libdebuff is authoritative - don't fall back to libcast
-- even if no cast is active (prevents false positives e.g. spellbook clicks on CD spells).
if not cast and not castBlocked and not focusGuid and pfGetCastInfo then
cast, nameSubtext, text, texture, startTime, endTime, isTradeSkill = pfGetCastInfo(query)
end
if not cast and not castBlocked and not focusGuid and pfGetChannelInfo then
channel, nameSubtext, text, texture, startTime, endTime, isTradeSkill = pfGetChannelInfo(this.unitstr or this.unitname)
cast = channel
if name and startMs and endMs then
cast = name
texture = tex
startTime = startMs
endTime = endMs
if spellID and GetSpellRecField then
nameSubtext = GetSpellRecField(spellID, "rank") or ""
else
nameSubtext = ""
end
if isChan then channel = cast end
end
if cast then
@@ -181,35 +158,8 @@ pfUI:RegisterModule("castbar", function ()
this.icon:Show()
this.icon:SetHeight(size)
this.icon:SetWidth(size)
-- Override with item icon from libdebuff_casts or persistent item icon cache
local useTexture = texture
local useItemName = nil
if pfUI.libdebuff_casts or pfUI.libdebuff_item_icons then
local castGuid = nil
if this.unitstr and UnitExists then
local guid = UnitGUID(this.unitstr)
castGuid = guid
end
if castGuid then
-- First check active cast data
if pfUI.libdebuff_casts and pfUI.libdebuff_casts[castGuid] and pfUI.libdebuff_casts[castGuid].itemID then
useTexture = pfUI.libdebuff_casts[castGuid].icon or texture
-- Fallback to persistent item icon cache
elseif pfUI.libdebuff_item_icons and pfUI.libdebuff_item_icons[castGuid] then
useTexture = pfUI.libdebuff_item_icons[castGuid].icon or texture
useItemName = pfUI.libdebuff_item_icons[castGuid].name
end
end
end
this.icon.texture:SetTexture(useTexture)
this.icon.texture:SetTexture(texture)
this.bar:SetPoint("TOPLEFT", this.icon, "TOPRIGHT", this.spacing, 0)
-- Override spell name with item name for item-triggered casts
if useItemName and this.showname then
this.bar.left:SetText(useItemName .. " " .. rank)
end
else
this.bar:SetPoint("TOPLEFT", this, 0, 0)
this.icon:Hide()
@@ -255,7 +205,6 @@ pfUI:RegisterModule("castbar", function ()
this.lastMax = nil
this.fadeout = 1
this.delay = 0
this.itemIconApplied = nil
end
end)
@@ -267,10 +216,6 @@ pfUI:RegisterModule("castbar", function ()
if not delayMs or delayMs <= 0 or not this.endTime then return end
this.delay = (this.delay or 0) + delayMs / 1000
this.endTime = this.endTime + delayMs
local focusGuid = this.focusGuid
if focusGuid and pfUI.libdebuff_casts and pfUI.libdebuff_casts[focusGuid] then
pfUI.libdebuff_casts[focusGuid].endTime = this.endTime / 1000
end
end
cb:RegisterEvent("SPELL_DELAYED_SELF")
@@ -299,10 +244,6 @@ pfUI:RegisterModule("castbar", function ()
if diff > 50 then
this.delay = (this.delay or 0) + diff / 1000
this.endTime = newEndTime
local focusGuid = this.focusGuid
if focusGuid and pfUI.libdebuff_casts and pfUI.libdebuff_casts[focusGuid] then
pfUI.libdebuff_casts[focusGuid].endTime = newEndTime / 1000
end
end
elseif event == CASTBAR_EVENT_CAST_START or event == CASTBAR_EVENT_CHANNEL_START then