brues/pfUI
1
1
Fork 0
mirror of https://github.com/brues-code/pfUI.git synced 2026-09-29 18:56:02 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

fix: swing timer reset bugs (extra attacks, parry, slam)

Browse Source 
Extra attacks (Sword Specialization, Windfury, Hand of Justice) no longer double the swing timer. Added fallback detection for servers that don't set HITINFO_NOACTION correctly: if AUTO_ATTACK_SELF fires while more than 20% of the current swing remains, it's treated as an extra attack and ignored.
Parry reset now uses correct Vanilla mechanic: resets timer to exactly 60% of weapon speed instead of incorrectly subtracting 40% from remaining time.
Slam now hard-resets the swing timer from now instead of chaining from the previous nextSwing, which caused inflated swing times (e.g. 3.76s showing as 4.3s).
This commit is contained in:
Meow
2026-03-04 00:13:37 +01:00
parent fd79a7e776
commit c9468e4033
1 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modules/swingtimer.lua
+18 -1
View File
@@ -545,8 +545,25 @@ pfUI:RegisterModule("swingtimer", "vanilla:tbc", function ()
local hitInfo = arg4 or 0
local isOffhand = bit.band(hitInfo, HITINFO_LEFTSWING) ~= 0
local noAction = bit.band(hitInfo, HITINFO_NOACTION) ~= 0
-- HITINFO_NOACTION: server did not advance the swing clock, ignore
-- HITINFO_NOACTION: server did not advance the swing clock (extra attack), ignore
if noAction then return end
-- Fallback extra attack detection: some servers (e.g. Turtle WoW) do not set
-- HITINFO_NOACTION for extra attacks (Sword Specialization, Windfury, Hand of Justice).
-- An extra attack fires a second AUTO_ATTACK_SELF while the current swing timer is
-- still running with significant time remaining. In that case, the swing clock was
-- NOT reset by the server, so we must not reset our timer either.
local now = GetTime()
if not isOffhand and swingState.mainhand.swinging then
local remaining = swingState.mainhand.nextSwing - now
-- If more than 20% of swing speed remains, this is an extra attack, not a real swing
if remaining > swingState.mainhand.speed * 0.2 then return end
end
if isOffhand and swingState.offhand.swinging then
local remaining = swingState.offhand.nextSwing - now
if remaining > swingState.offhand.speed * 0.2 then return end
end
StartSwing(isOffhand)
elseif event == "AUTO_ATTACK_OTHER" then