From d498d061f831030594c90ad67889a767183c4ff4 Mon Sep 17 00:00:00 2001
From: shagu <ericmauser@googlemail.com>
Date: Sun, 17 Feb 2019 16:20:03 +0100
Subject: [PATCH] actionbar: cache reagent counter textures

---
 modules/actionbar.lua | 32 ++++++++++++++++++++------------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/modules/actionbar.lua b/modules/actionbar.lua
index d6df3817..afc9894e 100644
--- a/modules/actionbar.lua
+++ b/modules/actionbar.lua
@@ -984,6 +984,7 @@ pfUI:RegisterModule("actionbar", function ()
   -- reagent counter
   local reagent_slots = { }
   local reagent_counts = { }
+  local reagent_textureslots = { }
   local reagent_capture = SPELL_REAGENTS.."(.+)"
   local scanner = libtipscan:GetScanner("actionbar")
   local reagentcounter = CreateFrame("Frame", "pfReagentCounter", UIParent)
@@ -995,20 +996,27 @@ pfUI:RegisterModule("actionbar", function ()
       this.event = true
     else
       for slot = 1, 120 do
-        -- clear cached reagent slots on SLOT_CHANGED
-        local hadslot = reagent_slots[slot]
-        reagent_slots[slot] = nil
-        if HasAction(slot) then
-          scanner:SetAction(slot)
-          local _, reagents = scanner:Find(reagent_capture)
-          if reagents then
-            reagent_slots[slot] = reagents
-            reagent_counts[reagents] = reagent_counts[reagents] or 0
-          end
+        local texture = GetActionTexture(slot)
+
+        -- update buttons that previously had an reagent
+        if reagent_slots[slot] and not texture then
+          reagent_textureslots[slot] = nil
+          reagent_slots[slot] = nil
+          RefreshSlot(slot)
         end
 
-        if reagent_slots[slot] or hadslot then
-          RefreshSlot(slot)
+        -- search for reagents on buttons with different icon
+        if reagent_textureslots[slot] ~= texture then
+          if HasAction(slot) then
+            reagent_textureslots[slot] = texture
+            scanner:SetAction(slot)
+            local _, reagents = scanner:Find(reagent_capture)
+            if reagents then
+              reagent_slots[slot] = reagents
+              reagent_counts[reagents] = reagent_counts[reagents] or 0
+              RefreshSlot(slot)
+            end
+          end
         end
       end
     end