brues/pfUI
1
1
Fork 0
mirror of https://github.com/brues-code/pfUI.git synced 2026-09-28 18:36:01 +00:00
Code Issues 1 Packages Projects Releases Wiki Activity

classicapi: two-tier version check + drop hardcoded github URLs

Browse Source 
Splits the ClassicAPI version check into a hard floor (MIN, manual)
and a soft target (LATEST, pinned by the release workflow). Below MIN
pfUI disables itself entirely as before; between MIN and LATEST it
runs normally but fires a delayed chat nudge after PLAYER_LOGIN with
the available update. PLAYER_LOGIN handlers swap to
EventUtil.ContinueOnPlayerLogin so we don't have to spin a frame for
each branch.

URLs centralize on toc X-Website fields. pfUI.lua factors out
ClassicAPIReleaseUrl(version) sourcing from !!!ClassicAPI's metadata;
modules/gui.lua and libs/libdebuff.lua replace hardcoded
me0wg4ming/pfUI links with GetAddOnMetadata(pfUI.name, "X-Website")
lookups.

release.yml gains a pre-package step that queries ClassicAPI's latest
release tag, packs it (X*10000 + Y*100 + Z), and seds only the LATEST
line in pfUI.lua so the published zip ships with the correct soft
target.
This commit is contained in:
Brues
2026-06-22 15:06:04 -05:00
parent 28ce916cc3
commit ff98dde670
4 changed files with 46 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pfUI.lua
+30 -6
View File
@@ -26,20 +26,29 @@ pfUI.bootup = true
-- ClassicAPI dependency check.
-- pfUI relies pervasively on the modern C_* / SuperWoW / nameplate / focus
-- API surface that ClassicAPI polyfills, so presence is required.
local PFUI_CLASSIC_API_MIN = 10403 -- (X*10000 + Y*100 + Z)
--
-- MIN is the hard floor — bumped manually when pfUI starts using a new
-- ClassicAPI feature. Below this, pfUI disables itself entirely.
-- LATEST is the soft target — replaced by the release workflow with whatever
-- ClassicAPI release was current at build time. Between MIN and LATEST,
-- pfUI runs normally but nudges the user to update.
local PFUI_CLASSIC_API_MIN = 10403 -- (X*10000 + Y*100 + Z)
local PFUI_CLASSIC_API_LATEST = 99999999
local function FormatVersion(packed)
local x = math.floor(packed / 10000)
local y = math.floor(math.mod(packed, 10000) / 100)
local z = math.mod(packed, 100)
return string.format("v%d.%d.%d", x, y, z)
end
local function ClassicAPIReleaseUrl(version)
return GetAddOnMetadata("!!!ClassicAPI", "X-Website") .. "/releases/tag/" .. version
end
if not CLASSIC_API_VERSION or CLASSIC_API_VERSION < PFUI_CLASSIC_API_MIN then
pfUI.disabled = true
local minVersion = FormatVersion(PFUI_CLASSIC_API_MIN)
local alertFrame = CreateFrame("Frame")
alertFrame:RegisterEvent("PLAYER_LOGIN")
alertFrame:SetScript("OnEvent", function()
EventUtil.ContinueOnPlayerLogin(function()
StaticPopupDialogs["PFUI_CLASSICAPI_REQUIRED"] = {
text = "This fork of |cff33ffccpf|cffffffffUI|r requires ClassicAPI\n " .. minVersion .. " or newer.\n\nAll |cff33ffccpf|cffffffffUI|r modules have been disabled.\nInstall ClassicAPI from:",
button1 = OKAY,
@@ -52,7 +61,7 @@ if not CLASSIC_API_VERSION or CLASSIC_API_VERSION < PFUI_CLASSIC_API_MIN then
OnShow = function()
local editBox = _G[this:GetName().."EditBox"]
if editBox then
editBox:SetText("https://github.com/brues-code/ClassicAPI/releases/tag/" .. minVersion)
editBox:SetText(ClassicAPIReleaseUrl(minVersion))
editBox:HighlightText()
editBox:SetFocus()
end
@@ -61,11 +70,26 @@ if not CLASSIC_API_VERSION or CLASSIC_API_VERSION < PFUI_CLASSIC_API_MIN then
StaticPopup_Show("PFUI_CLASSICAPI_REQUIRED")
if DEFAULT_CHAT_FRAME then
DEFAULT_CHAT_FRAME:AddMessage(
"This fork of pfUI requires ClassicAPI " .. minVersion .. "+. Get it at https://github.com/brues-code/ClassicAPI/releases/tag/" .. minVersion,
"This fork of pfUI requires ClassicAPI " .. minVersion .. "+. Get it at " .. ClassicAPIReleaseUrl(minVersion),
1, 0.3, 0.3
)
end
end)
elseif CLASSIC_API_VERSION < PFUI_CLASSIC_API_LATEST then
-- Above MIN but below the release-pinned LATEST — soft nudge in chat,
-- delayed so it lands after the login welcome spam instead of getting
-- buried.
local latestVersion = FormatVersion(PFUI_CLASSIC_API_LATEST)
EventUtil.ContinueOnPlayerLogin(function()
C_Timer.After(8, function()
if DEFAULT_CHAT_FRAME then
DEFAULT_CHAT_FRAME:AddMessage(
"|cff33ffccpf|rUI: ClassicAPI " .. latestVersion .. " is available — " .. ClassicAPIReleaseUrl(latestVersion),
1, 0.85, 0.3
)
end
end)
end)
end
-- initialize saved variables