mirror of
https://github.com/brues-code/pfUI.git
synced 2026-09-22 15:46:56 +00:00
Brues
62a99ac410
With Nampower as a hard dep, /pfcast for spell names always takes the early CastSpellByName(msg, unit) path. The fallback branch that did the SpellTargetUnit dance (resolve a friendly unit token, disable AutoSelf Cast, call SpellTargetUnit) hasn't been reachable in a while, and it dragged a pile of supporting infrastructure with it. modules/mouseover.lua: - Drop the st_units token list, GetUnitString helper, and the UnitTokenFromGUID rewrite of GetUnitString — all only used by the dead fallback. - Drop the NoSelfCast helper (only the dead fallback called it). - Drop the pfMouseOver frame; its only purpose was to hold a .unit field the dead fallback wrote and libpredict's hook read. - The macro path collapses to: if not the current target, swap target, run the loadstring'd func, restore the previous target. - 99 lines → 34. libs/libpredict.lua: - Drop the dead `local mouseover = pfUI.uf.mouseover.unit` plumbing in the CastSpellByName hook — pfUI.uf.mouseover is gone and the field was permanently nil anyway. The three `target or mouseover or default` fallback chains collapse to `target or default`. Modern mouseover/click-to-cast detection in libpredict goes through pfUI.libpredict_pending_cast (populated by libdebuff from Nampower's SPELL_CAST_EVENT) — that path is GUID-based, server-authoritative, and untouched.
34 lines
1.0 KiB
Lua
34 lines
1.0 KiB
Lua
pfUI:RegisterModule("mouseover", function ()
|
|
_G.SLASH_PFCAST1, _G.SLASH_PFCAST2 = "/pfcast", "/pfmouse"
|
|
function SlashCmdList.PFCAST(msg)
|
|
local func = pfUI.api.TryMemoizedFuncLoadstringForSpellCasts(msg)
|
|
local unit = "mouseover"
|
|
|
|
if not UnitExists(unit) then
|
|
local frame = GetMouseFocus()
|
|
if frame.label and frame.id then
|
|
unit = frame.label .. frame.id
|
|
elseif UnitExists("target") then
|
|
unit = "target"
|
|
elseif GetCVar("autoSelfCast") == "1" then
|
|
unit = "player"
|
|
else
|
|
return
|
|
end
|
|
end
|
|
|
|
-- Spell-name path: Nampower's CastSpellByName takes a second unit
|
|
-- parameter directly, no target swap dance required.
|
|
if not func then
|
|
CastSpellByName(msg, unit)
|
|
return
|
|
end
|
|
|
|
-- Macro path: switch target so the macro's spell calls land on `unit`,
|
|
-- then restore.
|
|
local restore_target = not UnitIsUnit("target", unit)
|
|
if restore_target then TargetUnit(unit) end
|
|
func()
|
|
if restore_target then TargetLastTarget() end
|
|
end
|
|
end) |