contributing: what happens to a pull request after it is opened (#404)
A maintainer reviews it against the reference and usually finishes it on the contributor's branch (a rebase, a fix, a test, a comment) rather than sending it back, so "Allow edits by maintainers" stays ticked; it lands as one squash-merged commit with the contributor as its author, or, when what lands would be mostly ours, as our own commit crediting them as co-author. Docs only; no gate reads it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
committed by
GitHub
co-authored by
Claude Opus 5.5
parent
8d5e43c33f
commit
11e185fc09
@@ -35,6 +35,15 @@ fork, and forks are welcome.
|
||||
No history.
|
||||
4. The commit message says what changed, for a player or a developer, in one line.
|
||||
|
||||
## After you open it
|
||||
|
||||
A maintainer reads it, checks it against the reference and runs it. Most pull requests are
|
||||
finished here rather than sent back: a rebase onto main, a fix, a test or a comment, pushed to
|
||||
your branch as commits on top of yours, so leave "Allow edits by maintainers" ticked. It lands as
|
||||
one squash-merged commit with you as its author. When what would land is mostly ours, we land our
|
||||
own version with you as a co-author and close yours with a note. One that is out of scope is
|
||||
closed with the reason.
|
||||
|
||||
## Setting up
|
||||
|
||||
- **The toolchain.** Stable Rust (`rust-toolchain.toml` adds clippy and rustfmt) and a C
|
||||
|
||||
Reference in New Issue
Block a user