From 3a0882d4d04022d2dedd7b3129a60624a53a6e35 Mon Sep 17 00:00:00 2001 From: grom Date: Sat, 31 Oct 2026 16:03:01 -0600 Subject: [PATCH] The realm's group-finder keybinding, which arrived with today's update MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `Bindings.xml:637-639` declares `TOGGLEGROUPFINDER`, `GlobalStrings.lua:442` labels it "Toggle Group Finder", and its body is a plain call into the realm's own group finder (`LFT_Toggle`, `LFT\LFT.lua:1097`) which `benilla.toc` already loads — so there was nothing engine-side to build, only the row to carry. Unbound by default, because the realm ships no default key for it. That is 229 live bindings where stock 1.12.1 has 228, and both halves of the binding gate now say so. It is also the one thing the realm-update checklist missed this morning: I counted toc rows, FrameXML digests, DBC shapes and census results, and never counted `Bindings.xml` rows. Worth a line on that checklist. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn --- crates/benilla-app/src/bindings/commands.rs | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/crates/benilla-app/src/bindings/commands.rs b/crates/benilla-app/src/bindings/commands.rs index 76c2459b..2a940778 100644 --- a/crates/benilla-app/src/bindings/commands.rs +++ b/crates/benilla-app/src/bindings/commands.rs @@ -1004,6 +1004,18 @@ const TABLE: &[Spec] = &[ Some("SHIFT-M"), None ), + // The realm's own, arrived with the 2026-10-31 client update: `Bindings.xml:637-639` declares + // it and `GlobalStrings.lua:442` labels it "Toggle Group Finder". Its body is a plain call + // into the realm's group finder (`LFT_Toggle`, `LFT\LFT.lua:1097`), which `benilla.toc` + // already loads, so there is nothing engine-side to build — only the row to carry. No default + // key: the realm ships none, so it is unbound until the player binds it. + spec!( + "TOGGLEGROUPFINDER", + INTERFACE, + Kind::Edge("LFT_Toggle()"), + None, + None + ), // ── Miscellaneous (BINDING_HEADER_MISC) ───────────────────────────────────────────── spec!( "MINIMAPZOOMIN", @@ -2073,8 +2085,10 @@ mod tests { }; assert_eq!( binds.len(), - 228, - "1.12.1 ships 228 live bindings — the other six are inside a comment" + 229, + "stock 1.12.1 ships 228 live bindings (the other six are inside a comment); the realm \ + adds `TOGGLEGROUPFINDER` for its group finder, which arrived with the 2026-10-31 \ + client update" ); assert!(binds.iter().all(|b| !b.name.is_empty())); assert!(