From 41f46087e2b1dd0fef232540130e047170f40907 Mon Sep 17 00:00:00 2001 From: pkuzic Date: Fri, 25 Sep 2026 14:04:54 +0100 Subject: [PATCH] MONKEY (ao): AO options test writes High first (default is Off); reframe ao-character Co-Authored-By: Claude Opus 5.5 --- crates/benilla-app/src/capture/scenarios.rs | 2 +- crates/benilla-app/src/ui_script/options_tests.rs | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/benilla-app/src/capture/scenarios.rs b/crates/benilla-app/src/capture/scenarios.rs index ac3ed6a7..fb8a5160 100644 --- a/crates/benilla-app/src/capture/scenarios.rs +++ b/crates/benilla-app/src/capture/scenarios.rs @@ -1391,7 +1391,7 @@ pub(super) const ON_DEMAND: &[Scenario] = &[ }, Scenario { name: "ao-character", map: Some(MAP_AZEROTH), - eye: [-9497.6, 57.6, 57.6], look: [-9500.00, 56.00, 56.9], minute: 720, + eye: [-9495.2, 60.8, 59.0], look: [-9500.00, 56.00, 56.9], minute: 720, ui: Some(UiFixture::Subject { kind: SubjectKind::Creature, at: SUBJECT_SUN }), }, ]; diff --git a/crates/benilla-app/src/ui_script/options_tests.rs b/crates/benilla-app/src/ui_script/options_tests.rs index dd9d5278..a4a8065f 100644 --- a/crates/benilla-app/src/ui_script/options_tests.rs +++ b/crates/benilla-app/src/ui_script/options_tests.rs @@ -2081,7 +2081,8 @@ fn ambient_occlusion_dropdown_is_localised_and_live() { s.run(on_load).unwrap(); assert_eq!(s.eval::("return self.title").unwrap(), title); assert!(s.eval::("return getglobal(self.tip) == BENILLA_ADVGFX.tips.AMBIENT_OCCLUSION and string.len(getglobal(self.tip)) > 80").unwrap()); - for (tier, label) in labels.iter().enumerate() { + // High first: the registered default is Off, and rewriting the same value is no change. + for (tier, label) in labels.iter().enumerate().rev() { assert_eq!(s.eval::(&format!("return self.choices[{}].text", tier + 1)).unwrap(), *label); let _ = s.take_cvar_changes(); s.run(&format!("SetCVar(self.cvar, self.choices[{}].value)", tier + 1)).unwrap();