GetAuctionItemInfo names the bidder on the player's own owner-list auctions, nil until the name lands, and 1 or nil on every other row (#259) (#492)

The auction house's Auctions tab now names the high bidder on each of your auctions, and shows "No Bids" only for an auction with none, as in 1.12.1; before, every auction read "No Bids".

`GetAuctionItemInfo`'s eleventh value follows `0x4cee40`: on the owner list, for a row the player owns (`0x4cf12a`-`0x4cf142`), it is the bidder's name from the name cache (`0x4cf144`-`0x4cf174`), nil with no bid (`0x4cf150`) or while the name has not arrived; on every other row it is 1 when the player holds the bid, else nil (`0x4cf17b`-`0x4cf1a0`). A bidder name that arrives later refreshes the list with `AUCTION_OWNED_LIST_UPDATE`, the event the reference's callback `0x4cf2b0` fires. vmangos sends the bidder guid with each row (`AuctionHouseMgr.cpp:840`).

Fixes #259

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

crates/benilla-ui/src/script/auction.rs

@@ -59,8 +59,8 @@ pub struct AuctionItemRow {
     pub buyout_price: u32,
     /// The current high bid; 0 before any bid.
     pub bid_amount: u32,
-    /// Whether the player holds the high bid: a flag, not a name.
-    pub high_bidder: bool,
+    /// `GetAuctionItemInfo`'s eleventh value, which the app picks per list and row.
+    pub high_bidder: AuctionHighBidder,
     /// The seller's name; `None` while the name query is in flight.
     pub owner: Option<String>,
     /// The time-left bucket, `1..=4` (Short, Medium, Long, Very Long); 0 when not known yet.
@@ -69,6 +69,20 @@ pub struct AuctionItemRow {
     pub link: Option<String>,
 }
 
+/// `GetAuctionItemInfo`'s `highBidder` (`0x4cf12a`–`0x4cf1a0`): on an `"owner"` row the player
+/// owns, the bidder's name from the name cache; on any other row, `1` when the player holds the
+/// bid. Nil otherwise, which the stock Auctions tab prints as `NO_BIDS`.
+#[derive(Clone, Debug, Default, PartialEq)]
+pub enum AuctionHighBidder {
+    /// No bid, another player's bid on a row the player does not own, or a name not arrived.
+    #[default]
+    Nil,
+    /// The player holds the bid on a row it does not own: `1`.
+    Player,
+    /// The bidder on the player's own auction, by name.
+    Name(String),
+}
+
 /// One of the three lists: the batch the server sent, the pre-cap match count and its sort stack.
 #[derive(Clone, Debug, Default, PartialEq)]
 pub struct AuctionListState {
@@ -303,7 +317,7 @@ pub(super) fn install(lua: &Lua) -> mlua::Result<()> {
         })?,
     )?;
 
-    // GetAuctionItemInfo(type, index) → twelve values; `highBidder` is a flag, not the seller.
+    // GetAuctionItemInfo(type, index) → twelve values; `highBidder` is a name, `1` or nil.
     g.set(
         "GetAuctionItemInfo",
         lua.create_function(|lua, (kind, index): (String, usize)| {
@@ -354,7 +368,11 @@ pub(super) fn install(lua: &Lua) -> mlua::Result<()> {
                 Value::Integer(i64::from(r.min_increment)),
                 Value::Integer(i64::from(r.buyout_price)),
                 Value::Integer(i64::from(r.bid_amount)),
-                flag(r.high_bidder),
+                match &r.high_bidder {
+                    AuctionHighBidder::Nil => Value::Nil,
+                    AuctionHighBidder::Player => flag(true),
+                    AuctionHighBidder::Name(n) => Value::String(lua.create_string(n)?),
+                },
                 opt_str(&r.owner)?,
             ]))
         })?,
@@ -918,6 +936,30 @@ mod tests {
         assert_eq!(n, 0, "zero values, not one nil");
     }
 
+    /// The eleventh value is the name, `1` or nil as the app picked it (`0x4cf12a`–`0x4cf1a0`).
+    #[test]
+    fn high_bidder_answers_a_name_a_one_or_nil() {
+        let mut s = UiScript::new().unwrap();
+        let mut state = page(&[1, 2, 3]);
+        state.lists[LIST].rows[0].high_bidder = AuctionHighBidder::Name("Bidder".into());
+        state.lists[LIST].rows[1].high_bidder = AuctionHighBidder::Player;
+        s.set_auction(Some(state));
+        let eleventh = |i: usize| {
+            s.eval::<Value>(&format!(
+                r#"local _,_,_,_,_,_,_,_,_,_,h = GetAuctionItemInfo("list", {i}) return h"#
+            ))
+            .unwrap()
+        };
+        assert_eq!(
+            eleventh(1)
+                .as_string()
+                .map(|v| v.to_str().unwrap().to_string()),
+            Some("Bidder".into())
+        );
+        assert_eq!(eleventh(2), Value::Integer(1));
+        assert_eq!(eleventh(3), Value::Nil);
+    }
+
     /// A 9-copper stack at 5% over 24 h deposits 0 here, where vmangos charges 5.
     #[test]
     fn the_deposit_is_the_clients_arithmetic_truncation_and_all() {

crates/benilla-ui/src/script/mod.rs

@@ -144,7 +144,7 @@ pub use addon::AddOnInfo;
 pub use addon_enable::EnableHash;
 pub use addon_message::{AddonDistribution, AddonSend};
 pub use auction::{
-    AuctionBid, AuctionCategory, AuctionItemRow, AuctionListState, AuctionQuery,
+    AuctionBid, AuctionCategory, AuctionHighBidder, AuctionItemRow, AuctionListState, AuctionQuery,
     AuctionStartRequest, AuctionState, AuctionSubCategory, BIDDER, LIST, OWNER, SORT_KEYS,
 };
 pub use aura::{AuraState, TrackingState};