vmangos citations read in one revision, vmangos core 6b34a36 (#289)
Fixes #32. Every vmangos `File.cpp:N` citation in the crates whose comments have been rewritten now reads in one revision, vmangos core `6b34a36`, the one the comments are written against, a few commits from the server benilla is run against. Some citations had been taken from a newer vmangos checkout, where the lines have moved. #32's own targets came from that newer checkout too, so where this PR and #32 differ, this PR follows `6b34a36`. - 53 citations in 31 files are re-pointed: most in benilla-protocol, a few in benilla-ui and benilla-app. Each new line was read and is the construct its comment names. - #32's cases: - The root-ack kick is `MovementHandler.cpp:715-722`; three comments cited the falling deferral after it. - Movement is discarded before `CMSG_SET_ACTIVE_MOVER` lands at `:291-293`, through `Player::GetConfirmedMover`. - The released mover's parting stop is `:955-964`. - The mount-special echo is sent with `self` false at `:972`. Whether the sender gets its own echo depends on the server's broadcaster (`Object.cpp:2273-2280`); that is stated once, where the packet is parsed, and the opcode comment points there. - Ten more citations were a line or two off in every revision. One comment also stated a wrong fact: vmangos's ignoring-you party refusal names the invitee, and the empty name is the raid-convert confirmation's. - Comment text only. Every file strips to identical code, and `cargo fmt --check` is clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
committed by
GitHub
co-authored by
Claude Opus 5.5
parent
d9359a2d16
commit
4ecc33c019
@@ -374,7 +374,7 @@ pub(in crate::script) fn install(lua: &Lua) -> mlua::Result<()> {
|
||||
})?,
|
||||
)?;
|
||||
// UnitIsPlusMob(unit) (`0x516d40`): `UNIT_FIELD_FLAGS` bit 0x40, never the creature rank
|
||||
// (`0x605620`). The server sets it for a non-pet above normal rank (`Creature.cpp:634`), so a
|
||||
// (`0x605620`). The server sets it for a non-pet above normal rank (`Creature.cpp:637`), so a
|
||||
// rare answers 1, and an uncached creature still answers from its flags.
|
||||
g.set(
|
||||
"UnitIsPlusMob",
|
||||
|
||||
@@ -861,7 +861,7 @@ fn unit_is_plus_mob_reads_the_flag_bit_and_not_the_rank() {
|
||||
let mut s = UiScript::new().unwrap();
|
||||
s.set_unit("player", Some(player()));
|
||||
|
||||
// The server sets the bit on `!IsPet() && rank > 0` (`Creature.h:185`), so rare carries it.
|
||||
// The server sets the bit on `!IsPet() && rank > 0` (`Creature.h:186`), so rare carries it.
|
||||
for (rank, word) in [
|
||||
(1u32, "elite"),
|
||||
(2, "rareelite"),
|
||||
|
||||
Reference in New Issue
Block a user