diff --git a/crates/benilla-assets/src/materials.rs b/crates/benilla-assets/src/materials.rs index 421def70..14aef4ff 100644 --- a/crates/benilla-assets/src/materials.rs +++ b/crates/benilla-assets/src/materials.rs @@ -445,7 +445,7 @@ mod tests { assert!( !src.contains("@builtin(frag_depth)"), "the model lane writes a fragment depth again — the sky pin is the vertex stage's, \ - and a fragment write costs every draw on this lane its early-Z (decision 2016)" + and a fragment write costs every draw on this lane its early-Z" ); } @@ -457,21 +457,21 @@ mod tests { // The row accumulator `c0 + floor(i*(c1 - c0)/64)`, not a lerp to the deep endpoint. assert!( src.contains("let row = c0 + floor(i * (c1 - c0) / 64.0);"), - "the swatch stopped building its rows the way FUN_0068a830 does — a plain lerp to the \ - deep endpoint runs a 64th of a ramp that does not exist (decision 2074)" + "the swatch stopped building its rows the way `0x68a830` does: a plain lerp to the \ + deep endpoint runs a 64th of a ramp that does not exist" ); // The ocean-only tail: floor(0.9*byte) on the last row, alpha forced opaque. assert!( src.contains("if ocean && i >= 63.0 {") && src.contains("vec4(floor(row.rgb * 0.9), 255.0)"), "the ocean's last-row darkening is gone — ~80% of the world's ocean vertices sample \ - that row, so this is the open sea's colour (decision 2074)" + that row, so this is the open sea's colour" ); // Linear sampling across the two rows V falls between, at texel `V*64 - 0.5`. assert!( src.contains("let t = clamp(v * 64.0 - 0.5, 0.0, 63.0);"), "the swatch stopped sampling as an 8x64 LINEAR/CLAMP texture — the ocean darkening \ - would step instead of ramping across the final 1/64 of V (decision 2074)" + would step instead of ramping across the final 1/64 of V" ); /// `row(i)` for one channel, `swatch_row`'s byte arithmetic. diff --git a/crates/benilla-blp/src/lib.rs b/crates/benilla-blp/src/lib.rs index 450342a0..5c567df6 100644 --- a/crates/benilla-blp/src/lib.rs +++ b/crates/benilla-blp/src/lib.rs @@ -603,7 +603,7 @@ mod tests { ); assert!( tail.bytes[short as usize..].iter().any(|&x| x != 0), - "nothing was zero-filled — that was B358's black" + "nothing is zero-filled, which would draw black" ); // `decode` reads the same span. let decoded = decode(&b).unwrap(); diff --git a/crates/benilla-formats/src/terrain.rs b/crates/benilla-formats/src/terrain.rs index d333096d..a1666af4 100644 --- a/crates/benilla-formats/src/terrain.rs +++ b/crates/benilla-formats/src/terrain.rs @@ -750,7 +750,7 @@ mod tests { /// The reference stops a mover 1.46 yd east of `.go xyz -6601.98 -531.87 335.60 0`: the MCNK /// there is flagged [`benilla_adt::MCNK_IMPASSABLE`] and the pin's own is not. #[test] - fn the_b129_pin_stands_one_chunk_west_of_an_impassable_band() { + fn the_pin_stands_one_chunk_west_of_an_impassable_band() { let data = crate::wow_data_or_skip!(); let mut chain = crate::open_chain(&data).expect("open chain"); diff --git a/crates/benilla-protocol/examples/version_check_probe.rs b/crates/benilla-protocol/examples/version_check_probe.rs index 0300f38b..f157c884 100644 --- a/crates/benilla-protocol/examples/version_check_probe.rs +++ b/crates/benilla-protocol/examples/version_check_probe.rs @@ -33,8 +33,8 @@ enum Arm { impl Arm { fn label(self) -> &'static str { match self { - Arm::Zeros => "zeros (pre-1263)", - Arm::Computed => "computed (1263) ", + Arm::Zeros => "zeros ", + Arm::Computed => "computed", } } } diff --git a/crates/benilla-protocol/src/bin/benilla-world/probes/quest_item.rs b/crates/benilla-protocol/src/bin/benilla-world/probes/quest_item.rs index 324c6683..0a5861be 100644 --- a/crates/benilla-protocol/src/bin/benilla-world/probes/quest_item.rs +++ b/crates/benilla-protocol/src/bin/benilla-world/probes/quest_item.rs @@ -178,7 +178,7 @@ impl Probe for QuestItem { )?; anyhow::ensure!( refusal == "13", - "--quest-item: expected QUEST_INVALID reason 13 (ALREADY_ON, the director's 0x0d), \ + "--quest-item: expected QUEST_INVALID reason 13 (ALREADY_ON, 0x0d), \ got {refusal}" ); println!("✅ refusal: QUEST_INVALID reason 13 → ERR_QUEST_ALREADY_ON (the ref's 0x5dbca0)"); diff --git a/crates/benilla-protocol/src/messages/update_object/fields/tests.rs b/crates/benilla-protocol/src/messages/update_object/fields/tests.rs index 1b927384..265be6a9 100644 --- a/crates/benilla-protocol/src/messages/update_object/fields/tests.rs +++ b/crates/benilla-protocol/src/messages/update_object/fields/tests.rs @@ -308,7 +308,7 @@ fn player_bytes_3_byte_3_is_the_current_pvp_rank_not_the_highest() { assert_eq!( f.player_honor_rank(), None, - "the HIGHEST rank is a different field (1222) — absent means absent" + "the HIGHEST rank is a different field: absent means absent" ); // A demoted player keeps the higher lifetime rank. let demoted = ObjectFields::from_pairs(&[(195, 0x03_00_00_00), (1222, 0x0B_00_00_00)]); diff --git a/crates/benilla-srp/examples/provision_probe.rs b/crates/benilla-srp/examples/provision_probe.rs index 9f7e7424..a83c240e 100644 --- a/crates/benilla-srp/examples/provision_probe.rs +++ b/crates/benilla-srp/examples/provision_probe.rs @@ -65,7 +65,7 @@ fn main() { hex_from_le(&verifier), hex_from_le(&salt), ); - println!("-- then mint the character over the real wire (0423's probe; KEEP it):"); + println!("-- then mint the character over the real wire (keep it):"); println!( "-- WOW_USER={user_s} WOW_PASS={pass_s} WOW_PROBE_CHARCREATE=Probe{} \\", spelled(n) diff --git a/crates/benilla-world/src/terrain_stream/collider.rs b/crates/benilla-world/src/terrain_stream/collider.rs index 4b26d341..36a59f27 100644 --- a/crates/benilla-world/src/terrain_stream/collider.rs +++ b/crates/benilla-world/src/terrain_stream/collider.rs @@ -408,7 +408,7 @@ mod tests { /// On the shipped data, through the real cast: a body walking east from the pin stops at the /// flagged chunk's boundary 1.46 yd away, as 1.12.1 stops it, and walks through without walls. #[test] - fn a_body_walking_east_from_the_b129_pin_is_stopped_at_the_wall() { + fn a_body_walking_east_from_the_pin_is_stopped_at_the_wall() { /// The pin, and the MCNK boundary the flagged chunk starts at (WoW y; east is −y). const PIN: [f32; 3] = [-6601.98, -531.87, 335.60]; const WALL_Y: f32 = 32.0 * benilla_formats::TILE_SIZE - 528.0 * CHUNK_SIZE;