From 8bc3db634b0ac5a914d6156c8c9d8249d5f8dc77 Mon Sep 17 00:00:00 2001 From: grom Date: Thu, 5 Nov 2026 17:14:42 -0700 Subject: [PATCH] ATSW2's skin: the gaps a probe found, and the queue that is a task list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit grom: "Tho skin hasn't applied like it did the same for atsw1 and its missing all of the queue buttons." The queue buttons are not missing — version 2 replaced the queue with a task list and its bottom bar is four buttons upstream too. Driven offline the task rows, counts and delete buttons all appear. The skin gaps were real. Instead of comparing by eye, walk every visible region under ATSWFrame and report any texture still pointing at stock art: pfUI's StripTextures nils each region, so a leftover was either never visited or re-set afterwards. 15 before, 10 after. The ones that went: the task list's SECOND scrollframe, which exists only to hold the trainer scrollbar art and showed as two outlined boxes floating over the world, and the Attributes checkbox, the one stock box among pfUI's. Two more read off version 1's skin beside this one: the rank bar (a 637x17 slab once the frame art is stripped — version 1 resizes it to a 12 px pfUI bar, so this does too) and the task delete buttons, which inherit UIPanelCloseButton and want SkinCloseButton, not SkinButton — the latter leaves an empty box where the addon draws a red X. The skin itself lives in benilla-config/, which is gitignored; this is the record of it, with the probe that found the gaps. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn --- docs/ADDON_COMPAT.md | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/docs/ADDON_COMPAT.md b/docs/ADDON_COMPAT.md index 0fe852fa..cde7714d 100644 --- a/docs/ADDON_COMPAT.md +++ b/docs/ADDON_COMPAT.md @@ -4499,3 +4499,38 @@ Verified end to end offline, which `$WOW_CAPTURE_SPELLS` is what made possible: with 24 recipes, `ATSWFrameTab3:Click()`, and the window comes back `title=Cooking line=Cooking rows=9` with the check moved to tab 3. Before the fix the same click left the title on Blacksmithing. + +### Skin parity with version 1, measured rather than eyeballed + +grom, once the tabs worked: *"Tho skin hasn't applied like it did the same for atsw1 and its +missing all of the queue buttons."* + +**The queue buttons are not missing — version 2 does not have them.** Version 1 carries *Queue All +/ Create All / Queue / Process Queue / Empty Queue*; version 2 replaced the whole queue with a +**task list**, and its own README says so: *"Selected recipe can be placed into the task list for +later craft by clicking on the 'Task' button."* Its bottom bar is four buttons — Reagents, Amount, +Task, Create — in the upstream screenshot too. Driven offline (select a recipe, `ATSWTaskButton:Click()` +twice) the rows, their counts and their delete buttons all appear where they should. Its options are +`/atsw config`, not a button. + +**The skin gaps were real, and a probe named them instead of a comparison by eye.** Walk every +visible region under `ATSWFrame` and report any texture still pointing at stock art: pfUI's +`StripTextures` sets each region's texture to nil, so anything left either was never visited or was +re-set afterwards. Fifteen before, ten after, and the five that went were the gaps: + +| leftover | what it looked like | +|---|---| +| `ATSWTaskScrollFrameBackground` ×2 `UI-ClassTrainer-ScrollBar` | two outlined boxes floating at the window's right edge, over the world. A **second** ScrollFrame that exists only to hold the task list's scrollbar art; stripping `ATSWTaskScrollFrame` does not reach it | +| `ATSWAttributesButton` Up/Down/Highlight | the one stock checkbox among pfUI's, never skinned | + +The five that stayed are all intentional: the profession background art (upstream has it, and the +addon re-sets it on every open), the radio dots and the list highlight (version 1 keeps both), the +category `+`/`-` (the addon's own icon slot, shared with the recipe icon — a skin cannot tell them +apart without overriding `SetTexture` on a region the addon also *reads*), and a profession tab icon. + +Two more from reading version 1's skin beside this one: the **rank bar**, which unskinned is a +637x17 slab pinned under the title because the window's own art covers all but its right end — +version 1 answers that by resizing it to a 12 px pfUI bar with its own backdrop, so this does the +same with version 2's geometry — and the **task delete buttons**, which inherit `UIPanelCloseButton` +and therefore want `SkinCloseButton`, not `SkinButton`: the latter leaves a correct but empty box +where the addon draws a red X.