From a32300fad964ba35c64ba07724ddc1f117cd18b2 Mon Sep 17 00:00:00 2001 From: Sam Date: Wed, 23 Sep 2026 19:28:45 +0700 Subject: [PATCH] comments: six interface files say what each frame is and what it mirrors A frame's comment names the stock file or 1.12 default its shape follows; a Lua comment stays where the code would otherwise be "fixed". Notes the code contradicts are gone. With XML and Lua comments stripped every file is identical, and each is well-formed. Co-Authored-By: Claude Opus 5.5 (1M context) --- .../assets/ui/ContainerFrameAdapters.xml | 128 ++------ .../benilla-app/assets/ui/GameMenuFrame.xml | 259 ++++------------ .../benilla-app/assets/ui/KeyBindingsPage.xml | 219 +++++--------- .../benilla-app/assets/ui/ScriptLogFrame.xml | 171 ++++------- .../benilla-app/assets/ui/ScrollTemplates.xml | 281 +++++------------- .../assets/ui/SpellBookAdapters.xml | 30 +- 6 files changed, 284 insertions(+), 804 deletions(-) diff --git a/crates/benilla-app/assets/ui/ContainerFrameAdapters.xml b/crates/benilla-app/assets/ui/ContainerFrameAdapters.xml index d2b71067..d6f168ae 100644 --- a/crates/benilla-app/assets/ui/ContainerFrameAdapters.xml +++ b/crates/benilla-app/assets/ui/ContainerFrameAdapters.xml @@ -1,65 +1,19 @@ - + - - + - + @@ -252,9 +114,8 @@ - + @@ -263,18 +124,10 @@ - - + - + - + - -- The shared era-window scale first (ERA_WINDOW_SCALE, OptionsFrame.xml — loaded - -- before this file): the era menu has no scale of its own (GameMenuFrame.xml + - -- MainMenuFrameTemplates, grepped clean), it draws at UIParent's px-per-unit — - -- the SAME density as the era options window, whose checkFit caps at 1. The knob - -- is our stand-in for that UIParent scale; without it the menu drew 28% larger - -- relative to the options window than the era pair ("esc menu scale too big" — - -- director, 2026-08-04). `or 1` guards a load-order regression only. NOTE: this - -- lives INSIDE the existing OnShow — a second Scripts/OnShow block on the same - -- frame would silently REPLACE this one (SetScript semantics: last wins). + -- Deviation: ERA_WINDOW_SCALE (OptionsFrame.xml, loaded earlier) stands in for the + -- UIParent scale the era draws this menu and its options window at. + -- A second OnShow on this frame would replace this one: the last SetScript wins. this:SetScale(ERA_WINDOW_SCALE or 1) if UpdateMicroButtons then UpdateMicroButtons() end if Disable_BagButtons then Disable_BagButtons() end diff --git a/crates/benilla-app/assets/ui/KeyBindingsPage.xml b/crates/benilla-app/assets/ui/KeyBindingsPage.xml index f25a4bde..5132008b 100644 --- a/crates/benilla-app/assets/ui/KeyBindingsPage.xml +++ b/crates/benilla-app/assets/ui/KeyBindingsPage.xml @@ -1,77 +1,23 @@ - + - + @@ -141,19 +83,17 @@ - + - + @@ -335,16 +271,14 @@ - + FauxScrollFrame_OnVerticalScroll(BENILLA_SCRIPTLOG_ROW_HEIGHT, BenillaScriptLog_Update) - + @@ -367,8 +301,7 @@ - + @@ -392,18 +325,16 @@ BenillaScriptLogFrame_OnLoad(self) - + BenillaScriptLogFrame_OnMouseWheel(arg1) BenillaScriptLog_Update() BenillaScriptLogFrame_OnUpdate() - + @@ -322,39 +219,24 @@ - + @@ -374,9 +256,7 @@ + (v 82/256 .. 108/256), ending on v 0.421875 as ReputationFrame's does. --> @@ -386,8 +266,7 @@ + Declared last: an anchor to a later sibling falls back to the parent. --> @@ -399,22 +278,10 @@ - - diff --git a/crates/benilla-app/assets/ui/SpellBookAdapters.xml b/crates/benilla-app/assets/ui/SpellBookAdapters.xml index 80dfc700..b9173803 100644 --- a/crates/benilla-app/assets/ui/SpellBookAdapters.xml +++ b/crates/benilla-app/assets/ui/SpellBookAdapters.xml @@ -1,27 +1,13 @@