MONKEY (reviewfix-a): cloud-review fixes — cvars, capture fixture, wind pin, post perf

- farclip High seed 777 declared in SEEDED_DEVIATIONS (owner: High is the
  default); test walks the seeded column against every reference row (#6)
- WOW_CAPTURE_CVARS=<file> replaces BENILLA_HOME as the capture cvar fixture (#13)
- label derivation skips session-owned rows, so an env lever no longer
  persists graphicsQuality/lightingQuality = Custom (#14)
- /console help strings: restored line continuations + a test (#15)
- WOW_FOLIAGE_WIND read only in a dev build under WOW_CAPTURE (#16)
- fog node skipped at volumetricFog 0 with no lamp; fog and SSAO uniforms
  persistent per view, written in prepare (#17)
- tests: every governed graphics row through its observer; OptionsFrame
  farclip slider tied to view::FARCLIP_RANGE

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
pkuzic
2026-09-26 00:42:27 +01:00
co-authored by Claude Opus 5.5
parent 40238ad3e8
commit b2b5ef7539
7 changed files with 310 additions and 47 deletions
@@ -5732,3 +5732,29 @@ fn the_guild_line_greys_with_player_names_and_the_follow_speed_with_the_style()
assert!(speed_thumb(&mut s));
assert!(s.errors().is_empty(), "script errors: {:?}", s.errors());
}
/// MONKEY (reviewfix-a): the Advanced Graphics farclip slider's range is `view::FARCLIP_RANGE`,
/// and its 60-yd grid lands exactly on the maximum (the 1.12 grid the page advertises).
#[test]
fn farclip_slider_range_is_the_view_range() {
let xml = include_str!("../../assets/ui/OptionsFrame.xml");
let row = xml
.split("<Frame name=\"$parentRowRenderDistance\"")
.nth(1)
.expect("the farclip row");
let args = row
.split("OptionsSliderRow_Setup(self, ")
.nth(1)
.and_then(|rest| rest.split(')').next())
.expect("the slider setup call");
let nums: Vec<f32> = args
.split(',')
.take(3)
.map(|v| v.trim().parse().expect("numeric slider bound"))
.collect();
let range = benilla_world::view::FARCLIP_RANGE;
assert_eq!(nums[0], *range.start(), "slider min");
assert_eq!(nums[1], benilla_world::view::FARCLIP_MAX, "slider max");
assert_eq!(nums[1], *range.end());
assert_eq!((nums[1] - nums[0]) % nums[2], 0.0, "the step lands on the maximum");
}