From b2f02b069631409cfb25da1bc1d09874591aeded Mon Sep 17 00:00:00 2001 From: Sam Date: Thu, 24 Sep 2026 05:26:00 +0700 Subject: [PATCH] contributions: issues and pull requests are open The workflow that closed every pull request on arrival is gone, the README's closed-doors notice becomes a short Contributing section, and CONTRIBUTING.md says how to report a bug. Co-Authored-By: Claude Opus 5.5 (1M context) --- .github/workflows/close-prs.yml | 21 --------------------- README.md | 12 ++++++------ docs/CONTRIBUTING.md | 8 ++++++-- 3 files changed, 12 insertions(+), 29 deletions(-) delete mode 100644 .github/workflows/close-prs.yml diff --git a/.github/workflows/close-prs.yml b/.github/workflows/close-prs.yml deleted file mode 100644 index f2b9dfc8..00000000 --- a/.github/workflows/close-prs.yml +++ /dev/null @@ -1,21 +0,0 @@ -# GitHub has no switch to disable pull requests, so this closes them on arrival. -# Uses pull_request_target (base-repo context, no PR code checked out) so it can -# comment and close on PRs from forks. -name: close-prs -on: - pull_request_target: - types: [opened, reopened] -permissions: - pull-requests: write -jobs: - close: - runs-on: ubuntu-latest - steps: - - run: | - gh pr comment "$PR" --repo "$REPO" --body \ - "Thanks for the interest! benilla is a solo project and isn't taking pull requests for now — please bring bug reports and ideas to the Discord instead: https://discord.gg/wJSJx467G4" - gh pr close "$PR" --repo "$REPO" - env: - GH_TOKEN: ${{ github.token }} - PR: ${{ github.event.pull_request.number }} - REPO: ${{ github.repository }} diff --git a/README.md b/README.md index 280b251e..9d73c9d0 100644 --- a/README.md +++ b/README.md @@ -8,12 +8,6 @@

-> [!IMPORTANT] -> **Issues are off, and pull requests are not open yet.** [`docs/CONTRIBUTING.md`](docs/CONTRIBUTING.md) -> says what will get in when they are. Until then, the way to contribute is to join the -> [Discord](https://discord.gg/wJSJx467G4) and report the bugs you find. Questions and ideas are -> welcome in the same place. - benilla speaks the original 1.12.1 protocol, so it connects to any server the real client could, and reads its game data at runtime from your own 1.12.1 install. Every file format and the network protocol are implemented from scratch, with no original client code, no third-party WoW crates, @@ -74,6 +68,12 @@ at any IP or hostname, appending the auth port if yours is remapped (`WOW_HOST=play.example.com:5000`). Credentials go in at the login screen, or set `WOW_USER` / `WOW_PASS` to skip it. +## Contributing + +Issues and pull requests are open. [`docs/CONTRIBUTING.md`](docs/CONTRIBUTING.md) says what gets +in and how a change is judged. Bugs, questions and ideas are welcome on the +[Discord](https://discord.gg/wJSJx467G4) too. + --- Early inspiration and file format guidance came from the diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md index 201ecd50..225319d4 100644 --- a/docs/CONTRIBUTING.md +++ b/docs/CONTRIBUTING.md @@ -59,7 +59,11 @@ fork, and forks are welcome. - **The loop.** `cargo play` builds and runs the play profile. `scripts/check.sh` verifies a round of work; `scripts/gates.sh` is the full chain, and it opens a window for the engine boot checks, so it needs a display. Work on a branch. -- Bugs, questions and ideas go to the Discord linked from the README. Issues are off on purpose, - and pull requests are not open yet. + +## Reporting a bug + +Open an issue: what you did, what you saw and what 1.12.1 does instead, with the server and the +platform you ran on. Questions and ideas are welcome there or on the Discord linked from the +README. Working with an AI agent is expected. The agent reads `AGENTS.md`, and the same rules bind it.