From b50a66fefbb05b618da8b6a68d5ba31973b0529b Mon Sep 17 00:00:00 2001 From: pkuzic Date: Fri, 25 Sep 2026 23:27:02 +0100 Subject: [PATCH] =?UTF-8?q?MONKEY=20(reviewfix-a):=20WarcraftXL=20credits?= =?UTF-8?q?=20=E2=80=94=20standard=20header=20on=20grading,=20sky=5Ffx=20r?= =?UTF-8?q?ow,=20layer.rs=20module=20credit?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The grading port carries the same attribution header as the other WarcraftXL ports (used with the author's permission, attribution required). Co-Authored-By: Claude Opus 5.5 --- THIRD-PARTY.md | 3 ++- crates/benilla-app/src/post/grading.rs | 4 ++-- crates/benilla-app/src/post/grading.wgsl | 4 ++-- crates/benilla-world/src/clouds/layer.rs | 3 +++ 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/THIRD-PARTY.md b/THIRD-PARTY.md index 629f08ec..7011afc4 100644 --- a/THIRD-PARTY.md +++ b/THIRD-PARTY.md @@ -31,8 +31,9 @@ where they stand. Do not remove either. | `crates/benilla-assets/src/shaders/enhanced_water.wgsl` (beach surf, `on_bed`) | `wxl-experimental-water` | `sea/Shore.hpp`, `shaders/Shore.hlsli` | Shore surf limited by the terrain column, so objects standing in the water never foam (principle) | | `crates/benilla-assets/src/shaders/enhanced_water.wgsl` (Gerstner crests, High) + `crates/benilla-world/src/liquid/waves.rs` | `wxl-experimental-water` | `shaders/Surface.ps.hlsl`, `sea/Spectrum.*`, `sea/Ocean.*` | Gerstner displacement and fold-driven crest whitecaps; the CPU swimmer sample inverts the same displacement (ported) | | `crates/benilla-world/src/water_fx/bob.rs` | `wxl-experimental-water` | `world/Ride.cpp` | Visual-only wave riding for swimmers; the authoritative position never moves (principle, implemented independently) | -| `crates/benilla-app/src/post/grading.rs` + `crates/benilla-app/src/post/grading.wgsl` | `wxl-retail-grading` | `Grading.*`, `shaders/Grading.ps.hlsl` | 32³ LUT convention, strength control and strip lookup mathematics, with the strip uploaded as a native 3D texture (ported from the GPL-3.0-or-later source implementation, Copyright (C) 2026 WarcraftXL) | +| `crates/benilla-app/src/post/grading.rs` + `crates/benilla-app/src/post/grading.wgsl` | `wxl-retail-grading` | `Grading.cpp`, `shaders/Grading.ps.hlsl` | 32³ LUT convention, strength control and strip lookup mathematics, with the strip uploaded as a native 3D texture (ported; used with the author's permission, attribution required) | | `crates/benilla-world/src/shaders/sky_fx.wgsl` | `wxl-retail-clouds` | `Clouds.cpp`, `Clouds.hpp` | Domain-warped billow fbm (quintic value noise, 0.6 cotton blend, 0.55 octave gain) for the cloud detail | +| `crates/benilla-world/src/sky_fx.rs` | `wxl-retail-clouds` | `Clouds.cpp`, `Clouds.hpp` | The High cloud-detail tier and the sun-march inputs it feeds the sky and cloud materials (ported) | | `crates/benilla-world/src/shaders/cloud.wgsl` | `wxl-retail-clouds` | `Clouds.cpp` | The 3-tap march toward the sun (self-shadow, ambient floor) and the one-tap silver lining | | `crates/benilla-world/src/clouds/layer.rs` (`update_cloud_fx`) | `wxl-retail-clouds` | `Clouds.cpp` | March direction = the sun projected on the sheet, strength folded by its flatness (noon clouds evenly lit) | | `crates/benilla-world/src/wind/mod.rs` | `wxl-experimental-wind` | `field/Wind.hpp`, `field/Wind.cpp` | Stateless three-sine gust and veer field, default profile, and weather gain (ported) | diff --git a/crates/benilla-app/src/post/grading.rs b/crates/benilla-app/src/post/grading.rs index 7d2b28d6..fcdb1c2b 100644 --- a/crates/benilla-app/src/post/grading.rs +++ b/crates/benilla-app/src/post/grading.rs @@ -1,7 +1,7 @@ //! MONKEY (post): zone/day-night colour grading through a real 32³ GPU texture. //! -//! Ported from WarcraftXL's `wxl-retail-grading` (Copyright (C) 2026 WarcraftXL, GPL-3.0-or-later). -//! Its 1024×32 BLP strip/two-bilinear-tap cube lookup becomes the equivalent hardware-trilinear +//! Ported from WarcraftXL (https://github.com/WarcraftXL) by iThorgrim — module wxl-retail-grading, Grading.cpp, shaders/Grading.ps.hlsl. +//! Used with the author's permission; attribution required. Its 1024×32 BLP strip/two-bilinear-tap cube lookup becomes the equivalent hardware-trilinear //! lookup after upload to a 3D texture. See `THIRD-PARTY.md`. use super::bloom::BloomLabel; diff --git a/crates/benilla-app/src/post/grading.wgsl b/crates/benilla-app/src/post/grading.wgsl index 103ef98b..ec2aefe9 100644 --- a/crates/benilla-app/src/post/grading.wgsl +++ b/crates/benilla-app/src/post/grading.wgsl @@ -1,5 +1,5 @@ -// Colour grading ported from WarcraftXL wxl-retail-grading. -// Copyright (C) 2026 WarcraftXL. GPL-3.0-or-later; see THIRD-PARTY.md. +// Ported from WarcraftXL (https://github.com/WarcraftXL) by iThorgrim — module wxl-retail-grading, Grading.cpp, shaders/Grading.ps.hlsl. +// Used with the author's permission; attribution required. See THIRD-PARTY.md. // MONKEY (post): real 32³ textures make the original 1024x32 strip's two bilinear taps plus // lerp(fract(b*31)) one hardware-trilinear lookup, for both the day and night cubes. diff --git a/crates/benilla-world/src/clouds/layer.rs b/crates/benilla-world/src/clouds/layer.rs index cfffa46e..ce4a45c0 100644 --- a/crates/benilla-world/src/clouds/layer.rs +++ b/crates/benilla-world/src/clouds/layer.rs @@ -2,6 +2,9 @@ //! `0x58ac70` upload): a 12-ring cap from the pole to the 45° rim, faded at the rim, drawn last in //! the sky pass so clouds blend over a setting sun. [`crate::sky_order::CLOUDS_BIAS`] holds that //! place; the shared far-depth pin puts it behind all terrain. +//! +//! The sun march feed (`update_cloud_fx`): +//! Ported from WarcraftXL (https://github.com/WarcraftXL) by iThorgrim — module wxl-retail-clouds, Clouds.cpp. use bevy::asset::RenderAssetUsages; use bevy::camera::Projection;