Comments in benilla-assets and benilla-ui: three reference facts corrected, one deviation labelled (#290)
Comment corrections in crates whose comment pass has already landed. Comment text only: every file strips to identical code. - Fixes #61. The `<Script file=>` note in `benilla-ui`'s loader now names the install directory as the reference's scan root (`0x646ea0`, from Storm's base path `0xc52418`), not the process's working directory. The deviation it records is unchanged. - Fixes #96. `liquid.wgsl` no longer labels the ADT water alpha a deviation. The swatch's own alpha is what the reference uses: the `0xc7fbc0` table's texture binds only behind `[0xc800ec]`, which never holds one. - Fixes #117. `wmo.rs` now gives prop creation as the streaming-window commit (`0x698720` → `0x695aa0`, once per group) and per-frame visibility as the portal walk's admission (`0x685d70` → `0x6838f0`). - `model.rs`: the billboard-card normal flip carries the Deviation label, with the reason `benilla-formats` already gives where the test lives: the reference shades such a card inverted and camera-dependent. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
f48f32e741
commit
c04d74f47c
@@ -316,9 +316,9 @@ impl Loader<'_> {
|
||||
TopLevel::Include(path) => self.do_include(path),
|
||||
// Deviation: a `<Script file=>` value with a separator joins the including
|
||||
// document's directory, like a bare name. The reference uses it verbatim
|
||||
// (`0x6ee070`-`0x6ee079`) against the process CWD (`0x647e60`, `0x646ebc`; the
|
||||
// basename retry at `0x647ed3` is off), where it never opens, so joining breaks
|
||||
// nothing that loads on 1.12.
|
||||
// (`0x6ee070`-`0x6ee079`) against the install directory, the root `0x646ea0`
|
||||
// scans from Storm's base path `0xc52418` (the basename retry at `0x647ed3` is
|
||||
// off), where a stock install has no such file, so joining breaks nothing.
|
||||
TopLevel::Script(ScriptRef::File(path)) => {
|
||||
let joined = join_ref(self.base(), path);
|
||||
match (self.files)(&joined) {
|
||||
|
||||
Reference in New Issue
Block a user