From d0846e25166c3e589f8bca7ea56f26b7877d3ff1 Mon Sep 17 00:00:00 2001 From: Sam Date: Wed, 23 Sep 2026 20:26:52 +0700 Subject: [PATCH] comments: the XP-gain reader says why dropping the group bonus is safe vmangos always sends 1.0, meaning none (Player.cpp:3039), so 1.12 shows no group-bonus line against it either. Co-Authored-By: Claude Opus 5.5 (1M context) --- crates/benilla-protocol/src/messages/progression.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crates/benilla-protocol/src/messages/progression.rs b/crates/benilla-protocol/src/messages/progression.rs index 318153b7..bb26e663 100644 --- a/crates/benilla-protocol/src/messages/progression.rs +++ b/crates/benilla-protocol/src/messages/progression.rs @@ -16,7 +16,8 @@ pub struct XpGain { } /// Read `SMSG_LOG_XPGAIN`: `u64 victim, u32 total, u8 type` (0 kill, 1 other), then for a kill -/// `u32 base, f32 groupBonus`. Deviation: the group bonus is read and dropped. +/// `u32 base, f32 groupBonus`. Deviation: the group bonus is read and dropped; vmangos always +/// sends 1.0, meaning none (`Player.cpp:3039`), so 1.12 shows no group-bonus line either. pub(super) fn read_xp_gain(r: &mut impl Read) -> io::Result { let victim = read_u64_le(r)?; let total = read_u32_le(r)?;