From fb17a68fe52da5322361f9fc6ece17d554e7d33e Mon Sep 17 00:00:00 2001
From: Sam <samuv.eth@gmail.com>
Date: Thu, 24 Sep 2026 05:26:00 +0700
Subject: [PATCH] comments: the era settings screens say why they replace
 1.12's

The options window, the ESC menu and the key bindings page follow the 1.15 era client because
1.12's settings screens are much worse to use.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---
 crates/benilla-app/assets/ui/GameMenuFrame.xml   | 11 ++++++-----
 crates/benilla-app/assets/ui/KeyBindingsPage.xml |  5 +++--
 crates/benilla-app/assets/ui/OptionsFrame.xml    |  3 ++-
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/crates/benilla-app/assets/ui/GameMenuFrame.xml b/crates/benilla-app/assets/ui/GameMenuFrame.xml
index 65d1c02a..72422d9b 100644
--- a/crates/benilla-app/assets/ui/GameMenuFrame.xml
+++ b/crates/benilla-app/assets/ui/GameMenuFrame.xml
@@ -5,11 +5,12 @@
         header at TOP +12 with the title 14px down it, the reference's click sounds, and the stock
         `GameMenuButtonTemplate`, which the era's MainMenuFrameButtonTemplate matches in art,
         size and label fonts.
-        Deviation: the ladder is the 1.15 era client's ESC menu (GameMenuFrame.lua l.62-162) at
-        its layout numbers, padding 32 top and 28 elsewhere (MainMenuFrameTemplates.xml l.18-33)
-        and a 20-unit gap between groups (MainMenuFrameTemplates.lua l.61-71). It drops the era's
-        AddOns rung, because the character-select AddOns screen is the only addon UI; Key
-        Bindings is in the options window, as in the era.
+        Deviation: the ladder is the 1.15 era client's ESC menu (GameMenuFrame.lua l.62-162),
+        because its settings screens replace 1.12's, which are much worse to use. It keeps the
+        era's layout numbers, padding 32 top and 28 elsewhere (MainMenuFrameTemplates.xml
+        l.18-33) and a 20-unit gap between groups (MainMenuFrameTemplates.lua l.61-71), and drops
+        the era's AddOns rung, because the character-select AddOns screen is the only addon UI;
+        Key Bindings is in the options window, as in the era.
         Names are the reference's, unprefixed: addons address `GameMenuFrame` by name.
     -->
     <Script><![CDATA[
diff --git a/crates/benilla-app/assets/ui/KeyBindingsPage.xml b/crates/benilla-app/assets/ui/KeyBindingsPage.xml
index 5132008b..2c316954 100644
--- a/crates/benilla-app/assets/ui/KeyBindingsPage.xml
+++ b/crates/benilla-app/assets/ui/KeyBindingsPage.xml
@@ -5,8 +5,9 @@
         rows are children of the Keybindings body in OptionsFrame.xml, which loads after it. Only
         commands the engine dispatches are registered, so only they and their categories appear.
         Deviation: the page is the era Settings panel's Keybindings page (Keybindings.lua,
-        KeybindingsOverrides.lua): one list of collapsible category sections, the Character
-        Specific Keybindings checkbox as its first row, and search results that open this page.
+        KeybindingsOverrides.lua), because 1.12's settings screens are much worse to use. It is
+        one list of collapsible category sections, the Character Specific Keybindings checkbox as
+        its first row, and search results that open this page.
         Capture and set follow 1.12's Blizzard_BindingUI where the two differ: a capsule click
         arms, the next key or mouse 3/4/5 press binds at once, left and right clicks only select,
         the wheel binds like any key, and ESC while armed binds Escape (1.12's OnKeyDown has no
diff --git a/crates/benilla-app/assets/ui/OptionsFrame.xml b/crates/benilla-app/assets/ui/OptionsFrame.xml
index 4a74478c..7d526c88 100644
--- a/crates/benilla-app/assets/ui/OptionsFrame.xml
+++ b/crates/benilla-app/assets/ui/OptionsFrame.xml
@@ -1,7 +1,8 @@
 <Ui>
     <!--
         The Options window, opened from the game menu. Deviation: the 1.15 era client's single
-        settings window replaces the 1.12 four-panel family, whose frames load hidden for addons.
+        settings window replaces the 1.12 four-panel family, which is much worse to use; the 1.12
+        frames still load, hidden, for addons.
         Structure follows the era UI source (1.15.9), surfaces the 1.14 System window
         (OptionsFrameTemplates.xml); every art byte is 1.12-native or a colour fill, so era atlas
         names below cite geometry only. Cut from the era window: the corner close X, live tabs,