Files
gromandClaude Opus 5 d70a9d6130 water: the gates are green and the option row is real
`cargo test --workspace` is back to this fork's own baseline: 12 failures in
benilla-app, every one of them the pre-existing data-half golden, and nothing
else in the workspace red. It was 318 before this commit.

One cause carried ~302 of them: his Improved Water options row calls
`BenillaOptionsRow_OnLoad` and inherits `BenillaOptionsCheckboxRowTemplate`,
neither of which exists here, so OptionsFrame.xml raised during its load and
every shipped-UI test that builds the interface fell with it. The row now takes
this fork's `OptionsRow_OnLoad` and `OptionsCheckboxRowTemplate`, is listed in
`OPTIONS_PAGE_ROWS` (without which the page never laid it out, so the tooltip
census found 142 rows and not 143) and is anchored under Field of View, which is
what actually precedes it here — anchored under Render Scale it showed the row
above's description on hover, which is exactly what that test is for.

The rest:
  * both WGSL tripwires -- his, and the one he added to benilla-assets -- now
    find this fork's own shader libraries (`fog_hook`, `emissive_hook`,
    `monkey_frame`), so they can compose the file they exist to validate. They
    are worth having: the assets one checks liquid.wgsl across every pipeline
    variant a player reaches, without a GPU.
  * `fog_law` takes `fog_hook::fog_linear` rather than its own copy of the law,
    and his "fogged once" test checks that both lanes go through the hook. They
    are still not the same fog under `fogModel 1`: `apply_fog` applies the
    Modern model and his stylised terms do not. Recorded, not fixed.
  * the liquid sheets are back on `tex_filter().descriptor()`, so the live
    filter refresh reaches them -- an inline twin is a sampler that refresh
    never recognises.
  * the Update ambiguity ceiling rises 13 for his water's own systems, with the
    reason; PostUpdate ratchets down 495 -> 470 now our planar pass is gone.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
2026-11-09 13:14:37 -07:00
..