This checkout had no git history at all, so this one commit carries the whole
of the Everwood work as a single import on top of chairmanpow/benilla-octo's
`main` (706cd71). The two trees have genuinely diverged — each has files the
other does not — so this is a fork point, not a catch-up.
Today's work, which is the reason a baseline exists at all:
- Booth previews no longer cast world shadows (`NO_BOOTH_SHADOW`). Portrait
characters were entering the sun's shadow cascades, so every skinned-rig
shadow specialization compiled live mid-frame; the hitch detector logged
"main thread blocked 1316 ms" beside a `compiled LIVE` warning. This was
the Fashion/Tmog stutter.
- Per-pane dress-up: each `DressUpModel` pane assembles and stages its own
tried-on look instead of every pane mirroring the live player.
- Item template cache is append-only JSONL written on the IO pool, replacing
an 11.6 MB whole-map JSON rewrite on the main thread every 10 s.
- `WOW_SYSTEM_TIMING` rebuilt per-thread: it took 2 mutexes per system enter
and 4 per exit, costing 15 ms a frame (590 fps -> 60) and corrupting the
measurements it was taken to produce.
- The visibility-churn sweep moved to its own `WOW_FLASH_CHURN` switch, so a
frame-cost reading no longer pays 2.7 ms a frame for it.
Local state (`benilla-config/`, `logs/`, `target/`) is excluded by the
existing .gitignore; the account credential it holds is not in this commit.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
149 lines
5.0 KiB
Rust
149 lines
5.0 KiB
Rust
//! `SMSG_CHAR_ENUM` in vmangos `Player::BuildEnumData` order (`Player.cpp:1629`), two entries per
|
|
//! body so any misalignment shows, plus the logout and refused-login replies.
|
|
|
|
use benilla_protocol::events::{decode, SessionEvent};
|
|
use benilla_protocol::messages;
|
|
use benilla_protocol::ServerPacket;
|
|
|
|
/// One enum entry; the fixed fields hold distinct values so a misaligned parse cannot pass.
|
|
fn enum_entry(
|
|
guid: u64,
|
|
name: &str,
|
|
race: u8,
|
|
class: u8,
|
|
gender: u8,
|
|
level: u8,
|
|
map: u32,
|
|
pos: [f32; 3],
|
|
pet_display: u32,
|
|
) -> Vec<u8> {
|
|
let mut b = Vec::new();
|
|
b.extend_from_slice(&guid.to_le_bytes());
|
|
b.extend_from_slice(name.as_bytes());
|
|
b.push(0);
|
|
b.extend_from_slice(&[race, class, gender]);
|
|
b.extend_from_slice(&[3, 4, 5, 6, 7]); // skin/face/hairStyle/hairColor/facialHair
|
|
b.push(level);
|
|
b.extend_from_slice(&12u32.to_le_bytes()); // zone
|
|
b.extend_from_slice(&map.to_le_bytes());
|
|
for c in pos {
|
|
b.extend_from_slice(&c.to_le_bytes());
|
|
}
|
|
b.extend_from_slice(&0u32.to_le_bytes()); // guild id
|
|
b.extend_from_slice(&0x0200_0000u32.to_le_bytes()); // character flags (DECLINED, a junk value)
|
|
b.push(1); // first login
|
|
b.extend_from_slice(&pet_display.to_le_bytes()); // pet display id
|
|
b.extend_from_slice(&7u32.to_le_bytes()); // pet level
|
|
b.extend_from_slice(&1u32.to_le_bytes()); // pet family
|
|
for slot in 0..19u32 {
|
|
b.extend_from_slice(&(1000 + slot).to_le_bytes()); // equipment display id
|
|
b.push(slot as u8); // inventory type
|
|
}
|
|
b.extend_from_slice(&2000u32.to_le_bytes()); // first bag display id
|
|
b.push(18); // first bag inventory type
|
|
b
|
|
}
|
|
|
|
#[test]
|
|
fn char_enum_roster_parses_and_decodes() {
|
|
let mut body = vec![2u8]; // count
|
|
body.extend(enum_entry(
|
|
0x0000_0000_0000_0007,
|
|
"Two",
|
|
1, // Human
|
|
1, // Warrior
|
|
0,
|
|
1,
|
|
0,
|
|
[-8949.95, -132.493, 83.5312],
|
|
99, // a pet, which the select screen stands beside this character
|
|
));
|
|
body.extend(enum_entry(
|
|
0x0000_0000_0000_0009,
|
|
"Twomage",
|
|
1, // Human
|
|
8, // Mage
|
|
1,
|
|
60,
|
|
1,
|
|
[1.5, -2.5, 3.5],
|
|
0, // a mage: the server sends the triple zeroed, and no pet renders
|
|
));
|
|
|
|
let p = messages::parse_server(messages::opcode::SMSG_CHAR_ENUM, &body).unwrap();
|
|
let ServerPacket::CharEnum { ref characters } = p else {
|
|
panic!("char enum")
|
|
};
|
|
assert_eq!(characters.len(), 2);
|
|
let c = &characters[0];
|
|
assert_eq!(
|
|
(c.guid, c.name.as_str(), c.race, c.class, c.gender),
|
|
(7, "Two", 1, 1, 0)
|
|
);
|
|
assert_eq!(
|
|
(c.skin, c.face, c.hair_style, c.hair_color, c.facial_hair),
|
|
(3, 4, 5, 6, 7)
|
|
);
|
|
assert_eq!((c.zone, c.flags), (12, 0x0200_0000));
|
|
// The pet triple sits before the equipment array: a misread slides every display id below.
|
|
assert_eq!(
|
|
(c.pet_display_id, c.pet_level, c.pet_family),
|
|
(99, 7, 1),
|
|
"the hunter/warlock pet the select screen renders"
|
|
);
|
|
assert_eq!((c.level, c.map), (1, 0));
|
|
assert_eq!((c.position.x, c.position.y), (-8949.95, -132.493));
|
|
for (slot, item) in c.equipment.iter().enumerate() {
|
|
assert_eq!(
|
|
(item.display_id, item.inventory_type),
|
|
(1000 + slot as u32, slot as u8)
|
|
);
|
|
}
|
|
let c = &characters[1];
|
|
assert_eq!(
|
|
(c.guid, c.name.as_str(), c.race, c.class, c.gender),
|
|
(9, "Twomage", 1, 8, 1)
|
|
);
|
|
assert_eq!((c.level, c.map, c.position.z), (60, 1, 3.5));
|
|
assert_eq!(c.equipment[18].display_id, 1018);
|
|
// The server zeroes the triple for all but a hunter's or warlock's pet, so display id 0 is the
|
|
// whole no-pet gate.
|
|
assert_eq!(c.pet_display_id, 0);
|
|
|
|
// The raw decode has no realm; the IO thread's own emit carries the auth realm entry.
|
|
match &decode(p)[..] {
|
|
[SessionEvent::CharacterList { characters, realm }] => {
|
|
assert_eq!(characters.len(), 2);
|
|
assert!(realm.is_none());
|
|
}
|
|
other => panic!("expected CharacterList, got {other:?}"),
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn logout_complete_decodes_to_logged_out() {
|
|
let p = messages::parse_server(messages::opcode::SMSG_LOGOUT_COMPLETE, &[]).unwrap();
|
|
assert!(matches!(decode(p)[..], [SessionEvent::LoggedOut]));
|
|
}
|
|
|
|
/// `SMSG_CHARACTER_LOGIN_FAILED` (opcode 65): one raw 1-based reason byte the glue layer maps;
|
|
/// vmangos sends only `0x01`, and `0x08` is past the reference's six-entry switch.
|
|
#[test]
|
|
fn a_refused_character_login_parses_and_decodes() {
|
|
for result in [0x01u8, 0x08] {
|
|
let p = messages::parse_server(
|
|
messages::opcode::SMSG_CHARACTER_LOGIN_FAILED,
|
|
std::slice::from_ref(&result),
|
|
)
|
|
.unwrap();
|
|
assert!(matches!(
|
|
p,
|
|
ServerPacket::CharacterLoginFailed { result: got } if got == result
|
|
));
|
|
assert!(matches!(
|
|
decode(p)[..],
|
|
[SessionEvent::CharacterLoginFailed { result: got }] if got == result
|
|
));
|
|
}
|
|
}
|