Files
benilla-octo/crates/benilla-ui/src/script/tests/structure_queries.rs
T
Sam SungandClaude Opus 5.5 fd386e75ae Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)
Part of #41: the comments of `benilla-ui` (the Lua UI engine, its FrameXML loader and its widgets) are rewritten to the rule in `docs/METHOD.md`, which is what the code does and the reference fact behind it, in a line. 43,140 comment lines become 15,161.

- **The mechanical strip.** The citations that were only a private record number go first, and each edit is shown to be a pure removal.
- **Wrong facts corrected.** The rewrite corrects the comments that stated wrong facts. Among them:
  - `0x64a480` is the case-sensitive compare (a byte `repz cmpsb`), and `0x64a4c0` the case-insensitive one.
  - A frame's id sits at `+0xb0`, not `+0xb4`. `EnableKeyboard`/`IsKeyboardEnabled` are `0x776ec0`/`0x776f90`.
  - A region's unpinned edge has no fallback to its owner's rect: the owner supplies only the scale.
  - `$parent` expands to the nearest named ancestor, or "Top" when none is named (`0x76c5b0`), not simply to the parent.
  - A StatusBar fills from its internal normalised fraction, not from `GetValue()`.
  - The addresses of `StartDuel` and `StartDuelUnit` were swapped.
  - Many "untraced" notes now give the traced reference fact: the drag threshold, the per-grip sizing edges, the empty-`autoFocus` skip, and `SetTexCoordModifiesRect`'s default.
  - Stock FrameXML line citations are checked against the stock 1.12 files and corrected. `ref-` file names become the stock file names.
- **Deviation labels.** "Deviation:" now marks only a choice with a reason. A surface that exists only for the retired Era addon target says so plainly: it is not 1.12.
- **Verification.** Every file strips to identical code, and `cargo fmt --check` is clean. Nine second readers compared every file old against new, restored the facts the rewrite had dropped, and checked each new citation against the code, the stock files, vmangos and the reference.

Behaviour differences the rewrite surfaced are filed as their own issues (#131–#142), and more are being validated. The comments here state what the code does. String literals are untouched; they are #92.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-09-25 01:58:49 +07:00

136 lines
4.9 KiB
Rust

//! The structure queries `GetChildren`, `GetNumChildren`, `GetRegions` and `GetNumRegions`
//! (`0x773f60`/`0x774180`): they walk `[frame+0x300]` and `[frame+0x1b8]`, whose linkers append at
//! the tail, so values come back oldest first as multiple returns, hidden ones included.
use super::common::script;
#[test]
fn the_structure_queries_report_the_structure() {
let mut s = script();
s.set_screen_size(800.0, 600.0);
s.run(
r#"
host = CreateFrame("Frame", "SQHost", UIParent)
-- children, in creation order; one of them hidden, because a structure query is not a
-- visibility query and an addon reskinning a frame must still see what is hidden.
a = CreateFrame("Frame", "SQChildA", host)
b = CreateFrame("Button", "SQChildB", host)
b:Hide()
c = CreateFrame("Frame", "SQChildC", host)
-- regions, in creation order, across two draw layers: a BACKGROUND texture declared FIRST
-- and an OVERLAY fontstring declared second, so a draw-ordered walk and a creation-ordered
-- one are distinguishable.
t1 = host:CreateTexture("SQTexA", "BACKGROUND")
fs = host:CreateFontString("SQFontB", "OVERLAY")
t2 = host:CreateTexture("SQTexC", "BACKGROUND")
"#,
)
.unwrap();
// ── The lists, by name and in order.
assert_eq!(
s.eval::<String>(
"local n = '' for _, v in ipairs({ SQHost:GetChildren() }) do \
n = n .. v:GetName() .. ' ' end return n"
)
.unwrap(),
"SQChildA SQChildB SQChildC ",
"children come back in the arena's insertion order — the client's +0x300 child-list order"
);
assert_eq!(
s.eval::<String>(
"local n = '' for _, v in ipairs({ SQHost:GetRegions() }) do \
n = n .. v:GetName() .. ' ' end return n"
)
.unwrap(),
"SQTexA SQFontB SQTexC ",
"regions come back in CREATION order, not draw order — the OVERLAY fontstring stays second"
);
// ── The counts are the same walk.
assert_eq!(
s.eval::<(usize, usize)>(
"return SQHost:GetNumChildren(), table.getn({ SQHost:GetChildren() })"
)
.unwrap(),
(3, 3)
);
assert_eq!(
s.eval::<(usize, usize)>(
"return SQHost:GetNumRegions(), table.getn({ SQHost:GetRegions() })"
)
.unwrap(),
(3, 3)
);
// ── Usable objects: pfUI's `StripTextures` tests `v.SetTexture`, then calls it.
assert_eq!(
s.eval::<String>(
"local out = '' for _, v in ipairs({ SQHost:GetRegions() }) do \
if v.SetTexture then v:SetTexture(nil) out = out .. 'T' else out = out .. 'F' end \
end return out"
)
.unwrap(),
"TFT",
"a texture answers SetTexture and a fontstring does not — the StripTextures branch"
);
// ── An empty frame returns no values and counts zero.
assert_eq!(
s.eval::<(usize, usize, usize)>(
"local e = CreateFrame(\"Frame\", \"SQEmpty\", UIParent) \
return e:GetNumChildren(), e:GetNumRegions(), table.getn({ e:GetRegions() })"
)
.unwrap(),
(0, 0, 0)
);
// ── A detached region leaves both verbs: `Region:SetParent(nil)` unlinks it from the draw
// layer and the region list (`0x77fd10`); our arena keeps the entry, unseen here.
s.run("SQFontB:SetParent(nil)").unwrap();
assert_eq!(
s.eval::<String>(
"local n = '' for _, v in ipairs({ SQHost:GetRegions() }) do \
n = n .. v:GetName() .. ' ' end return n"
)
.unwrap(),
"SQTexA SQTexC ",
"a detached region is gone from the list"
);
assert_eq!(
s.eval::<usize>("return SQHost:GetNumRegions()").unwrap(),
2,
"...and from the count, which is the same walk"
);
// ── The title region is not in the list: its creation sets `[this+0x9c] = parent` without
// the region linker, and `Hide`/`Show` handle `[frame+0xa8]` separately (`0x768060`).
s.run("SQHost:CreateTitleRegion()").unwrap();
assert_eq!(
s.eval::<usize>("return SQHost:GetNumRegions()").unwrap(),
2,
"a title region does not join the region list"
);
assert_eq!(
s.eval::<String>(
"local n = '' for _, v in ipairs({ SQHost:GetRegions() }) do \
n = n .. v:GetName() .. ' ' end return n"
)
.unwrap(),
"SQTexA SQTexC ",
"...and does not appear in it"
);
// ── A reparented child leaves its old parent's list.
s.run("SQChildB:SetParent(UIParent)").unwrap();
assert_eq!(
s.eval::<String>(
"local n = '' for _, v in ipairs({ SQHost:GetChildren() }) do \
n = n .. v:GetName() .. ' ' end return n"
)
.unwrap(),
"SQChildA SQChildC ",
"a reparented child is gone from its old parent's list"
);
}