Files
benilla-octo/crates/benilla-app/assets/ui/CharacterFrameAdapters.xml
T
gromandClaude Opus 5 81d96af35d Everwood: the HD/OctoWoW line of benilla, imported onto upstream
This checkout had no git history at all, so this one commit carries the whole
of the Everwood work as a single import on top of chairmanpow/benilla-octo's
`main` (706cd71). The two trees have genuinely diverged — each has files the
other does not — so this is a fork point, not a catch-up.

Today's work, which is the reason a baseline exists at all:

- Booth previews no longer cast world shadows (`NO_BOOTH_SHADOW`). Portrait
  characters were entering the sun's shadow cascades, so every skinned-rig
  shadow specialization compiled live mid-frame; the hitch detector logged
  "main thread blocked 1316 ms" beside a `compiled LIVE` warning. This was
  the Fashion/Tmog stutter.
- Per-pane dress-up: each `DressUpModel` pane assembles and stages its own
  tried-on look instead of every pane mirroring the live player.
- Item template cache is append-only JSONL written on the IO pool, replacing
  an 11.6 MB whole-map JSON rewrite on the main thread every 10 s.
- `WOW_SYSTEM_TIMING` rebuilt per-thread: it took 2 mutexes per system enter
  and 4 per exit, costing 15 ms a frame (590 fps -> 60) and corrupting the
  measurements it was taken to produce.
- The visibility-churn sweep moved to its own `WOW_FLASH_CHURN` switch, so a
  frame-cost reading no longer pays 2.7 ms a frame for it.

Local state (`benilla-config/`, `logs/`, `target/`) is excluded by the
existing .gitignore; the account credential it holds is not in this commit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
2026-10-15 15:01:14 -06:00

17 lines
1.1 KiB
XML

<!--
Adapters over the stock CharacterFrame.xml; loaded after it, so these win.
Deviation: `ArenaFrame`, a sixth tab page 1.12 has no version of. TurtleWoW's `patch-4.mpq`
copy of `CharacterFrame.lua` appends "ArenaFrame" to `CHARACTERFRAME_SUBFRAMES` — six names
where the reference has five (line 1) — so `CharacterFrame_ShowSubFrame` indexes all six and
raises `attempt to index field '?' a nil value` on the fifth tab's Hide. There is no
`ArenaFrame.lua` or `.xml` anywhere in the player's chain, none in the reference `_G` capture,
and benilla implements no arena frames, so the name has to exist or the character window's own
tab loop dies. An empty hidden frame is the whole of it: no tab button, no content, no script.
`id="6"` continues the reference's own numbering (PaperDoll 1, PetPaperDoll 2, Reputation 3,
Skill 4, Honor 5), which is what `ToggleCharacter` hands `PanelTemplates_SetTab`.
-->
<Ui xmlns="http://www.blizzard.com/wow/ui/">
<Frame name="ArenaFrame" setAllPoints="true" parent="CharacterFrame" hidden="true" id="6" />
</Ui>