Sam SungandClaude Opus 5.5
8505187668
Part of #41: the comments of `benilla-formats` (the library, its extract tools, examples and tests) are rewritten to the rule in `docs/METHOD.md`, which is what the code does and the reference fact behind it, in a line. 19,654 comment lines become 7,264. Fixes #105: the WMO collision comments now name walking's box-query leaf `0x6bca50` and the camera and line-of-sight segment-query leaf `0x6bc700`, in `models/collision.rs`, `examples/wmo_bsp.rs` and `tests/chain.rs`. - **The mechanical strip.** The citations that were only a private record number go first, and each edit is shown to be a pure removal. - **Wrong facts corrected.** The rewrite corrects the comments that stated wrong facts. Among them: - A placed doodad's material alpha reads file slot 0 on its spawn clock, while the reference reads bone 0's armed sequence, re-rolled every play window. The old text said doodads are armed once at load. - The fog end is stored ×36 and scaled once at load (`0x6d6090`). It is not raw. - The MCSH bit picks a map doodad's sun scale, 1.0 lit or 0.5 shadowed. 2.5 belongs to an entity's light node. - `SpellRec` is the row as stored, column × 4, not a translated copy. - A global sequence's clock is anchored at the instance's attach time (`0x714352`). - Particle twinkle is a gated size multiplier (`0x7b2adc`). - The blob shadow sizes from the Stand box. - Data claims are checked against the install: the weapon-trail kits' parameters and alphas, the beam rows' noise, and the maps' `field_16`. - Dozens more turned up on the way: renamed or deleted items, docs sitting on the wrong item, stale counts and links. - **Deviation labels.** "Deviation:" now marks only a choice with a reason. An unbuilt behaviour says so plainly. - **Verification.** Every file strips to identical code, and `cargo fmt --check` is clean. Four second readers compared every file old against new, restored the facts the rewrite had dropped, and checked each new citation against the reference, the code and the shipped data. String literals are untouched; they are #92. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
73 lines
2.7 KiB
Rust
73 lines
2.7 KiB
Rust
//! `RenderSubmesh::section`: two batches naming one M2 skin section draw the same triangles, so
|
|
//! they are coplanar and `terrain_stream::spawn::assemble` keeps them on one vertex-transform lane.
|
|
//! The Ballista's bolt head and shields each add an `ARMORREFLECT3` shine that is additive,
|
|
//! env-mapped and render flag `0x10`, each a consolidator exclusion.
|
|
|
|
use benilla_formats::{load_m2_mesh, open_chain, RenderSubmesh};
|
|
|
|
/// What the consolidators exclude: `static_gx::divert` refuses env-mapped and depth-flagged
|
|
/// batches, the merge lane additive ones.
|
|
fn refusable(s: &RenderSubmesh) -> bool {
|
|
s.env_map || s.no_depth_write || s.no_depth_test || s.additive
|
|
}
|
|
|
|
#[test]
|
|
fn the_ballista_authors_a_coplanar_shine_over_its_bolt_head_and_shields() {
|
|
let data = benilla_formats::wow_data_or_skip!();
|
|
let mut chain = open_chain(&data).expect("open vanilla patch chain");
|
|
let subs = load_m2_mesh(
|
|
&mut chain,
|
|
"World\\Azeroth\\Elwynn\\PassiveDoodads\\Ballista\\Ballista.m2",
|
|
)
|
|
.expect("load Ballista");
|
|
|
|
assert!(
|
|
subs.iter().all(|s| s.section.is_some()),
|
|
"every M2 batch carries its skin-section index"
|
|
);
|
|
|
|
let mut shared = 0;
|
|
for section in [7u16, 10] {
|
|
let batches: Vec<&RenderSubmesh> =
|
|
subs.iter().filter(|s| s.section == Some(section)).collect();
|
|
assert_eq!(
|
|
batches.len(),
|
|
2,
|
|
"Ballista section {section} is drawn by a base batch and a shine batch"
|
|
);
|
|
assert_eq!(
|
|
batches.iter().filter(|s| refusable(s)).count(),
|
|
1,
|
|
"exactly one of section {section}'s two batches is a consolidator exclusion — that \
|
|
asymmetry is the defect the assemble gate closes"
|
|
);
|
|
let shine = batches.iter().find(|s| refusable(s)).unwrap();
|
|
assert!(shine.env_map, "the shine batch generates its texcoords");
|
|
assert!(shine.no_depth_write, "…carries render flag 0x10");
|
|
assert!(shine.additive, "…and blends additively (blend mode 4)");
|
|
shared += 1;
|
|
}
|
|
assert_eq!(shared, 2);
|
|
}
|
|
|
|
#[test]
|
|
fn a_plain_doodad_draws_every_section_once() {
|
|
let data = benilla_formats::wow_data_or_skip!();
|
|
let mut chain = open_chain(&data).expect("open vanilla patch chain");
|
|
let subs = load_m2_mesh(
|
|
&mut chain,
|
|
"World\\Generic\\Buildings\\HumanTentMedium\\HumanTentMedium.m2",
|
|
)
|
|
.expect("load HumanTentMedium");
|
|
|
|
let mut seen: Vec<Option<u16>> = subs.iter().map(|s| s.section).collect();
|
|
let before = seen.len();
|
|
seen.sort_unstable();
|
|
seen.dedup();
|
|
assert_eq!(
|
|
seen.len(),
|
|
before,
|
|
"the tent draws each of its sections exactly once — nothing here is coplanar with itself"
|
|
);
|
|
}
|