Sam SungandClaude Opus 5.5 5b3c2a98d4 pet bar: PickupPetAction needs the pet in view (#709) ...

`PickupPetAction` lifted a pet action onto the cursor while the pet was out of the client's view, because the pickup gate read an unstreamed pet's missing flags as "not possessed".

The reference's `PickupPetAction` (`0x4be180`) looks the pet up first (`0x4be1f7`). With no object it returns at once (`0x4be1fe`), and only then does it test `UNIT_FLAG_POSSESSED` (`0x4be20a`).

The gate now needs the pet's object before the possessed test, and three comments that cited a mid-instruction address now cite these.

Tests: with the pet out of view, a pickup lifts nothing and a held action stays on the cursor. An in-view pet still lifts, and a possessed one does not.

Fixes #688

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

2026-09-30 11:49:14 +07:00

..

benilla

A dev build of a crate on top of benilla finds its install, benilla-config/ and .probe-identity in its own folder, which its build stamp hands in, not in cargo's checkout of benilla (#504)

2026-09-28 14:55:24 +07:00

benilla-adt

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-app

pet bar: PickupPetAction needs the pet in view (#709)

2026-09-30 11:49:14 +07:00

benilla-assets

String literals in benilla-ui, -world and -formats carry no record numbers (#299)

2026-09-25 17:01:02 +07:00

benilla-blp

String literals in benilla-assets, -blp, -protocol and -srp carry no record numbers (#291)

2026-09-25 16:17:21 +07:00

benilla-buildstamp

A dev build of a crate on top of benilla finds its install, benilla-config/ and .probe-identity in its own folder, which its build stamp hands in, not in cargo's checkout of benilla (#504)

2026-09-28 14:55:24 +07:00

benilla-bytes

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-dbc

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-formats

spell range: two running units get GetMinMaxRange's moving bonus (#702)

2026-09-30 09:59:17 +07:00

benilla-m2

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-mpq

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-protocol

partypetN and raidpetN unit snapshots: the getters read the held pet or its owner's record, UNIT_PET fires with the owner's token, and the stock party pet frame shows (#644)

2026-09-30 00:02:42 +07:00

benilla-srp

String literals in benilla-assets, -blp, -protocol and -srp carry no record numbers (#291)

2026-09-25 16:17:21 +07:00

benilla-ui

pet bar: PickupPetAction needs the pet in view (#709)

2026-09-30 11:49:14 +07:00

benilla-visual

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-wdt

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-wmo

Comments in the small crates: one line of fact each, no history, no record numbers (#93)

2026-09-24 15:51:18 +07:00

benilla-world

doodad anim gate: a meshed host is drawn only while its fade sphere intersects the world camera's frustum, like a meshless one (#633)

2026-09-29 20:35:20 +07:00

benilla-worldview

A dev build of a crate on top of benilla finds its install, benilla-config/ and .probe-identity in its own folder, which its build stamp hands in, not in cargo's checkout of benilla (#504)

2026-09-28 14:55:24 +07:00