benilla-octo

Files

T

andi79h-claude 73f4bf808d The target-of-target rows only write their globals, as 1.12's options do (#2150 )

1.12's options declare Show Target of Target as a bare uvar
(UIOptionsFrame.lua:65) and the mode is read on save
(UIOptionsFrame.lua:365); neither calls TargetofTarget_Update. The frame
follows from TargetFrame_OnUpdate and TargetofTarget_OnUpdate on the next
frame (TargetFrame.lua:492-501). Our rows called it as their applyFunc,
with the row as `this`; the function refreshes `this`'s debuffs
(RefreshBuffs(this, 0, "targettarget"), TargetFrame.lua:538), so with a
target's target up the switch raised "BuffFrame.lua:281: attempt to index
local 'debuffBorder' (a nil value)" (seen on a Linux client).

Verified: the_target_of_target_switch_leaves_the_frame_to_its_own_updates
(with a target's target up: no error, the frame shows after one tick on
and hides after one tick off) fails with the applyFunc put back, with
exactly that error, and passes without it; the options and tot_frame
tests pass on a deDE install; cargo test -p benilla-app --lib 5145,
clippy -D warnings, fmt. Built on macOS only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 4d6f9ecc8a0d99e6d3ecf7fa4a8da229ebad92c2)

2026-10-25 23:26:20 -06:00

addon_harness

ui+app: say what a fired event reached, and whether the UI answered

2026-10-22 20:12:03 -06:00

aura_visual

…

bindings

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

capture

ui+app: the bag walk, the modifier fold, and two shapes the DLL's pool corrected

2026-10-24 09:00:17 -06:00

char_create

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

char_select

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

combat_log

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

combat_text

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

creature_anim

A jump on a moving lift measures its fall in the lift's frame (#1818 )

2026-10-25 23:20:10 -06:00

death

Comments and strings: the passes' leftovers, and a region's template matched as one name (#391 )

2026-09-26 08:57:47 +07:00

debug_panel

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

entities

Survive a net entity despawned before attach's queue is applied

2026-10-22 07:41:59 -06:00

glue

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

loading_screen

…

app: seal a password only if it reads back, and keep tests out of the store

2026-10-24 17:33:26 -06:00

minimap

superwow: TrackUnit/UntrackUnit, and the four chat-bubble CVars

2026-10-25 12:58:31 -06:00

net

A jump on a moving lift measures its fall in the lift's frame (#1818 )

2026-10-25 23:20:10 -06:00

perf

stall: the Linux client watches its own main thread

2026-10-19 08:53:12 -06:00

pipe_warm

pipes: a warm budget is not charged the frame it starts in

2026-10-19 07:59:28 -06:00

player

A jump on a moving lift measures its fall in the lift's frame (#1818 )

2026-10-25 23:20:10 -06:00

portrait

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

post

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

quest_markers

Quest givers streamed in before our own tag are still asked their status (#1455 )

2026-10-25 23:01:49 -06:00

realm_select

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

shaders

Revert "shadow: skin the character caster on the GPU, so a crowd costs no CPU skin"

2026-10-03 17:14:49 +01:00

sound

Sound on Linux skips ALSA's null output when the default fails (#1810 )

2026-10-25 23:18:11 -06:00

spell

app: the press queue was switched off in play — a derived Default is the live config

2026-10-25 09:46:50 -06:00

target

superwow: Clickthrough is live — the last function on the DLL's manifest

2026-10-25 14:17:51 -06:00

textinput

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_action

fixup: #1809 's ClientState path is char_select in this fork

2026-10-25 23:20:10 -06:00

ui_auction

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_bank

npc: the interaction token reaches the VM before the window's own event

2026-10-18 12:05:47 -06:00

ui_chat

The combat log fills deDE's numbered holes, so a German client prints its fights (#1994 )

2026-10-25 23:26:12 -06:00

ui_gossip

npc: the interaction token reaches the VM before the window's own event

2026-10-18 12:05:47 -06:00

ui_guild

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_items

app: nampower's channel latency trim — the last default-on queue row

2026-10-25 00:03:10 -06:00

ui_loot

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_macro

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_mail

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_merchant

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_models

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_party

app: the rest of nampower's CVar table — 49/49, five of them live

2026-10-24 17:19:35 -06:00

ui_pet

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_petition

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_quest

app+ui: the trinket cooldown — and a stock verb that always said "cold"

2026-10-24 10:21:31 -06:00

ui_script

The target-of-target rows only write their globals, as 1.12's options do (#2150 )

2026-10-25 23:26:20 -06:00

ui_social

…

ui_stable

…

ui_taxi

Draw flight masters: C_TaxiMap.GetTaxiNodesForMap over TaxiNodes.dbc

2026-10-22 07:42:22 -06:00

ui_text

ui_text: a font file answers to a family of its own, so no sibling stands in

2026-10-18 11:46:02 -06:00

ui_tooltip

ui: a skill lock you can open stops reading red

2026-10-21 22:17:04 -06:00

ui_trade

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_trainer

GetTrainerServiceInfo answers "" for a rankless service's subText (#1947 )

2026-10-25 23:24:56 -06:00

vplates

…

weapon_trail

…

area_poi.rs

…

area_trigger.rs

…

area.rs

app: publish the world-map feed from the frame's own area

2026-10-23 04:22:49 -06:00

asset_churn.rs

…

aura_visual.rs

…

autologin.rs

app: seal a password only if it reads back, and keep tests out of the store

2026-10-24 17:33:26 -06:00

bindings.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

blob_shadow.rs

Fix TurtleWoW baked NPC atlases (append .blp) plus in-progress GFX work: moonlight, torch depth, water/scene-depth, skybox

2026-10-01 21:40:02 +01:00

bowstring.rs

…

camera_shake.rs

…

challenges.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

character_shadow.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

chat_bubble.rs

superwow: the chat bubbles are widgets — CREATE_CHATBUBBLE and pfUI's skin

2026-10-25 16:11:54 -06:00

chr_classes.rs

…

cinematic.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

console.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

crash.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

creature_anim.rs

creature_anim: SuperWoW's LootSparkle, the sparkle on lootable treasure

2026-10-17 09:04:37 -06:00

credential.rs

app+ui: the nine file and credential verbs, fenced and keyed

2026-10-24 11:30:49 -06:00

cursor.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

cvars.rs

cameraYawSmoothSpeed follows at the stored rate, not the slider's 90-270 (#1712 )

2026-10-25 23:08:58 -06:00

dev.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

doodad_events.rs

…

dynamic_interior.rs

MONKEY (planar water): planar replaces screen-space reflections - the Water Reflections option is gone

2026-10-09 19:06:59 +01:00

entities.rs

corpse: each way a grave can draw no plate now says which one it was

2026-10-17 18:14:17 -06:00

fishing_line.rs

…

footprints.rs

…

game_plugins.rs

superwow: the chat bubbles are widgets — CREATE_CHATBUBBLE and pfUI's skin

2026-10-25 16:11:54 -06:00

game_tip.rs

…

glue_strings.rs

…

go_anim.rs

…

go_templates.rs

gameobject: a template is keyed by the object's own entry, not its guid's bits

2026-10-19 07:59:45 -06:00

gpu_errors.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

hover_log.rs

ui: WOW_UI_PHASES — the UI pass's phase split, windowed

2026-10-20 18:17:01 -06:00

item_persist.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

items.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

lib.rs

A boot with no readable WoW install is fatal, with an error dialog (#1630 )

2026-10-25 23:03:53 -06:00

loading_screen.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

local_state.rs

app+ui: the nine file and credential verbs, fenced and keyed

2026-10-24 11:30:49 -06:00

monkey_gfx.rs

Fix TurtleWoW baked NPC atlases (append .blp) plus in-progress GFX work: moonlight, torch depth, water/scene-depth, skybox

2026-10-01 21:40:02 +01:00

name_persist.rs

…

nameplates.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

names.rs

Comments and strings: the passes' leftovers, and a region's template matched as one name (#391 )

2026-09-26 08:57:47 +07:00

net.rs

app: nampower's channel latency trim — the last default-on queue row

2026-10-25 00:03:10 -06:00

no_install.rs

A boot with no readable WoW install is fatal, with an error dialog (#1630 )

2026-10-25 23:03:53 -06:00

npc_text.rs

…

opaque2d.rs

…

pending_item_ops.rs

…

player.rs

superwow: CastSpellByName at a unit, FoV, NameplateMotion, the raw log

2026-10-25 13:53:40 -06:00

poi_marker.rs

…

preflight.rs

…

probe_shield.rs

…

query_cache.rs

Comments and strings: the passes' leftovers, and a region's template matched as one name (#391 )

2026-09-26 08:57:47 +07:00

raid_marks.rs

…

ranged_flex.rs

…

realmlist.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

run_mode.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

screen_fade.rs

…

screenshot.rs

…

shaders.rs

Revert "shadow: skin the character caster on the GPU, so a crowd costs no CPU skin"

2026-10-03 17:14:49 +01:00

shadow_core.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

shutdown.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

sky_quality.rs

Fix TurtleWoW baked NPC atlases (append .blp) plus in-progress GFX work: moonlight, torch depth, water/scene-depth, skybox

2026-10-01 21:40:02 +01:00

smart_rect.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ssao.rs

Fix TurtleWoW baked NPC atlases (append .blp) plus in-progress GFX work: moonlight, torch depth, water/scene-depth, skybox

2026-10-01 21:40:02 +01:00

swing_refusal.rs

…

test_support.rs

The trainer's ability icon shows its spell tooltip on the first hover (#158 )

2026-09-26 14:41:33 +07:00

text_filter.rs

…

text_reshape.rs

…

torch_shadow.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

transport.rs

…

tutorial.rs

…

ui_aura.rs

ui_aura: another unit's aura durations, learned from the GO that applies them

2026-10-17 07:56:35 -06:00

ui_battlefield_positions.rs

…

ui_battlefield_score.rs

scoreboard: the board dies with the battleground, and the clear reaches the VM

2026-10-02 17:56:00 +01:00

ui_battlefield.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_bind_confirm.rs

…

ui_binder.rs

…

ui_cast_events.rs

app+protocol: nampower's ten cast events, off the queue that already had them

2026-10-24 08:00:19 -06:00

ui_cast.rs

…

ui_char.rs

superwow: the map pair, GetQuestLinkForID, GetWeaponEnchantID

2026-10-25 13:13:38 -06:00

ui_chat.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_chr_classes.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

ui_chr_races.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_craft.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_dialog_verbs.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_dressup.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_duel.rs

…

ui_follow.rs

…

ui_gamma.rs

…

ui_gm_ticket.rs

…

ui_hide.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_honor.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_inspect.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

ui_instance.rs

…

ui_item_text.rs

gameobject: a template is keyed by the object's own entry, not its guid's bits

2026-10-19 07:59:45 -06:00

ui_layout.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_logout.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_loot_roll.rs

A fifth loot roll waits for a frame and opens when one closes (#1458 )

2026-10-25 23:02:28 -06:00

ui_mirror.rs

…

ui_net.rs

…

ui_np_events.rs

app+protocol: nampower's combat-log family — 35 events off one decode

2026-10-24 16:53:28 -06:00

ui_pass.rs

superwow: the chat bubbles are widgets — CREATE_CHATBUBBLE and pfUI's skin

2026-10-25 16:11:54 -06:00

ui_pet_book.rs

ui+app: the bag walk, the modifier fold, and two shapes the DLL's pool corrected

2026-10-24 09:00:17 -06:00

ui_pet_doll.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_pet_stats.rs

…

ui_quest_log.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_quest_share.rs

…

ui_reputation.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_saved.rs

reload: one VM and no flush storm, 615 ms off every rebuild

2026-10-18 14:59:22 -06:00

ui_self_cast.rs

app+ui: nampower's press-interception queue — the half that changes how keys feel

2026-10-24 23:46:42 -06:00

ui_session.rs

npc: the interaction token reaches the VM before the window's own event

2026-10-18 12:05:47 -06:00

ui_shapeshift.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

ui_spellbook.rs

superwow: CastSpellByName at a unit, FoV, NameplateMotion, the raw log

2026-10-25 13:53:40 -06:00

ui_summon.rs

A ghost is dead to the attack check, the action bar, the cast ladder and the cursor (#389 )

2026-09-26 07:23:28 +07:00

ui_tabard.rs

npc: the interaction token reaches the VM before the window's own event

2026-10-18 12:05:47 -06:00

ui_talent_wipe.rs

…

ui_talent.rs

…

ui_tradeskill.rs

ui: a trade-skill list mutator signals inside its own call

2026-10-21 14:47:57 -06:00

ui_unit.rs

unitxp: inSight and behind — four macro conditionals that silently never worked

2026-10-25 17:03:30 -06:00

ui_world_map.rs

classicapi: the last two with data behind them — item sets and area triggers

2026-10-25 18:33:44 -06:00

video.rs

Everwood: the HD/OctoWoW line of benilla, imported onto upstream

2026-10-15 15:01:14 -06:00

volumetric_fog.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

volumetric_light.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

volumetric_light.wgsl

GFX: volumetric light (sun/moon shafts) and moonlight

2026-09-29 17:31:51 +01:00

vplates.rs

unitxp: inSight and behind — four macro conditionals that silently never worked

2026-10-25 17:03:30 -06:00

weapon_trail.rs

…

world_backdrop.rs

…

world_shadow.rs

gates: clippy clean again, and the mail repro that never was for commit

2026-10-18 15:18:10 -06:00

world_state_ui.rs

…

world_state.rs

…

zone_skybox.rs

…