Files
benilla-octo/crates/benilla-ui/src/script/tests/numeric_shape_gate.rs
T
Sam SungandClaude Sonnet 5.5 935b465c76 Button state textures have one shown bit; widget setters take 1.12 forms (#917)
A Button state texture's visibility was kept apart from its region's shown bit, so a script `Show()` on a non-current state texture drew nothing. The bar, thumb and ColorSelect setters took a colour form and accepted arguments the reference rejects, the loader built their textures from `file=` or `<Color>` alone, and a bar texture answered nil to `GetTexCoordModifiesRect`.

In the reference, a region has one shown bit that `Show`, `Hide` and the state switch all write. The setters fork on object, path, nil or usage. The loader builds each widget texture as a full Texture element, and installing a bar texture sets its texcoord flag and gives it all points.

All of these now match: one shown bit, the reference's argument forms, full-element textures with their names and texcoords, and no tint without a bar.

Tests pin each.

Fixes #909
Fixes #908
Fixes #575

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-12 01:21:22 +07:00

71 lines
3.0 KiB
Rust

//! Shape C: a numeric position the reference reads with a bare `lua_tonumber` (`0x6f3620`) and no
//! `lua_isnumber` gate, so nil, a table or a string is 0.0 and the call completes. Shape B, not
//! tested here, is a pre-staged default, such as every colour setter's alpha (1.0 at `0x778220`).
use super::common::script;
#[test]
fn every_shape_c_colour_position_takes_nil_as_zero_and_never_raises() {
let s = script();
s.run(
r#"
F = CreateFrame("Frame", "F")
T = F:CreateTexture(nil, "ARTWORK")
FS = F:CreateFontString(nil, "ARTWORK")
SB = CreateFrame("StatusBar", "SB")
SB:SetStatusBarTexture("bar") -- a bar to tint: with none the call keeps nothing (`0x782dd0`)
CS = CreateFrame("ColorSelect", "CS")
"#,
)
.unwrap();
// `Texture:SetVertexColor 0x79abd0` (`2=C 3=C 4=C`), as stock `QuestLogFrame.lua:337` calls it.
s.run("T:SetVertexColor(nil, nil, nil)")
.expect("SetVertexColor(nil,nil,nil) is three bare lua_tonumbers, not a raise");
s.run(
r#"
local r, g, b = T:GetVertexColor()
assert(r == 0 and g == 0 and b == 0, "a nil channel stores 0.0, it does not keep the old one")
"#,
)
.unwrap();
// A table and a string are 0.0 too: `lua_tonumber` tests nothing.
s.run("T:SetVertexColor({}, \"abc\", true)")
.expect("no tag is rejected at a shape-C position");
// `Texture:SetTexCoord 0x79beb0`: every coordinate C; only the arity raises.
s.run("T:SetTexCoord(nil, nil, nil, nil)")
.expect("four nil coordinates are four zeroes");
s.run("T:SetTexCoord(0, 1, 0, 1, 0, 1, 0, 1)")
.expect("the 8-corner form still takes numbers");
s.run("T:SetTexCoord(1, 2, 3)")
.expect_err("but 3 args is neither 4 nor 8, and the arity DOES raise (0x79bf5d)");
// `FontString:SetShadowColor 0x79dd40` and `StatusBar:SetStatusBarColor 0x78fc20`.
s.run("FS:SetShadowColor(nil, nil, nil)")
.expect("FontString:SetShadowColor is shape C on r/g/b");
s.run("SB:SetStatusBarColor(nil, nil, nil)")
.expect("StatusBar:SetStatusBarColor is shape C on r/g/b");
s.run(
r#"
local r, g, b = SB:GetStatusBarColor()
assert(r == 0 and g == 0 and b == 0, "and it stored the zeroes")
"#,
)
.unwrap();
// `ColorSelect:SetColorRGB 0x78eae0`: C on all three; it fires OnColorSelect either way.
s.run("CS:SetColorRGB(nil, nil, nil)")
.expect("ColorSelect:SetColorRGB is shape C on r/g/b");
// `Texture:SetGradient 0x79ae30` and `SetGradientAlpha 0x79b180`.
s.run("T:SetGradient(\"HORIZONTAL\", nil, nil, nil, nil, nil, nil)")
.expect("SetGradient's six stops are all C");
s.run("T:SetGradientAlpha(\"VERTICAL\", nil, nil, nil, nil, nil, nil, nil, nil)")
.expect("SetGradientAlpha's eight are C/B");
// `FontString:SetTextColor 0x79d9c0`.
s.run("FS:SetTextColor(nil, nil, nil)")
.expect("FontString:SetTextColor is shape C on r/g/b");
}