Mathih13andClaude Opus 5.5 ab909df6d9 fix: TargetUnit("npc") selects the interaction NPC, as 1.12.1 does (#800) ...

`TargetUnit("npc")`, `AssistUnit("npc")` and `SpellTargetUnit("npc")` did nothing with a merchant, gossip or quest window open: the app's unit-token resolver answered nobody for `npc`.

In 1.12.1 the resolver (`0x515970`) matches `npc` as a whole token (`0x515bec`, an unbounded compare, so `npctarget` stays unknown) and takes the interaction NPC's guid `[0xb4e2d0]`, which `0x4930d0` writes when the window opens.

`npc` now resolves to the held unit `InteractNpc` names. Tests cover the three verbs, a closed window and a streamed-out NPC, and `/script TargetUnit("npc")` typed into the stock chat box.

Fixes #707

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

2026-10-05 21:57:08 +07:00

..

extract

EditBox events fire from each box's flush, as 1.12.1 orders them (#734)

2026-10-01 07:38:38 +07:00

action_bar_tests.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

addons.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

bag_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

bagnon_render_tests.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

bank_tests.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

basic_controls_tests.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

battlefield_minimap_tests.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

battlefield_tests.rs

The battleground queue slots answer "none" from the first frame, so a party login no longer breaks BattlefieldFrame_Update (#603)

2026-09-29 15:53:20 +07:00

binder_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

bottom_hud_tests.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

buff_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

cast_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

character_tests.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

chat_options_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

chat_resize_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

chat_tests.rs

fix: TargetUnit("npc") selects the interaction NPC, as 1.12.1 does (#800)

2026-10-05 21:57:08 +07:00

cinematic_tests.rs

Keys are named by the active layout, as 1.12.1 names them (#748)

2026-10-01 09:55:26 +07:00

color_picker_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

combat_text_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

combo_frame_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

content.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

death_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

delete_item_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

dressup_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

dropdown_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

duel_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

durability_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

enchant_confirm_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

errors_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

escape_tests.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

event_shape_gate.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

exp_bar_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

fade_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

faux_scroll_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

frame_flag_gate.rs

The core loads the stock GameMenuFrame.xml, and the layer reshapes it in place into benilla's menu, keeping every stock rung in the chain anchored TOP (#564)

2026-09-28 22:01:24 +07:00

friends_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

game_menu_addon_tests.rs

The core loads the stock GameMenuFrame.xml, and the layer reshapes it in place into benilla's menu, keeping every stock rung in the chain anchored TOP (#564)

2026-09-28 22:01:24 +07:00

game_menu_tests.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

gate.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

group_loot_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

guild_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

help_frame_tests.rs

EditBox caret keys, selection and focus blink follow 1.12.1 (#750)

2026-10-01 10:56:03 +07:00

honor_frame_tests.rs

unit tokens: party1target and other target chains resolve (#706)

2026-09-30 10:20:16 +07:00

input.rs

EditBox caret keys, selection and focus blink follow 1.12.1 (#750)

2026-10-01 10:56:03 +07:00

inspect_tests.rs

unit tokens: party1target and other target chains resolve (#706)

2026-09-30 10:20:16 +07:00

instance_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

keybindings_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

layer_tests.rs

EditBox events fire from each box's flush, as 1.12.1 orders them (#734)

2026-10-01 07:38:38 +07:00

lifecycle.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

load_log.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

loot_tests.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

macro_tests.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

manifest.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

merchant_tests.rs

fix: stop shift-click opening the stack splitter on vendor bundles (#751)

2026-10-02 04:54:20 +07:00

micro_menu_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

minimap_tests.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

mirror_timer_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

mod.rs

fix: TargetUnit("npc") selects the interaction NPC, as 1.12.1 does (#800)

2026-10-05 21:57:08 +07:00

money_frame_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

multibar_stance_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

options_tests.rs

fix: overhead names carry the player's PvP title, as 1.12.1 does (#792)

2026-10-04 11:04:32 +07:00

panel_template_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

panel_tests.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

perf_bar_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

pet_bar_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

pet_frame_tests.rs

UnitCreatureType answers the one resolver's type for every unit, so a cat-form druid or a Ghost Wolf shaman is a Beast: the snapshot takes the form, then the template, then the race (0x605570, 0x51a2bc) (#681)

2026-09-30 06:20:12 +07:00

pet_paperdoll_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

pet_stable_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

petition_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

quest_share_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

quest_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

quest_timer_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

questlog_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

quiver_tests.rs

Unit aura bindings resolve their token as 1.12.1 does, so mouseover, party1target and any casing read the unit they name (#497)

2026-09-28 12:46:33 +07:00

raid_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

reference_ui.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

reputation_frame_tests.rs

Comments and strings: the passes' leftovers, and a region's template matched as one name (#391)

2026-09-26 08:57:47 +07:00

resolve_bench.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

screenshot_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

session.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

shape_gate.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

shipped_xml_tests.rs

benilla's layer speaks the 1.12 API alone: handlers take this and no arguments, GetBinding answers the 1.12 list, the Key Bindings page captures through its window, /errors chains the error handler, and the host hooks leave the VM (#569)

2026-09-29 00:12:27 +07:00

skills_frame_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

spellbook_tests.rs

CastSpellByName's onSelf and CastSpell's third argument cast the spell at the player, the pet book's at the player too, read through GetBoolOrDefault as the reference does (#634)

2026-09-29 21:11:47 +07:00

static_popup_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

summon_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

surface_gate.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

tabard_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

talent_wipe_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

target_aura_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

taxi_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

test_ui.rs

fix: close a loot window that opens while you move, as 1.12.1 does (#786)

2026-10-03 17:36:21 +07:00

tooltip_anchor_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

tooltip_compare_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

tooltip_template_tests.rs

Comments in benilla-app, the UI script layer: one line of fact each, no history, no record numbers (#184)

2026-09-25 08:20:21 +07:00

tot_frame_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

trainer_tests.rs

/errors: put Clear and Close in the panel art's sockets (#720)

2026-09-30 15:31:35 +07:00

tutorial_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

ui_menu_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

uiparent_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

unit_frame_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

unit_popup_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

verb_event_gate.rs

String literals and test names in benilla-app carry no record numbers (#368)

2026-09-26 01:06:28 +07:00

video_options_tests.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

world_entry_tests.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

world_map_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

world_state_tests.rs

The core loads the player's own FrameXML.toc in its order, and the boot VM loads no Fonts.xml (#568)

2026-09-28 23:52:14 +07:00

zone_text_tests.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00