Both clusters left after the chat-window shadow were stale numbers written into
tests rather than anything of ours, and both are stale because the realm's
FrameXML moved — which is the thing to suspect first in this crate.
Seven in `battlefield_minimap_tests`: the manifest was expected to warn exactly
once, about `gxRefresh`. This client does not register that CVar because no
target offers the exclusive mode-set a refresh rate needs, and the only reader
was stock `OptionsFrame.lua`'s `OptionsFrameRefreshDropDown_OnLoad` — which the
realm replaced with a rewrite that has no refresh-rate dropdown at all: three
mentions of the CVar in `patch.MPQ`'s stock copy, none in `patch-4.mpq`'s. The
list is now empty rather than gone, so a realm that restores the stock window
brings the row back and that is where it shows.
Five in `questlog_tests`, from three separate numbers in the one file:
`"Quests: 8/20"` — the realm sets `MAX_QUESTLOG_QUESTS = 25`, and this file had
already learned that once: another test reads the cap off the global with a
comment saying why. This call site had been missed, so it is read the same way.
A wheel notch was asserted to scroll the list, with eight fixture quests
described as "two more than the list shows". The realm shows
`QUESTS_DISPLAYED = 24` where 1.12 shows six, so eight fit with room to spare and
the notch had nothing to move — the `assert_ne!` was passing only while the row
count read as six, which is to say it stopped testing anything a while ago. The
log is re-seated past the window for that leg, sized off the live global, and put
back to the eight the rest of the test reads.
And `frame_rect(quads, 300.0, 261.0)` / `(384.0, 512.0)` hunted the quad list for
a bare frame of a given size, which is a number the realm can change and did.
`named_rect` asks the frame where it is instead. Nothing any of those tests
asserts was ever about the size: they clip reward plates and text against the
pane and compare the window's own edges.
269 → 160, still nothing newly failing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SgstFWtn1RxEJ5kVrpgYwn
gromandClaude Opus 5
b39d901257