Sam SungandClaude Opus 5.5
f98c1a5396
Part of #41: the last of five `benilla-app` pieces. This one is everything the others did not cover: the addon harness, the settings registry, the glue screens (login, realm list, character select and create), key bindings, the minimap, nameplates, the loading screen, transports, the performance instruments, the smaller modules, the integration tests, and the UI asset files (`OptionsFrame.xml`, `benilla.toc` and the rest). Their comments are rewritten to the rule in `docs/METHOD.md`, which is what the code does and the reference fact behind it, in a line. 27,351 comment lines become 11,010. Fixes #33. Fixes #103. - **The mechanical strip.** The citations that were only a private record number go first, and each edit is shown to be a pure removal. - **Wrong facts corrected.** The rewrite corrects the comments that stated wrong facts. Among them: - The weapon trail's emissive is 0 (`0x70ca30`): the trail is a type-5 render record, so its ambient-only light term is exact. - The camera-style dropdown writes "1", "2", "0" (`UIOptionsFrame.lua:525,536,547`); several register-site addresses in the settings table are corrected. - The graphics settings are held until `RestartGx`, as in 1.12; `Fonts.xml`'s early load no longer carries a false reason. - vmangos sends a player-name invalidation after a rename (`CharacterHandler.cpp:839`), and the cinematic camera's announce packet has an empty handler there (`MiscHandler.cpp:919`). - Stock FrameXML and GlueXML line citations are checked against the stock 1.12 files, and vmangos line citations against the pinned revision. - **Deviation labels.** "Deviation:" now marks only a choice with its recorded reason. Declining to copy a reference defect is stated plainly, and so is an unbuilt behaviour or an untraced one. - **Verification.** Every file strips to identical code, apart from test literals in `login/`, `death/` and `ui_script/death_tests.rs` that now use placeholder account and character names, and `cargo fmt --check` is clean. Six second readers compared every file old against new, restored the facts the rewrite had dropped, and checked each new citation against the code, the stock files, vmangos and the reference. A second commit corrects one comment in `benilla-ui` (`unit_is_grey`: the reference's exclusion is players only). A third lowers `ui_script_wall`'s ceiling from 45 to 40: five gameplay files named `UiScript` only in comments the rewrite removed, and the ratchet asks for the number to follow. Behaviour differences the rewrite surfaced are filed as their own issues (#339 to #353 among them). String literals are untouched; they are #92. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
99 lines
4.6 KiB
TOML
99 lines
4.6 KiB
TOML
[package]
|
|
name = "benilla-app"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
license.workspace = true
|
|
description = "The Bevy app as a library: everything but the build-id stamp, which lives in the `benilla` launcher so a new commit does not rebuild this crate"
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[features]
|
|
# `dev` compiles in the instruments; the player build (`scripts/gates.sh`) has no defaults.
|
|
default = ["dev"]
|
|
# The asset, format and world crates default `dev` on, so they come in without it, forwarded here.
|
|
dev = ["benilla-assets/dev", "benilla-formats/dev", "benilla-world/dev", "dep:bevy_egui"]
|
|
tracy = ["bevy/trace_tracy"]
|
|
# Writes every system's per-run span to `trace-<ts>.json` in the cwd.
|
|
trace_chrome = ["bevy/trace_chrome"]
|
|
|
|
[dependencies]
|
|
anyhow.workspace = true
|
|
# The EditBox clipboard, on the main thread as NSPasteboard requires; bevy_egui's 3.x.
|
|
arboard = "3"
|
|
benilla-ui = { path = "../benilla-ui" }
|
|
bevy.workspace = true
|
|
wgpu.workspace = true
|
|
bevy_egui = { version = "0.39", optional = true }
|
|
bytemuck = { version = "1", features = ["derive"] }
|
|
# `f16` decode for the `WOW_BOOTH_DUMP` dump of the `Rgba16Float` booth targets.
|
|
half = "2"
|
|
# Compiles `assets/ui` into the binary, so the interface loads on a machine without the source.
|
|
include_dir = "0.7"
|
|
# The 1.12 chat filters (`text_filter`), with one `RegexSet` for the any-match pass per line.
|
|
regex = "1"
|
|
# `getrusage` for perf CPU time; the audio clock and render thread's realtime policy on macOS.
|
|
libc = "0.2"
|
|
# PNG encoding only: the macOS cursor's NSImage data and screenshots.
|
|
image = { version = "0.25", default-features = false, features = ["png"] }
|
|
# Thread-to-ECS channels: crossbeam's `Receiver` is `Sync`, so it is a resource without a mutex.
|
|
crossbeam-channel = "0.5"
|
|
benilla-assets = { path = "../benilla-assets", default-features = false }
|
|
benilla-formats = { path = "../benilla-formats", default-features = false }
|
|
benilla-protocol = { path = "../benilla-protocol" }
|
|
benilla-world = { path = "../benilla-world", default-features = false }
|
|
# The CVar diff persisted in `benilla-config/config.toml`.
|
|
serde = { version = "1", features = ["derive"] }
|
|
toml = "0.8"
|
|
# Collision for our kinematic character controller; 0.6 targets Bevy 0.18, 0.7 moves to 0.19.
|
|
avian3d = "0.6"
|
|
# Shapes and rasterizes `FontString` text standalone (`ui_text`), at bevy_text's own 0.16.
|
|
cosmic-text = "0.16"
|
|
# `cosmic-text`'s font database, named by `ui_text`; must stay the version it depends on.
|
|
fontdb = "0.23"
|
|
# The mixer. Its `cpal` backend stays off on every target: `sound::output` is our own backend.
|
|
kira = { version = "0.12", default-features = false, features = ["mp3", "wav", "pcm", "adpcm"] }
|
|
# Aborts a debug build on an allocation in the audio IO callback or render pass; off in release.
|
|
assert_no_alloc = "1.1"
|
|
# `MediaSource`: our source raises kira's decode thread's QoS; must stay kira's version.
|
|
symphonia = { version = "0.5", default-features = false }
|
|
# The audio threads' lock-free SPSC rings (output, mix tap); kira's version, so the graph has one.
|
|
rtrb = "0.3"
|
|
mint = "0.5"
|
|
# The gossip greeting's weighted draw, re-rolled per open as in the reference.
|
|
rand = "0.8"
|
|
|
|
# Wayland clipboard over the standard `wl_data_device`; arboard's speaks `wlr-data-control`,
|
|
# which GNOME does not implement.
|
|
[target.'cfg(all(unix, not(any(target_os = "macos", target_os = "android"))))'.dependencies]
|
|
raw-window-handle = "0.6"
|
|
smithay-clipboard = "0.7"
|
|
|
|
# A native NSCursor: winit's cursor rects revert to the arrow under a continuous render loop.
|
|
[target.'cfg(target_os = "macos")'.dependencies]
|
|
# The audio device layer (`sound::output::coreaudio`), at the versions and features cpal uses.
|
|
coreaudio-rs = { version = "0.13", default-features = false, features = ["audio_unit", "core_audio"] }
|
|
objc2-core-audio = { version = "0.3", default-features = false, features = ["std", "AudioHardware"] }
|
|
objc2-core-audio-types = { version = "0.3", default-features = false, features = ["std", "CoreAudioBaseTypes"] }
|
|
objc2 = "0.5"
|
|
objc2-app-kit = { version = "0.2", features = [
|
|
"NSApplication",
|
|
"NSResponder",
|
|
"NSRunningApplication",
|
|
"NSWindow",
|
|
"NSView",
|
|
"NSImage",
|
|
"NSCursor",
|
|
"NSEvent",
|
|
] }
|
|
objc2-foundation = { version = "0.2", features = ["NSArray", "NSData", "NSGeometry"] }
|
|
|
|
# The audio device layer off macOS (`sound::output::cpal`); on macOS cpal cannot rebuild on a
|
|
# lost default device and drops the IO-cycle timestamp.
|
|
[target.'cfg(not(target_os = "macos"))'.dependencies]
|
|
cpal = "0.17"
|
|
|
|
# Windows CPU clocks for `perf::clock`.
|
|
[target.'cfg(windows)'.dependencies]
|
|
windows-sys = { version = "0.59", features = ["Win32_Foundation", "Win32_System_Threading"] }
|