Sam SungandClaude Opus 5.5 c2fc3cf304 OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842) ...

Show and hide propagated a whole subtree first, then fired from a snapshot, parent first: a parent's `OnShow` ran before its children's, and a child hidden by an earlier handler still got its `OnShow`. A frame visible at the end of its load got no `OnShow` at all.

In 1.12.1 show `0x76ae10` and hide `0x76ad50` mark the frame, walk the live child list re-checking each child's gate, and fire the frame's own handler last (`0x76aef5`, `0x76adfd`). The post-load hook fires `OnShow` after `OnLoad` for a visible frame (`0x76a3b3`), from XML and `CreateFrame` alike.

Now handlers run inside a live post-order walk, and the post-load `OnShow` fires. Tests cover the order, a sibling hidden mid-walk, and one or two `OnShow`s after a load; they fail without the fix. Four existing tests' expected orders flip to the reference's.

Fixes #350
Fixes #59

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-09 13:44:15 +07:00

..

aura

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

cursor

pet bar: PickupPetAction needs the pet in view (#709)

2026-09-30 11:49:14 +07:00

editbox

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

lua50

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

messageframe

A multi-line EditBox grows with its text; a Lua-made box draws its text (#729)

2026-09-30 18:37:30 +07:00

object

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

pvp

Unit tooltips title the unit with its PvP name, as 1.12.1 does (#802)

2026-10-05 22:08:33 +07:00

region

A multi-line EditBox grows with its text; a Lua-made box draws its text (#729)

2026-09-30 18:37:30 +07:00

simplehtml

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

tests

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

tooltip

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

tooltip_item

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

tradeskill

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

trainer

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

unit

The quest log counts party members on each quest, as 1.12.1 does (#824)

2026-10-08 08:09:41 +07:00

action_bar_toggles.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

action.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

addon_enable.rs

Logout and the AddOns screen's Okay write only a changed character's own enable rows, so a character with no row keeps following the realm's others (#418) (#490)

2026-09-28 10:11:40 +07:00

addon_gate.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

addon_message.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

addon.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

auction.rs

GetAuctionItemInfo names the bidder on the player's own owner-list auctions, nil until the name lands, and 1 or nil on every other row (#259) (#492)

2026-09-28 11:40:53 +07:00

backdrop.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

bank.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

battlefield_positions.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

battlefield_queue.rs

The battleground queue slots answer "none" from the first frame, so a party login no longer breaks BattlefieldFrame_Update (#603)

2026-09-29 15:53:20 +07:00

battlefield_score.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

bind_confirm.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

binder.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

binding_abi.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

button.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

calls.rs

CastSpellByName's onSelf and CastSpell's third argument cast the spell at the player, the pet book's at the player too, read through GetBoolOrDefault as the reference does (#634)

2026-09-29 21:11:47 +07:00

camera_view.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

channel.rs

String literals in benilla-ui, -world and -formats carry no record numbers (#299)

2026-09-25 17:01:02 +07:00

char_stats.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

chat_misc.rs

/wave <name> targets the named player; two DoEmote gates follow 1.12.1 (#769)

2026-10-02 09:23:08 +07:00

chat_send.rs

SendChatMessage sends nothing for an empty line unless its type is AFK or DND, checked after the chat type as 1.12.1 does (#499) (#505)

2026-09-28 15:09:27 +07:00

chat_types.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

chat_window.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

client.rs

The stock video options window opens, saves, restores defaults and cancels clean: its CVars are registered, spellEffectLevel drives the particle and shard rates, and the video pairs, frame enumeration and client queries are defined (#565)

2026-09-28 22:12:45 +07:00

clip.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

clock.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

colorselect.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

container.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

craft.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

cursor.rs

unit getters: chained tokens like raid3target answer their unit (#716)

2026-09-30 13:19:48 +07:00

cvars.rs

The nameplate verbs write two runtime bits, cleared at world entry, and the setting lives in FrameXML's saved variables, not two CVars (#571)

2026-09-29 01:21:17 +07:00

death.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

diagnostics.rs

The stock video window's boxes are registered and ffx, ffxGlow, ffxDeath and gxMaximize work; benilla's options gain Spell Detail; load failures go to FrameXML.log (#585)

2026-09-29 10:09:02 +07:00

dialog_verbs.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

dressup.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

duel.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

editbox.rs

EditBox caret keys, selection and focus blink follow 1.12.1 (#750)

2026-10-01 10:56:03 +07:00

event.rs

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

extract.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

follow.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

font_block.rs

A multi-line EditBox grows with its text; a Lua-made box draws its text (#729)

2026-09-30 18:37:30 +07:00

font.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

frame_enum.rs

The stock video options window opens, saves, restores defaults and cancels clean: its CVars are registered, spellEffectLevel drives the particle and shard rates, and the video pairs, frame enumeration and client queries are defined (#565)

2026-09-28 22:12:45 +07:00

gm_ticket.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

gossip.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

guild.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

handler_prof.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

input_verbs.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

inspect.rs

unit tokens: party1target and other target chains resolve (#706)

2026-09-30 10:20:16 +07:00

instance.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

inventory_verbs.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

item_stats.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

item_text.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

keybind.rs

The core loads the chain's Bindings.xml and DefaultBindings.wtf, and every command runs its stock body (#587)

2026-09-29 10:51:21 +07:00

keyboard.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

layout_cache.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

layout.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

loot_roll.rs

vmangos citations read in one revision, vmangos core 6b34a36 (#289)

2026-09-25 15:55:32 +07:00

loot.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

lua50.rs

String literals in benilla-ui, -world and -formats carry no record numbers (#299)

2026-09-25 17:01:02 +07:00

macros.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

mail.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

measure.rs

EditBox events fire from each box's flush, as 1.12.1 orders them (#734)

2026-10-01 07:38:38 +07:00

merchant.rs

fix: stop shift-click opening the stack splitter on vendor bundles (#751)

2026-10-02 04:54:20 +07:00

minimap.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

mod.rs

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

model.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

modelframe.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

nameplate.rs

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

net_stats.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

object.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

party.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

pet.rs

pet bar: PickupPetAction needs the pet in view (#709)

2026-09-30 11:49:14 +07:00

petition.rs

The fourteen missing 1.12.1 functions are defined, the keyring hover runs the stock path, and the stock CloseAllBags keeps a backpack that was open (#581)

2026-09-29 03:19:56 +07:00

pointer.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

quest_log.rs

The quest log counts party members on each quest, as 1.12.1 does (#824)

2026-10-08 08:09:41 +07:00

quest.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

region_map.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

region.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

reputation.rs

Comments and strings: the passes' leftovers, and a region's template matched as one name (#391)

2026-09-26 08:57:47 +07:00

saved.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

screenshot.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

scrollframe.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

session.rs

PLAYER_LOGIN fires at world entry, once the player exists (#840)

2026-10-09 11:38:06 +07:00

shapeshift.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

skills.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

slash.rs

benilla's layer speaks the 1.12 API alone: handlers take this and no arguments, GetBinding answers the 1.12 list, the Key Bindings page captures through its window, /errors chains the error handler, and the host hooks leave the VM (#569)

2026-09-29 00:12:27 +07:00

slider.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

social.rs

benilla-ui: unused globals and queues removed, one true/nil helper, three tests that test their claim (#305)

2026-09-25 17:26:43 +07:00

sound.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

spellbook.rs

Return numeric flags from spell-targeting predicates (#764)

2026-10-02 13:45:16 +07:00

stable.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

statusbar.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

stdlib.rs

The host's clock, zone texts, game clock and error-handler slot leave _G, and the getters over them answer the reference's shapes (#580)

2026-09-29 02:30:40 +07:00

summon.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

surface.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

tabard.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

talent.rs

The pet bar's, pet book's and pet-learn trainer's spell tooltips are built against the pet: its level scales the per-level terms, cost and cast time, and its base mana is the percentage cost's basis (#606)

2026-09-29 16:31:47 +07:00

taxi.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

tick.rs

EditBox events fire from each box's flush, as 1.12.1 orders them (#734)

2026-10-01 07:38:38 +07:00

tooltip_spell.rs

The pet bar's, pet book's and pet-learn trainer's spell tooltips are built against the pet: its level scales the per-level terms, cost and cast time, and its base mana is the percentage cost's basis (#606)

2026-09-29 16:31:47 +07:00

tooltip_unit.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

trade.rs

The VM speaks 1.12 alone: the Era globals and the uncalled hooks are gone, the engine's tooltip seams are Rust calls, strata/draw-layer/state-texture/sound/OnClick/quest-item/pickup take their 1.12 shapes, and the surface gate covers the production load (#573)

2026-09-29 01:44:52 +07:00

tutorial.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

types.rs

A multi-line EditBox grows with its text; a Lua-made box draws its text (#729)

2026-09-30 18:37:30 +07:00

ui_errors.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

ui_scale.rs

The UI scale is UIParent's own scale over a 768-unit root (#841)

2026-10-09 13:17:23 +07:00

video_pairs.rs

The stock video options window opens, saves, restores defaults and cancels clean: its CVars are registered, spellEffectLevel drives the particle and shard rates, and the video pairs, frame enumeration and client queries are defined (#565)

2026-09-28 22:12:45 +07:00

visibility.rs

OnShow and OnHide fire children first, and after OnLoad, as in 1.12.1 (#842)

2026-10-09 13:44:15 +07:00

weapon_enchant.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

who_sort.rs

who_sort: the class, race and zone arms order a miss after every resolved name and tie two misses, a total order sort_by can take (#626)

2026-09-29 19:08:28 +07:00

worldmap_arrow.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

worldmap.rs

WORLD_MAP_UPDATE fires inside the verb that moves the map, as in 1.12.1 (#829)

2026-10-08 11:24:25 +07:00

worldstate.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

worn_display.rs

Comments in benilla-ui: one line of fact each, no history, no record numbers (#143)

2026-09-25 01:58:49 +07:00

zone_text.rs

Zone names stay uncoloured on PvE realms outside capitals, as in 1.12.1 (#825)

2026-10-08 08:53:16 +07:00