Sam SungandClaude Opus 5.5
8952d590e6
Comments that pointed into the maintainer's private reverse-engineering notes (a note by name, a path, a section or finding id, the analysis's own name for a client function, a process word) now carry the fact itself, cited by the reference client's address, by vmangos file and line, or as "the reference". Nobody outside could follow those pointers. Comment text only, plus the test-assert and log strings that carried the same pointers. No claim changes: a comment the notes have since corrected keeps its wording here, and correcting it is separate work. The two reference generators, `scripts/gen-reference-globals.py` and `scripts/gen-reference-verb-events.py`, named the private notes' layout to find their inputs. They now take the input files as arguments (`--capture`, `--framexml`, `--names`, `--extents`, `--disasm`). Run on the same inputs, both write the committed tables row for row; only the two header lines that named the old environment variable change. Checked per file: - the code is identical: each file with its comments stripped compares equal before and after; a changed string literal is compared under a mask that proves only literal text moved and every literal kept its line count; - no client address the old text cited was dropped; - a second reviewer checked every added address against its derivation; - a detector for the notes' names, paths, ids, function names and process words finds none left; - `scripts/gates.sh` is green. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
85 lines
3.2 KiB
Rust
85 lines
3.2 KiB
Rust
//! Session probe: which bones carry keys in a given sequence — `cargo run -p benilla-formats
|
|
//! --example dump_bone_keys <file.m2> <anim_id> [bone ...]`. With bone indices, prints their
|
|
//! key counts + first rotation keys; without, lists every keyed bone. Extract the file first
|
|
//! via `mpqx` (benilla-mpq). Built for the nocked-ammo investigation (decision 2273 follow-up).
|
|
|
|
fn main() {
|
|
let mut args = std::env::args().skip(1);
|
|
let path = args
|
|
.next()
|
|
.expect("usage: dump_bone_keys <file.m2> <anim_id> [bone ...]");
|
|
let anim_id: u16 = args.next().expect("anim id").parse().expect("anim id u16");
|
|
let bones: Vec<u16> = args.map(|a| a.parse().expect("bone index u16")).collect();
|
|
let bytes = std::fs::read(&path).expect("read m2");
|
|
if let Some(a) = benilla_formats::parse_m2_string_anchors(&bytes) {
|
|
println!(
|
|
"string anchors: top bone {} ({:+.3},{:+.3},{:+.3}) bottom bone {} ({:+.3},{:+.3},{:+.3})",
|
|
a.top.0, a.top.1[0], a.top.1[1], a.top.1[2], a.bottom.0, a.bottom.1[0], a.bottom.1[1], a.bottom.1[2]
|
|
);
|
|
}
|
|
// anim_id 65535 = list every sequence (id/duration/looping + keyed-bone count only).
|
|
for a in benilla_formats::parse_m2_animations(&bytes) {
|
|
if anim_id == u16::MAX {
|
|
println!(
|
|
"anim {} dur {:.3}s looping {} — {} keyed bones",
|
|
a.anim_id,
|
|
a.duration,
|
|
a.looping,
|
|
a.bones.len()
|
|
);
|
|
continue;
|
|
}
|
|
if a.anim_id != anim_id {
|
|
continue;
|
|
}
|
|
println!(
|
|
"anim {} dur {:.3}s looping {} — {} keyed bones",
|
|
a.anim_id,
|
|
a.duration,
|
|
a.looping,
|
|
a.bones.len()
|
|
);
|
|
for e in &a.events {
|
|
println!(
|
|
" event {} t={:.3} data {}",
|
|
String::from_utf8_lossy(&e.ident),
|
|
e.time,
|
|
e.data
|
|
);
|
|
}
|
|
for bk in &a.bones {
|
|
if !bones.is_empty() && !bones.contains(&bk.bone) {
|
|
continue;
|
|
}
|
|
println!(
|
|
" bone {:3}: {} trans, {} rot, {} scale keys",
|
|
bk.bone,
|
|
bk.translation.len(),
|
|
bk.rotation.len(),
|
|
bk.scale.len()
|
|
);
|
|
for (t, q) in bk.rotation.iter().take(3) {
|
|
println!(
|
|
" rot t={t:.3} q=({:+.3},{:+.3},{:+.3},{:+.3})",
|
|
q[0], q[1], q[2], q[3]
|
|
);
|
|
}
|
|
// T/S values too, not just counts — for a flare or a rise the VALUES are the
|
|
// effect (the gseqdump lesson, here for sequence keys), and per-axis (non-)uniformity
|
|
// of a scale key is load-bearing for the billboard law's per-axis preserve.
|
|
for (t, v) in bk.translation.iter().take(8) {
|
|
println!(
|
|
" trans t={t:.3} ({:+.3},{:+.3},{:+.3})",
|
|
v[0], v[1], v[2]
|
|
);
|
|
}
|
|
for (t, v) in bk.scale.iter().take(8) {
|
|
println!(
|
|
" scale t={t:.3} ({:+.3},{:+.3},{:+.3})",
|
|
v[0], v[1], v[2]
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|