Files
CawDPSMeterandClaude Sonnet 5.5 1356decd66 Count damage shield (reflect) damage in combat-text mode
Thorns, Retribution Aura and item effects log 'You reflect N School damage to X.'
or 'Y reflects ...' without a spell name. These lines fell through to the unknown
bucket, so the damage was never counted. Parse them, credit the shield owner or
the owner's pet as 'Damage Shield (School)', and keep ignoring enemy shields,
players outside the roster, friendly targets and DPSLog sessions (which report
DAMAGE_SHIELD themselves). A text fallback covers unrecognised event names.

Reported by worldofwarcraftman. Adds 15 regression checks.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-25 05:18:02 +01:00

56 lines
3.2 KiB
Python

"""Behavioral checks with a mocked WoW UI and Lua 5.1 via Lupa.
Only legacy `for k,v in table do` is adapted in memory for the test VM.
The shipped Lua files stay Lua 5.0 source. This is not a client smoke test.
Install lupa in your Python environment, or in %TEMP%/caw-review-lupa.
"""
from pathlib import Path
import os
import re
import sys
sys.path.insert(0, str(Path(os.environ.get('TEMP', '/tmp')) / 'caw-review-lupa'))
from lupa.lua51 import LuaRuntime
ROOT = Path(__file__).resolve().parents[1]
ADDON_ROOT = Path(os.environ.get('CAW_TEST_ADDON_ROOT', ROOT))
lua = LuaRuntime(unpack_returned_tuples=True)
lua.execute((ROOT / 'tests/mock_wow.lua').read_text(encoding='utf-8'))
for name in ('CawDiagnostics.lua', 'CawHeader.lua', 'CawDPSMeter.lua', 'CawTargets.lua', 'CawTargetSync.lua', 'CawDPSLog.lua', 'CawSpellIcons.lua', 'CawThreat.lua', 'CawThreatSync.lua', 'CawTalentSync.lua',
'CawThreatCalibration.lua', 'CawServerThreat.lua', 'CawDiagnosticsCommands.lua', 'CawPfUI.lua', 'CawUI.lua', 'CawTalentView.lua', 'CawBreakdown.lua'):
code = (ADDON_ROOT / name).read_text(encoding='utf-8')
code = re.sub(r'\b(for\s+\w+(?:\s*,\s*\w+)*\s+in\s+)([\w.]+(?:\[[^\]\n]+\])?)\s+do\b',
r'\1pairs(\2) do', code)
lua.execute(code, name=name)
lua.execute((ROOT / 'tests/regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/ui_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/ui_release_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/threat_alert_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/parser_control_regressions.lua').read_text(encoding='utf-8'))
private = ADDON_ROOT / 'CawLocalSyncStatus.lua'
if private.exists():
lua.execute(private.read_text(encoding='utf-8'), name=private.name)
lua.execute((ROOT / 'tests/local_ui_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/window_customization_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/appearance_regressions.lua').read_text(encoding='utf-8-sig'))
lua.execute((ROOT / 'tests/settings_usability_regressions.lua').read_text(encoding='utf-8-sig'))
lua.execute((ROOT / 'tests/settings_popup_regressions.lua').read_text(encoding='utf-8-sig'))
lua.execute((ROOT / 'tests/display_performance_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/segment_timestamp_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/overheal_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/target_breakdown_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/data_source_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/window_state_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/community_feedback_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/threat_retry_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/always_show_me_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/threat_order_regressions.lua').read_text(encoding='utf-8'))
lua.execute((ROOT / 'tests/reflect_regressions.lua').read_text(encoding='utf-8'))