mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 16:10:36 +00:00
feat(ui): Lua error window replaces the stock error box
The Lua error window (/luaerrors) moves from the load-on-demand ClassicAPI_DebugTools into !!!ClassicAPI and becomes the client's error display. Each error opens it with the message, time, count and stack, and the arrows page through every error so far. 1.12.1's error handler is FrameXML's _ERRORMESSAGE (BasicControls.xml). It reports an error as ScriptErrors_Message:SetText(message) and then ScriptErrors:Show(), and only while the stock box is hidden. The window's OnLoad takes those two slots, the same two !BugGrabber 2.1.1 takes: SetText records the error and Show does nothing, so the stock box stays hidden and every error arrives. Errors still pass through the handler first, so: - !BugGrabber loads after !!!ClassicAPI and takes the slots back. BugSack gets the errors and the window does not open. - An addon that calls seterrorhandler (pfUI) replaces _ERRORMESSAGE, so neither shows. One that wraps the old handler still ends here. The engine's error function (0x00703B40) is C. It runs at the point of the error, before the stack unwinds, and calls the registered handler. From the SetText slot, level 1 is the slot, 2 is _ERRORMESSAGE, 3 is that C function and 4 is the code that failed, so the stack starts at debugstack(4), the level !BugGrabber's GrabError reads from the same slot. The text is ClassicAPI's ScrollingEditBoxTemplate with a MinimalScrollBar. The bottom row has Reload UI, arrows that wrap around the index label, and Close. /luaerrors opens or closes the window and /luaerrors clear empties it; the old on/off handler install is gone. Not tested in game yet.
This commit is contained in:
@@ -12,7 +12,6 @@
|
||||
-- FrameStackTooltip section).
|
||||
-- * No UIPanelDialogTemplate, no clampedToScreen, no
|
||||
-- OnSizeChanged in vanilla -- frames have fixed dimensions.
|
||||
-- * No debuglocals
|
||||
--
|
||||
-- UX additions cherry-picked from modern Blizzard_EventTrace
|
||||
-- (10.x+, anniversary _classic_era_):
|
||||
@@ -40,7 +39,6 @@ EVENT_TRACE_MAX_ENTRIES = 1000;
|
||||
EVENT_TRACE_NUM_BUTTONS = 26;
|
||||
EVENT_TRACE_FRAME_HEIGHT = (EVENT_TRACE_NUM_BUTTONS * EVENT_TRACE_EVENT_HEIGHT) + 68;
|
||||
|
||||
DEBUGLOCALS_LEVEL = 4;
|
||||
local _normalFontColor = { 1, .82, 0, 1 };
|
||||
|
||||
EVENT_TRACE_SYSTEM_TIMES = {};
|
||||
@@ -821,185 +819,6 @@ function EventTraceFrameEvent_OnClick(self)
|
||||
EventTraceFrame_Update();
|
||||
end
|
||||
|
||||
------------------------------------------------------------------------------
|
||||
-- ScriptErrorsFrame
|
||||
------------------------------------------------------------------------------
|
||||
|
||||
local ERROR_FORMAT = "|cffffd200Message:|r|cffffffff %s|r\n"
|
||||
.. "|cffffd200Time:|r|cffffffff %s|r\n"
|
||||
.. "|cffffd200Count:|r|cffffffff %s|r\n"
|
||||
.. "|cffffd200Stack:|r|cffffffff %s|r";
|
||||
|
||||
local INDEX_ORDER_FORMAT = "%d / %d";
|
||||
|
||||
local _ScriptErrorsFrame;
|
||||
local _previousErrorHandler;
|
||||
|
||||
function ScriptErrorsFrame_OnLoad(self)
|
||||
local titleFS = getglobal(self:GetName() .. "Title");
|
||||
if (titleFS) then
|
||||
titleFS:SetText("Lua Error");
|
||||
end
|
||||
self:RegisterForDrag("LeftButton");
|
||||
self.seen = {};
|
||||
self.order = {};
|
||||
self.count = {};
|
||||
self.messages = {};
|
||||
self.times = {};
|
||||
_ScriptErrorsFrame = self;
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_OnShow(self)
|
||||
ScriptErrorsFrame_Update();
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_OnError(message, keepHidden)
|
||||
if (message == nil) then return; end
|
||||
local stack = debugstack(DEBUGLOCALS_LEVEL) or "";
|
||||
|
||||
local messageStack = message .. stack;
|
||||
|
||||
if (_ScriptErrorsFrame) then
|
||||
local index = _ScriptErrorsFrame.seen[messageStack];
|
||||
if (index) then
|
||||
_ScriptErrorsFrame.count[index] = _ScriptErrorsFrame.count[index] + 1;
|
||||
_ScriptErrorsFrame.messages[index] = message;
|
||||
_ScriptErrorsFrame.times[index] = date();
|
||||
else
|
||||
table.insert(_ScriptErrorsFrame.order, stack);
|
||||
index = table.getn(_ScriptErrorsFrame.order);
|
||||
_ScriptErrorsFrame.count[index] = 1;
|
||||
_ScriptErrorsFrame.messages[index] = message;
|
||||
_ScriptErrorsFrame.times[index] = date();
|
||||
_ScriptErrorsFrame.seen[messageStack] = index;
|
||||
end
|
||||
|
||||
if (not _ScriptErrorsFrame:IsShown() and not keepHidden) then
|
||||
_ScriptErrorsFrame.index = index;
|
||||
_ScriptErrorsFrame:Show();
|
||||
else
|
||||
ScriptErrorsFrame_Update();
|
||||
end
|
||||
end
|
||||
|
||||
-- Chain through to whatever previous handler existed (e.g. BugGrabber)
|
||||
if (_previousErrorHandler and _previousErrorHandler ~= ScriptErrorsFrame_OnError) then
|
||||
pcall(_previousErrorHandler, message);
|
||||
end
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_Update()
|
||||
local editBox = getglobal("ScriptErrorsFrameScrollFrameText");
|
||||
local index = _ScriptErrorsFrame.index;
|
||||
if (not index or not _ScriptErrorsFrame.order[index]) then
|
||||
index = table.getn(_ScriptErrorsFrame.order);
|
||||
_ScriptErrorsFrame.index = index;
|
||||
end
|
||||
|
||||
if (index == 0) then
|
||||
editBox:SetText("");
|
||||
ScriptErrorsFrame_UpdateButtons();
|
||||
return;
|
||||
end
|
||||
|
||||
local text = string.format(ERROR_FORMAT,
|
||||
_ScriptErrorsFrame.messages[index],
|
||||
_ScriptErrorsFrame.times[index],
|
||||
_ScriptErrorsFrame.count[index],
|
||||
_ScriptErrorsFrame.order[index]);
|
||||
|
||||
editBox:SetText(text);
|
||||
editBox:HighlightText(0);
|
||||
editBox:SetCursorPosition(0);
|
||||
|
||||
local scrollFrame = getglobal("ScriptErrorsFrameScrollFrame");
|
||||
if (scrollFrame and scrollFrame.SetVerticalScroll) then
|
||||
scrollFrame:SetVerticalScroll(0);
|
||||
end
|
||||
|
||||
ScriptErrorsFrame_UpdateButtons();
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_UpdateButtons()
|
||||
local index = _ScriptErrorsFrame.index;
|
||||
local numErrors = table.getn(_ScriptErrorsFrame.order);
|
||||
local nextBtn = getglobal("ScriptErrorsFrameNext");
|
||||
local prevBtn = getglobal("ScriptErrorsFramePrevious");
|
||||
local idxLbl = getglobal("ScriptErrorsFrameIndexLabel");
|
||||
|
||||
if (index == 0 or numErrors == 0) then
|
||||
nextBtn:Disable();
|
||||
prevBtn:Disable();
|
||||
else
|
||||
if (numErrors == 1) then
|
||||
nextBtn:Disable();
|
||||
prevBtn:Disable();
|
||||
elseif (index == 1) then
|
||||
nextBtn:Enable();
|
||||
prevBtn:Disable();
|
||||
elseif (index == numErrors) then
|
||||
nextBtn:Disable();
|
||||
prevBtn:Enable();
|
||||
else
|
||||
nextBtn:Enable();
|
||||
prevBtn:Enable();
|
||||
end
|
||||
end
|
||||
|
||||
idxLbl:SetText(string.format(INDEX_ORDER_FORMAT, index, numErrors));
|
||||
end
|
||||
|
||||
function ScriptErrorsFrameButton_OnClick(self)
|
||||
local id = self:GetID();
|
||||
if (id == 1) then
|
||||
_ScriptErrorsFrame.index = _ScriptErrorsFrame.index + 1;
|
||||
else
|
||||
_ScriptErrorsFrame.index = _ScriptErrorsFrame.index - 1;
|
||||
end
|
||||
ScriptErrorsFrame_Update();
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_TitleButton_OnDragStart()
|
||||
_ScriptErrorsFrame.moving = true;
|
||||
_ScriptErrorsFrame:StartMoving();
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_TitleButton_OnDragStop()
|
||||
_ScriptErrorsFrame.moving = nil;
|
||||
_ScriptErrorsFrame:StopMovingOrSizing();
|
||||
end
|
||||
|
||||
function ScriptErrorsFrame_HandleSlashCmd(msg)
|
||||
if (msg == nil) then msg = ""; end
|
||||
msg = string.lower(msg);
|
||||
if (msg == "on" or msg == "install") then
|
||||
_previousErrorHandler = geterrorhandler();
|
||||
seterrorhandler(ScriptErrorsFrame_OnError);
|
||||
_ChatPrint("Lua error capture installed.");
|
||||
elseif (msg == "off" or msg == "uninstall") then
|
||||
if (_previousErrorHandler) then
|
||||
seterrorhandler(_previousErrorHandler);
|
||||
end
|
||||
_ChatPrint("Lua error capture uninstalled.");
|
||||
elseif (msg == "test") then
|
||||
ScriptErrorsFrame_OnError("test error from /luaerrors test");
|
||||
elseif (msg == "clear") then
|
||||
_ScriptErrorsFrame.seen = {};
|
||||
_ScriptErrorsFrame.order = {};
|
||||
_ScriptErrorsFrame.count = {};
|
||||
_ScriptErrorsFrame.messages = {};
|
||||
_ScriptErrorsFrame.times = {};
|
||||
_ScriptErrorsFrame.index = 0;
|
||||
ScriptErrorsFrame_Update();
|
||||
else
|
||||
if (_ScriptErrorsFrame:IsShown()) then
|
||||
_ScriptErrorsFrame:Hide();
|
||||
else
|
||||
_ScriptErrorsFrame:Show();
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
------------------------------------------------------------------------------
|
||||
-- FrameStackTooltip
|
||||
------------------------------------------------------------------------------
|
||||
|
||||
Reference in New Issue
Block a user