mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 16:10:36 +00:00
35b8eaa37614aa4c39ec72af5a1c4663dc7addd3
1
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
42ed0d27c7 |
Port the later clients' Cooldown API (#112)
* Add retail Cooldown methods and OnCooldownDone Port the post-4.3.4 Cooldown API onto the native CGCooldown frame: Clear, Pause/Resume/SetPaused/IsPaused, GetCooldownTimes, GetCooldownDuration, GetCooldownDisplayDuration, SetCooldownDuration, SetCooldownFromExpirationTime, the modRate argument, SetDrawSwipe, SetDrawBling, SetSwipeColor, SetEdgeColor, the drawSwipe/drawBling XML attributes, and the OnCooldownDone script (via Frame::ExtraScripts). Behavior follows retail probes, not the generated doc strings: the getters report the end flash once the sweep ends, modRate scales the flash and the display duration but not the sweep, and a reverse cooldown flashes and hides like any other. Add CooldownFrame_Set, CooldownFrame_Clear and CooldownFrame_SetDisplayAsPercentage to the embedded addon. * List the new Cooldown methods in the README table * Add Cooldown swipe, edge and bling textures SetSwipeTexture, SetEdgeTexture and SetBlingTexture, and the <SwipeTexture>, <EdgeTexture> and <BlingTexture> XML elements, split 4.3.4's star texture into three slots. An empty file is the engine's solid texture tinted by the slot colour, and Interface\Cooldown\edge maps to the built-in edge texels. A setter without r, g, b keeps the colour, as retail does. Slots left unset get 4.3.4's textures at the first SetCooldown, so the defaults stay 4.3.4's. The swipe's texcoords now map its positions over the frame so a custom texture lines up. * Add Cooldown rotation SetRotation / GetRotation and the XML rotation attribute (degrees) move where the sweep starts, clockwise from the top, as retail does. The sweep is now one polygon along the frame's outline in place of 4.3.4's four octant functions, with the same timing (each half side an eighth of the duration) and, at rotation 0, the same shape. The one difference is 4.3.4's reverse octant 1, which drew one triangle twice. * Add Cooldown countdown numbers Every Cooldown gets a countdown font string (FRIZQT__ 16 OUTLINE, centred), shown while retail's countdownForCooldowns CVar is 1; the CVar defaults to 0, so the default look stays 4.3.4's. The text follows retail: seconds, then m:ss below the abbreviation threshold, then whole minutes, hours and days rounded up, and nothing for cooldowns no longer than the minimum duration or during the flash. Adds SetHideCountdownNumbers / GetHideCountdownNumbers, GetCountdownFontString, SetCountdownAbbrevThreshold / GetCountdownAbbrevThreshold, SetMinimumCountdownDuration / GetMinimumCountdownDuration and the hideCountdownNumbers and minimumCountdownDuration XML attributes. * Add the Cooldown countdown milliseconds threshold SetCountdownMillisecondsThreshold / GetCountdownMillisecondsThreshold: below the threshold the numbers show tenths, rounded up, as retail does (threshold 5: 4.973 shows 5.0, 3.24 shows 3.3, 0.039 shows 0.1). The default is 0, so the numbers stay whole seconds. * Fix the Cooldown review findings - A zero-length timer (a new frame, SetCooldown(t, 0)) hides without the bling flash or OnCooldownDone, instead of flashing and reporting (now, 1000) from the getters. - Countdown text rounds up with integer math (700 ms read "0.8") and picks its unit on the rounded-up seconds (59.4 s read "60", not "1:00"). - SetMinimumCountdownDuration and minimumCountdownDuration clamp to the uint32 range. - The edge texcoord rotation uses the guarded done fraction (0/0 gave NaN). - Texture slots are one array with per-slot tag, default file and draw layer (Offsets::DRAWLAYER_*), replacing the ternaries and bare 2/3. - The header lists where the state machine follows retail over 4.3.4. edge.blp is now served to every texture load by texture/Builtin.cpp, a hook on TextureCreateFromBlp that falls back to the DLL's texels only when SFile has no such file; TextureCreate caches and ref-counts it like a file. Cooldown loads it by path and drops its edge special case. Frame::Region::CreateTexture / CreateFontString replace the hand-rolled pool-alloc + ctor copies in Cooldown, LinePool, BarTexture, SoftTargetIcon and InlineTexturePool. |