mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
Generalize the item-only Tooltip::SetItemEvent into Tooltip::SetEvents, backing all four object tooltip scripts through one shared fire path (stack save/restore + recursion guard + Suppressor). One resolver co-hook recognizes all four OnTooltipSet* names (the per-tooltip cell now holds a slot per kind), plus one builder co-hook per kind firing its script after the original build: - Spell -> FUN_0052E610 (SetSpell/SetSpellByID/SetTalent/SetShapeshift; 7 stack args, RET 0x1c) - Unit -> FUN_00529fe0 (SetUnit + mouseover; 1 arg, returns an int the caller tests -> co-hook forwards it) - GameObject -> FUN_0052aa20 (GO hover populator; 1 arg) Each hook's declared stack-arg count matches its callee RET N (verified from disassembly) so the caller's stack isn't corrupted. Auras deliberately do NOT fire OnTooltipSetSpell: SetUnitBuff/Debuff/ PlayerBuff funnel through a separate aura-tooltip builder (FUN_0052f880) that bypasses the spell builder -- matching retail, where unit auras are a distinct tooltip data type. Verified in-game: all three new scripts fire (spell hover, unit mouseover, gameobject mouseover), item still fires, no crash.
33 lines
1.4 KiB
C++
33 lines
1.4 KiB
C++
// This file is part of ClassicAPI.
|
|
//
|
|
// ClassicAPI is free software: you can redistribute it and/or modify it under the terms
|
|
// of the GNU General Public License as published by the Free Software Foundation, either
|
|
// version 3 of the License, or (at your option) any later version.
|
|
//
|
|
// ClassicAPI is distributed in the hope that it will be useful, but WITHOUT ANY
|
|
// WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
|
|
// PURPOSE. See the GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License along with
|
|
// ClassicAPI. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
#pragma once
|
|
|
|
namespace Tooltip::SetEvents {
|
|
|
|
// RAII guard that suppresses tooltip set-event firing (OnTooltipSetItem etc.)
|
|
// for the duration of an engine build we invoke *internally* — currently
|
|
// Tooltip::Compare building the equipped item into a shopping tooltip. Without
|
|
// it, a handler would run in the middle of our line-shift / delta rendering and
|
|
// see a half-built tooltip. Only the item builder runs during that internal
|
|
// build, so in practice this gates OnTooltipSetItem; it's global for safety.
|
|
// Nestable (ref-counted).
|
|
struct Suppressor {
|
|
Suppressor();
|
|
~Suppressor();
|
|
Suppressor(const Suppressor &) = delete;
|
|
Suppressor &operator=(const Suppressor &) = delete;
|
|
};
|
|
|
|
} // namespace Tooltip::SetEvents
|