Files
ClassicAPI/src/item/scrape
Brues 48c2c83bd3 refactor(offsets): one name per engine address and per DBC column
Offsets.h named the same address or field twice in ten places, against
its own single-source rule. A sweep for equal addresses found nine; the
tenth is a column pair. Each now has one name:

- 0x468460 (the object resolver) was also FUN_GET_OBJECT_BY_GUID and
  FUN_OBJECT_FROM_GUID, called through local typedefs (one a __thiscall
  form) in mail/SendMailItemLink, item/scrape/AuctionSellID and
  cursor/Info. Those now call Object::ByGuid, which also gates on the
  registry; OBJECT_TYPE_ITEM goes for TYPEMASK_ITEM.
- 0x6F3BC0 was LUA_RAWGETI and FUN_FRAMESCRIPT_PUSH_OBJECT; its three
  callers use Game::Lua::RawGetI. 0x6F3740 (lua_touserdata) becomes
  LUA_TO_USERDATA beside the other Lua C API names.
- 0x605570: FUN_UNIT_CREATURE_TYPE (was also FUN_UNIT_PET_MINION_CLASS).
- 0xB4B2BC: VAR_GAME_STATE_PTR (was also VAR_WORLDFRAME_CLICK_INFO).
- 0xBC6F48: VAR_PARTY_GUIDS (was also VAR_PARTY_MEMBER_GUIDS).
- 0xBB4AA8: VAR_TAXI_NODE_COUNT (was also VAR_TAXI_MAP_NODE_COUNT).
- 0xCECAC0: VAR_SPELL_TARGETING_FLAGS (was also
  VAR_SPELL_PLACEMENT_STATE).
- Backpack linear base 23: INVMGR_BACKPACK_FIRST_SLOT (was also
  BACKPACK_LINEAR_BASE).
- Spell.dbc School (+0x04): OFF_SPELL_RECORD_SCHOOL (was also
  OFF_SPELL_SCHOOL); EffectItemType (+0x19C): OFF_SPELL_RECORD_EFFECT_ITEM_TYPE
  (was also OFF_SPELL_RECORD_CREATED_ITEM).

The surviving entry keeps both comments.
2026-11-15 16:46:43 -06:00
..