mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
The getn heal read a nil at the stored last slot as proof that nobody maintained the length. For a weak-VALUED table that is false: the collector clears those slots behind the writer, so `luaL_setn` is still exactly what the last append left and the holes below it come and go between two reads. Compost-2.0 is the casualty. `secondarycache` is `__mode = "v"`, filled with `table.insert`; `GetTable` walks it with `pairs` and calls `table.remove(cache, i)` on a live index. Once the GC clears slot 1 and the stored last slot, the heal bisects to border 0, `luaB_tremove` takes its `e == 0` empty-table early-out and returns NOTHING, and the next line indexes with the nil it got back -- "table index is nil" at Compost-2.0.lua:81, once per recycled table, in every addon that pulls Compost in through AceLibrary. The border search is what exposed it (5aa382b's table.insert switch is not involved -- Compost never appends a nil, so no mark ever applied to its tables). The walk-down it replaced returned the HIGHEST populated slot, which is always at or above the live index the pairs loop holds, so remove still found something; a bisect returns some border and probes its way down to 0 through the collected slots. That tradeoff was known and written down -- a weak cache read through table.remove is where it bites. So gate the heal: `__mode` mentioning "v" returns the stored length untouched, as rule 3, ahead of the mark. It costs one getmetatable and a raw `__mode` fetch on the already-rare unhealthy path, so the bisect keeps its win everywhere else, and the mode is read raw -- the same fetch the collector's own check uses. New plumbing: Game::Lua::GetMetatable, from the offset already catalogued in LuaCAPI.md. LuaEnv::Fenv had rolled its own copy; it now shares this one. Verified in game: a three-slot weak table with slots 1 and 3 collected reports getn 3 and hands back its live slot (0 and nothing before), and the Compost errors are gone.