mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
Backports the Forever beta swing-timer API. PLAYER_SWING and PLAYER_SWING_RANGE_UPDATE fire off the packets the engine already sends for melee/ranged auto-attacks, mirrored as state (parry haste, extra attacks, on-next-swing abilities, cast-time resets) rather than relayed 1:1, so N packets for one logical reset collapse into one event. Two bugs surfaced only by in-game testing, not by reading the disassembly: - FUN_UNIT_CAN_ATTACK (0x00606980) is __thiscall with the second unit pushed on the stack, not __fastcall(ecx,edx) -- Ghidra's decompile of the one caller renders it as a plain two-arg call either way, so the wrong convention crashed on a bogus ecx read off [ebp+8] garbage. Same trap as FUN_SET_CVAR_VALUE. - The generic engine range core (FUN_006e3480, what C_Spell.IsSpellInRange already uses) computes full 3D distance, but the server's actual melee-attack gate (Unit::CanReachWithMeleeAutoAttackAtPosition, WorldObject::CanReachWithMeleeSpellAttack) is explicitly 2D -- verified by landing hits at 5.08yd 3D distance that the 3D check rejected. Melee now gets its own 2D check (Combat::Swing::InMeleeRange), reading the same live engine reach constants; ranged keeps the 3D core, which matches the server's own (also 3D) generic spell-range gate. Also: attack-start no longer resets the off-hand timer unless the target is actually in range. Unit::Attack's off-hand reset fires the instant an attack is declared, even out of range, and the server just silently re-arms it every 100ms until you're close enough -- firing PLAYER_SWING there promised a swing time that was not real. Slam is special-cased for Turtle: every rank in Turtle's own client Spell.dbc carries AttributesEx2's swing-reset exemption, but packet timestamps show Turtle's server does not honor it for Slam -- both melee timers delay after casting it, contradicting both the client data and the public tortoise-wow reference source. Combat::Swing::AutoSwingResetOverride is a small extension point (mirroring Turtle::ComboDuration's Rip override) for this kind of server/client divergence; src/turtle/SwingReset.cpp registers the known Slam ranks. Verified in-game: swing detection (dual-wield, extra attacks coalescing to one event, cast-time resets), the melee range fix, and the attack-start range gate. The Slam override has not been rebuilt/retested yet.