mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 16:10:36 +00:00
Vanilla has no `/petattack`, so the conditional slash-command registry ADDS it. SuperCleveRoidMacros ships the same command under its own SlashCmdList key -- `PETATTACK` where we register `PET_ATTACK` -- and both set a `SLASH_*` string of "/petattack". Neither ever overwrites the other, so loading first decides nothing: `ChatEdit_ParseText` walks SlashCmdList with `pairs` and takes the first match, making the winner hash order. When ours won, `/petattack [hastarget,alive,harm]` fed that addon's conditions to `SecureCmdOptionParse`, which does not know `hastarget` or `alive`, so no clause matched and the line did nothing. Rejecting a condition we cannot evaluate is right by itself -- retail does the same -- so the fault is owning the command at all. A command we add and someone else already binds is handed back. Splitting one command across two condition parsers would be worse than one owner: the dialects disagree, and ours deliberately differs from 3.3.5 for an `[@unit]`-only group. Only added commands are given up. One we replace (`/cast`, `/target`) has no second entry to lose to, and an addon that wraps ours still chains through it. The check runs a frame after load, not at file scope -- this addon loads first, so nothing is registered to detect yet -- and not on PLAYER_LOGIN, which has already fired during a `/reload` and would run the check immediately to the same empty result. The addon load pass is synchronous, so one frame is enough on both paths. A command registered by a load-on-demand addon later keeps its own entry, and its coin flip.