mirror of
https://github.com/brues-code/ClassicAPI.git
synced 2026-11-16 08:00:42 +00:00
Three modules resolved these independently. equipmentset/Storage.cpp and friendlist/Notes.cpp had byte-identical copies of the same three engine reads (account, realm, character), the same null and empty gates, and the same separator joining — differing only in the leaf filename. settings/Account.cpp had a third copy of the account half, with its own inline pointer cast instead of Game::Read. Settings::Paths now owns that, exposing AccountFile and CharacterFile. Both return an empty string until the globals they need are populated, so callers keep treating empty as "not available yet" and no longer null-check the individual names. Behavior is unchanged: the paths built are the same strings, and the readers moved across verbatim. AddOns::SavedVarsFirst deliberately keeps its own copies. It mirrors the ENGINE's saved-variable layout and has to match it byte for byte, which is a different contract from naming ClassicAPI's own files — the two only happen to share a directory, and tying them together would mean an edit intended for one silently moving the other. Storage.cpp and Notes.cpp no longer reference Game or Offsets at all, so those includes go too.